Received-SPF: pass (google.com: domain of linux-kernel+bounces-182896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 18 May 2024 23:38:24 +0900
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
 Jonathan Haslam <jonathan.haslam@gmail.com>, Kui-Feng Lee
 <thinker.li@gmail.com>, Stephen Brennan <stephen.s.brennan@oracle.com>, Ye
 Bin <yebin10@huawei.com>, Steven Rostedt <rostedt@goodmis.org>,
 linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] probes updates for v6.10
Message-Id: <20240518233824.360de206ba709473495f89d7@kernel.org>
In-Reply-To: <CAHk-=wgQ_MNipb2fOSDmXJ9tYko8OhzA0fPueR-kh6eYT_MbDg@mail.gmail.com>
References: <20240516095216.ac9a0fd13357450cc5f2e491@kernel.org>
	<CAHk-=wgQ_MNipb2fOSDmXJ9tYko8OhzA0fPueR-kh6eYT_MbDg@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 17 May 2024 19:12:04 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, 15 May 2024 at 17:52, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > Probes updates for v6.10:
> 
> Grr,
> 
> This doesn't even build right.
> 
> Yes, it builds cleanly in an allmoconfig build, which is what I did
> before I pushed out.
> 
> But after pushing out, I notice that it doesn't build in more limited
> configurations and with clang, because:
> 
> > Stephen Brennan (1):
> >       kprobe/ftrace: bail out if ftrace was killed
> 
> This is no longer valid C code, and hasn't been for a long long while:
> 
>     void kprobe_ftrace_kill()
>     {
>         kprobe_ftrace_disabled = true;
>     }
> 
> we require proper prototypes, not some ancient per-ANSI K&R syntax.
> 
> It turns out that gcc apparently still accepts these things, but it
> really shouldn't. But with a clang build, you get a big error:
> 
>     kernel/kprobes.c:1140:24: error: a function declaration without a
> prototype is deprecated in all versions of C
> [-Werror,-Wstrict-prototypes]
> 
> and the reason it didn't get noticed in -next is that this commit had
> apparently not *been* in linux-next.
> 
> Dammit, that's now how any of this is supposed to work.
> 
> Why was this untested crap sent to me?

Oops, sorry, I missed when I built it in local.
Ah, and I missed to build it with W=1.

I appologies that and built in W=1 build test.


> 
>               Linus


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>