Received-SPF: pass (google.com: domain of linux-kernel+bounces-182901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <83b2db44-c7bc-49af-8634-d349b91dfab0@gmail.com>
Date: Sat, 18 May 2024 10:29:03 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling
To: Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
 linux-coco@lists.linux.dev, Sean Christopherson <seanjc@google.com>
References: <20240513181928.720979-1-michael.roth@amd.com>
Content-Language: en-US
From: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
In-Reply-To: <20240513181928.720979-1-michael.roth@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 5/13/24 13:19, Michael Roth wrote:

> The variable 'sev' is assigned, but never used. Remove it.
>
> Fixes: 449ead2d1edb ("KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event")
> Signed-off-by: Michael Roth <michael.roth@amd.com>


Reviewed-by: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>


> ---
>  arch/x86/kvm/svm/sev.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 59c0d89a4d52..6cf665c410b2 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3965,14 +3965,11 @@ static int __snp_handle_guest_req(struct kvm *kvm, gpa_t req_gpa, gpa_t resp_gpa
>  				  sev_ret_code *fw_err)
>  {
>  	struct sev_data_snp_guest_request data = {0};
> -	struct kvm_sev_info *sev;
>  	int ret;
>  
>  	if (!sev_snp_guest(kvm))
>  		return -EINVAL;
>  
> -	sev = &to_kvm_svm(kvm)->sev_info;
> -
>  	ret = snp_setup_guest_buf(kvm, &data, req_gpa, resp_gpa);
>  	if (ret)
>  		return ret;