Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1570187lqo; Sat, 18 May 2024 08:48:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXQvIYfljuHdMFfZ+n0sQlm0j+b8lPNbSzFgNJZJ6fib0pGl+hwnZk0WOGl/MfXmIs8APXGfFC0qcuzP/SSMS2iHJyKRrOfik04AtZrPw== X-Google-Smtp-Source: AGHT+IFPaA7oeIOJMqDB8HlyBmME7XfslTXXR/gVmfUdrcVbUqncCLxjFuksAu6KhP23hiVfW+e5 X-Received: by 2002:a2e:6101:0:b0:2e0:c689:f8cd with SMTP id 38308e7fff4ca-2e51ff6013emr176274551fa.29.1716047301046; Sat, 18 May 2024 08:48:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716047300; cv=pass; d=google.com; s=arc-20160816; b=dy5IEs321U3vXcmn7+7u/ouXJi1LiXSr3hj/PqimwMg99CVIK0JSC+lHk8gmzP5pZo p2pJKCQ0RA6HePEX+SxIE73Tui2ifDVDWUbbaM0ivoE6WGCDeuC5Ww+l7VM2BhL5Xfyp YtPlDLmEtexQd/w6IfGwCvnsYmKidK+PpO5/lTnA48EkpQjAfqLO+8xLUySX1srOTeX1 nD6NLpOJkozDCdVvGxilhvpXV+QA+eUwZ4PI8Iq5lw5pz/KWOFofTiYtSThr1UygxSbo l/tUg7SoXQqwdVRQUujHPNrldofsn3fit6SWYAIPudfbtQLSrNGx0qtdau5+kAeKClYL 3oKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=6CQBI/V+OTu0DG9J0ueZD3P2Z4L50xI4hu465oEEtDk=; fh=LF52Q9PhA10uJpOxRqt0rVCSmYPho5J+guMAk9NOcWE=; b=smBeNfCZphWrfKLMeOUxceWh7VnqWt/CGNwnZwQja4FAfCX73d52eiRDA4xqPC3i/4 EFlx/ywEUBYOfaM2YWekO6FOytMJYdQisFVPh7scxZhvS4+RftrFabq+M9AlfXJ/4swg jPlya+kG2PSCjWQ00zqPu/sQd+S7/u3a3vJKY/l3aZol7I//Gs/b9HiqecAWkjgeyX+R ugeQhd0YvcSFwNtKCyYvhciB00LKU9zbaf8Uekm7J1WRqQMx4RzhQLsxLOhRaPjIO/vn dEg6zAoPSO838wL9Mj4TETwZAzQ8G8WM2FxK5pAKB4wE6gkmxHoWf18hcsFjC1/pb2+J xFJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=YFYszTAW; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-182904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5751aefad10si2175173a12.207.2024.05.18.08.48.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 May 2024 08:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=YFYszTAW; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-182904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182904-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B167A1F21838 for ; Sat, 18 May 2024 15:48:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5758F4652D; Sat, 18 May 2024 15:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="YFYszTAW" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C44EB2A8CD; Sat, 18 May 2024 15:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716047289; cv=none; b=Uao3Xnzm5d3eQYI6PRsiQQLS2YJ7wo5lDOU490tBKvN5+Bn4m6accJnU9SmOeLTWKpBu9fiD9LeLONHN4rTcu7BBEHX81SweKMhec4h8pwh7J70iUQyeH8HR1ZJfiC+B44hWEeGuBGfqxqcKroN9WrCJ6llTMD/ho93yFEQMGv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716047289; c=relaxed/simple; bh=6CQBI/V+OTu0DG9J0ueZD3P2Z4L50xI4hu465oEEtDk=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=stXfKOsc0RxzFB2oKnYr/ex3hJLL05+vBRPWXkM1yc7o2galrVmDTZOn76um/+iqmdr+Jm5K5pse5iikXiZ18lO7HBVoPEZrrn5StX3gzhHMy4Dzs6u458qh80N2CoprePYewc6evnRDkJbn8DQV3pm3LAFZLFK+W7mdb0ahf0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=YFYszTAW; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716047263; x=1716652063; i=markus.elfring@web.de; bh=6CQBI/V+OTu0DG9J0ueZD3P2Z4L50xI4hu465oEEtDk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YFYszTAWHMhh+ZHmXEI0ZXxi2StQvVxNr4rdSFrLLFITsbEFiUeKsmxtdxoo9wzU 0G9T0gmbIyZJAR+hR3ZUJMVrMkm+iVRp1lzzWX0gfz00l4tbnVnDm1xk+uSu7P2yM s2ESAGDBgfpHdHSeX7mc0F7J/os6DfGbmCZMqp8h8s77962OPpl2BMCVX0ncy/Syg tQrbzGJroGm/UdXGPXLUFzkcUCW7zIHF9isVQ8mzfsotkfUgWM34mTv9WvRq5OJbE x7qRZOm16ELDs9KdCK4UFXGcGqLHAQEnSdP7XeNgZsLlCXUIGe8y8ZmIK3RQtyCI/ VstJO+0Wl8HJuU9Tkg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.82.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MK52w-1rq88n1oMw-00SgTM; Sat, 18 May 2024 17:47:43 +0200 Message-ID: Date: Sat, 18 May 2024 17:47:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Andrea Mayer , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, David Ahern , David Lebrun , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: LKML , Ahmed Abdelsalam , Paolo Lungaroni , Stefano Salsano References: <20240517164541.17733-1-andrea.mayer@uniroma2.it> Subject: Re: [net] ipv6: sr: fix missing sk_buff release in seg6_input_core Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240517164541.17733-1-andrea.mayer@uniroma2.it> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kQX8iIydzzNB+PxhL2aj41fD8pK1oP6Q2Gruh58RP4/WeX3kQkh JiagPXRe8fZbeAjMIjHQ5pc9Hwpg0ES+Y0lxolmHTdGL/s2PUfsYzGD9sXDJ5E+HnVo/woB xWMvnicO+gnpNj0oGhGzg4Xz0rxclgpefY8NlDicCvKPLnwUXPAHr/UfzZBOUAMn5GU6AID sG4CtCie1jU+ry8j9nNew== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/bf+4/7Ejmg=;nfNAGY9G9W60Ha9S8uKelk0KCyd WJxVb92xqA6cyrG9etcs1ZNUOrbnakEpZub5FVPxPK6u7s4zeI55QTTcef6ymopaYSDKVfHeX Jm+TJDZw8vbGjr787ZfAUsMnJo48DF04qL34VTTBJhiarn2TQ0PvqNiKzJ77QLrIVwPCKhOTn 8oOvtFXq+UlDeD6QwQwLmF/uHKdCy32cFo6ACPv6x3GaXjhRHz4whgsrm+15Ds9m94/ZXQnK/ bQz9pmgjStKVfrz3ZeAcLwbpN15vTw5tGHBexzpTMOV4ExU0lUhi+4PT3VBINpKeyJ+ZBh9pc RKE4ApA/o32gqdlJptPOi9d2/TN20WAZlFPh8AFmgkHARpT8GZdH/0DI/J6dSgqnsYdnhFMhb 1GTSnV5RBrudagX3qtjJH2gxbNDkIBse1iVoO9tO/TPpBFObRFDxvKPpbc6929aDWzgZSI/No 5jisMsigX79fXOpTNwxyUvBcI1Qxy7s90nD8leXX7LIXZm5Z+q/I1DTd8YTKoiH9Ou+DJXJcj RM7ZSpWElouS7xzNpogs8rqgzCZdToTC3olaOQu2pfypy0iD2xtVa1fCulkDTOJsLb5QCWgDA 9PUZFjnXMhq2iFjzWCZ395XkK+dxCFam61opKehPUwiPjNO4KxT7svV3VBUVZPxW8NNPjHY7C 7B6NM5Flf2LDSYnW0MN+iXCE8g6AUZR96LOKl4N1iJfRsS/kUGUA4s+TJXgJ8v7Ql9sZDJ5Fr RrJ3I4JXc04RlplAStyC3uGb5Zu8uamBCSCWhx4BvuRaPNezljncIbdmiWTx4Lh3iTVOlhefn mCwqlYl49FoNSXKg+EpIp1XV52W9VmBWxIwElD6nMLd7I= * The message subject would have been a bit nicer with the key word =E2=80= =9CPATCH=E2=80=9D. * How do you think about to append parentheses to the function name? =E2=80=A6 > The proposed patch addresses the identified memory leak by =E2=80=A6 Will a corresponding imperative wording be more desirable for an improved change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.9#n94 Regards, Markus