Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1597302lqo; Sat, 18 May 2024 09:54:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX4vStPxJXSrHavKxvIcUQDAq82c582F0aO9gpub7F4JWuikbvttQvgjBF+tVIFb5aR0PhV8CM6xxtuEzBGYEWA2A56Rv7MIyKAK/rpoA== X-Google-Smtp-Source: AGHT+IH+Q3sjGd4MxSS9trhrmxmjeMywsUuU++4WJNRIdQL2Jh+Dneak8wwALI14mBK3L1Rfc12X X-Received: by 2002:a50:870d:0:b0:572:6af5:1b61 with SMTP id 4fb4d7f45d1cf-5734d597d67mr23437773a12.6.1716051283280; Sat, 18 May 2024 09:54:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716051283; cv=pass; d=google.com; s=arc-20160816; b=S1vndPJHmdWjtpI3Nl9mYLpRed08j4Q/dcDgDP7tWhbdpIKosXe8xjojD+QNhu9I2L VqOZ8lfAFLowXGNnsSEnuEOVry/IFOZQAWB53JaUIrP6l5Bcy5RtTo1W8KSpcrMZIgyC cGOYRipOlDlmkIkTyIZX3A/nyJ7wv3tG30MY/eXa4FlHr1PQ8O22ye6i71TWA6jWhrMs pG9ZbYhrhZ8W3KcryN5TNWtJsEJIEDnEpz0VP+Bky7I+PzlcNMBquIYisfYfQrGgy6/J DEwI0H1IO51pS52RcfzDYVkr8Qp1+unk8Io1Xj9RlhKZE/6PWfTex5fA9p1TLllL5PbY Z3zQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Cy6QgkzIvtwsksNyfer6Kzitx6I6rlqiDcesoICXdK0=; fh=6AWrVfDjGU7mMZ9jt2M10DHeKe7gtS9WAOEarVIs8Ig=; b=FDNaZmCfAisTyw58hSyyYdYB5s4pnn4BRBuM6l7DFFG/kRR1de7o97OHqJf6awXVkE De9E/XvtTzQh3UXx8tg/JeBGrWKedddenWyDJ0EtxhCa0+jYWAo6NxbsGZjia33fYTia jCmvXCQTOvJFWMC3kHrCsatrjCRtD0b06SHySZfzr9A8JxrrZwZClZY9bVthGmvqTZqE fJfc1xm+6rAtZXAJl2/kCkFvnZypGshOVvhNnFu1QL0yv2gRNedGJFA4Tr6wtBKep+RU cGNrX2x6eJPKhbiU6R7+v14bCrtyxHWUDdiEFHkpQ/hbe4rnMfAQM1tpIRPKSoBxANul mRMw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HkEikk6Q; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-182917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182917-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733beacb7csi11193515a12.81.2024.05.18.09.54.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 May 2024 09:54:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HkEikk6Q; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-182917-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182917-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EEA281F21C7F for ; Sat, 18 May 2024 16:54:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2485C4597F; Sat, 18 May 2024 16:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HkEikk6Q" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80585380F for ; Sat, 18 May 2024 16:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716051274; cv=none; b=W7o1uKBih9eCIwus+VM5NDr0o5y7d4UAvMNmRCs/f/sqRRIX1s4gG5G3S0byCYbNg1aXuAmp768mCZQdmr4p+YLlbABd2IwARgqhyoF2YrVPfgxXDNmknIw9DbuhOveLwvQ614FpwpH58uZyooZe7YrvYunsHbQcpdteHSJG6jQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716051274; c=relaxed/simple; bh=Cy6QgkzIvtwsksNyfer6Kzitx6I6rlqiDcesoICXdK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P7MzJihWvzJRIAUV4ugQaIRyDi6a5ruYZwfU4S0cUhLa21bDxhD9Xe12EKFgNxTgilnlkNSi3M6BZL4ideSSvfipvrbtXX5dKM7A+xbNwT3gDbOvoSorOJTQxIK4chZjUwEnRElCH3XfVnqwwAeVKjHVq7ClXjxOchB0S/TPM1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HkEikk6Q; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-523b017a5c6so4520813e87.1 for ; Sat, 18 May 2024 09:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716051271; x=1716656071; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cy6QgkzIvtwsksNyfer6Kzitx6I6rlqiDcesoICXdK0=; b=HkEikk6QlWpDqyAzvbLR5eEgMqXn/9BOPckhVKAOOBF+hy50fhjlK18fcGJDfk/2mj 7wFWFmj9mxWOhfwueN6V/TdPxHJDc3k+lE/73tCbjzeMrG6QfeNE82/816NjzoksdZNz NWqfI1VAW3B5Qej5lgD2PxvoeD4Hps+iF13IIBhVHkHgLL0gCPKltPsnl2GDYad7FQjs RwROp/+FAvTau11RwyR0VM6Y2kdTqY1WyYDwqi/rWvZhEGdkp1W2CwpKbirp08lz0+lN x0xI0Y8pkN5nt2HUKNqwrqiWnmbz5WtlHtm/qxW0XDdqndE2LuJbcnejojvTqiFz69n3 sxCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716051271; x=1716656071; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Cy6QgkzIvtwsksNyfer6Kzitx6I6rlqiDcesoICXdK0=; b=wXcfecHScAmpn7AvdPNyaaVYQLJsZiptU/R91A5pRpiF4Jgd6AHfkrRFg4bM7jrzYN tENvWUJTK2W9MOq2YT1jyRX9Rsbro59L8MBqqgJ6huyqowIKb22dMVkEU3RIeG7ZCnJe aOT3adQyZTf3o3tq1l/QKnkT3gsNXdKAQEa1reA9+L9MoQRnHvuPL7Y2RZBsHarx3FWC YAlFPm2qc3E0qfjMrq0CobyXWgKaAFnkY4iRRdLxYGmSYnWAsybZaBoezz+9gXRLqS6B 4Ku7L3Bt4qlU+ewrOVVe06dOXcliMxpWIxrMpkH8YRfBE8rA4FTYGnTDQ8Kw5I1zHQ7q CDDQ== X-Forwarded-Encrypted: i=1; AJvYcCURinM5z5Wl62AMnWiUiVDpM+Ikl02ReCBO01163XV45CrGFyNPxt30rtIh3D7El6AW5zlu5kZb0xQuLj7TiA4G63eWORuwcvZzWd// X-Gm-Message-State: AOJu0YxbiecSkrFsNyJHqDFBbY0pUzvUN5uwS5pPSKbQwz3g87j7TIFt DiTD+kXiWjtKXdMFdmv+RmRUw92qvTy7uqqk+rUgMsi8xpdS3LIo+DC/lG6AOQ== X-Received: by 2002:ac2:4181:0:b0:51f:36ed:ee43 with SMTP id 2adb3069b0e04-5220fe797bcmr18519511e87.31.1716051270699; Sat, 18 May 2024 09:54:30 -0700 (PDT) Received: from google.com ([2a00:79e0:18:10:8b68:8208:4316:d53b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f35ad4basm3605671e87.59.2024.05.18.09.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 May 2024 09:54:30 -0700 (PDT) Date: Sat, 18 May 2024 18:54:26 +0200 From: "Steinar H. Gunderson" To: acme@kernel.org Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, irogers@google.com Subject: Re: [PATCH v2] Add a trie to map quickly from address range to compilation unit. Message-ID: References: <20240518165315.3963142-1-sesse@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240518165315.3963142-1-sesse@google.com> On Sat, May 18, 2024 at 06:53:11PM +0200, Steinar H. Gunderson wrote: > When using perf to profile large binaries, _bfd_dwarf2_find_nearest_line() > becomes a hotspot, as perf wants to get line number information > (for inline-detection purposes) for each and every sample. In Chromium > in particular (the content_shell binary), this entails going through > 475k address ranges, which takes a long time when done repeatedly. I accidentally sent out an ancient patch anew; sorry, please ignore. /* Steinar */