Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1843158lqo; Sun, 19 May 2024 01:02:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUkSgwKWu+UyR/f2n/oen+w2M6GDqU0k2GplWXraljuFi6yvH2jpK9CIGjHy0ffIzBSnqS2XDFBagK6Gvtx3N3jQ9VH1dtMQ1GPMKCUyg== X-Google-Smtp-Source: AGHT+IHtWAclbaQdKNOwNIs7NUWTnyJvPKNx7V1UWiKiienvjeXffm9CXXS7+1f4pPmZa0fX8fqV X-Received: by 2002:a17:902:ef43:b0:1f2:fc59:59ed with SMTP id d9443c01a7336-1f2fc595f7bmr5408215ad.54.1716105615798; Sun, 19 May 2024 01:00:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716105615; cv=pass; d=google.com; s=arc-20160816; b=SADT5gh9P/1hFqLuv7U2W8yARwGbZELKHLPEW5caRzOIGVma8mz57RmF8+xMXkJjAc 5d9SvphcK5L4fobZnXZjnoDr3Tpu/9LiKqE13A9i3uvb40CJPqsJUckIkc6+EL/CdCQe 32MosbDQnJXiuiNCPwYLOwkCmKoTSpcOD8tK48D0TIs21LbeltuHUBMUqz5DqFqp4SLr knEyHBjcq7pWsSxVJ2YihBASMfrKtsIlA0ch6hb4lWRRZUVz9/MLIg9P4u5WizYK5NIL 5Gkgoo+ccejXubupBi1n16CXWuJJsU1SaSIy2kkMT5IvBY3afDH7GebNEWKSOCEJoLwL NidQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9sEOUo8b5ayX7rN4ArPEfoYD8PoJYStq20fCNaZ8gmQ=; fh=BVd7xdZqxJMYvY79HWbUmbNQFlHyzOCNcrT8eJAvLvs=; b=NwbwFV2Y+yFco0fT8HuSN4AxoVxqYMJLSjSWkMr+l8dsUhIlT4Zq+ecGFabgjIwuBC +XfL3NIT8RvqwSznrusWUhWogIkI969H91vsujGO2/iQ38neq1BS0hCw5dyKou25qGRc NQOP8WkzUirWaokxVFskSE1p/dJ3f7aESpjjtnqIWfj7+rSjbhvqQN4VCGBVqHUtu141 zJ+5TW/aJY/hGSPoaOg/ah9kYiPf7uegGRfyzNCJUquTAY11mFpPoMGvtyOmiUbOhagL 58sGZecVM5Y/jkkPf+YwvyRNLPTaiLa2fFrqflR36QOPZVD2Cr3hP/05hVA8NRWIXOo9 dsIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2MiSyS1O; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-183048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c15db4bsi217803255ad.534.2024.05.19.01.00.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 01:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2MiSyS1O; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-183048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 85706B20F98 for ; Sun, 19 May 2024 07:59:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FD34182BB; Sun, 19 May 2024 07:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2MiSyS1O" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E9BF1BC20; Sun, 19 May 2024 07:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716105591; cv=none; b=hNJIf316OskoxSVa0xNKDg/fC7G6w5E/vNv0iaT9yWvhEUYUB6fTtm27xbsdbYwhX1A5AjRakGu1tMZOqjxs2y2k1x4D8C2PURHIF+unvkGAKi3NYfQklljkvDa/ZgbdFXscWbSkU97bqUOiNZQJ1WhlYLBRxSXG4Be9OtiIsGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716105591; c=relaxed/simple; bh=Js533fXv07i00ZGY091MEl3ChJe/lib4LdV6Kq4wzIc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rGeXwtp1xpWp4lraDI0Di0Hifd97dUKSa/awElc2qKr5fpotlDYpJBBvqKkMPkvgSqeBHHjh9H3TZO/xEXV4bF7fRheJnr/czi7PewMSQUyHj/S2RYrqPRyOZzeVsU7+LeGFkAOhZU18iKlukwjhrBOWGdv/6bdc8sEpaExQ1vI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2MiSyS1O; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55ABBC32782; Sun, 19 May 2024 07:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716105590; bh=Js533fXv07i00ZGY091MEl3ChJe/lib4LdV6Kq4wzIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2MiSyS1OlozoQwxwtUwkCDqKXeCND4CH0dDYQqbT7fJjK9ZxDKBMY48MPbW/6vxpn ygZInnvC/+G/4ZA+IgCXOjN7J2ygMwgEPCNmjB+XuAAcpwvRpTRiKebKSupn00Qf8H uExc4kDcBAuzTOxuMi94XAcCZ+E+w+nc3kdm+Q7c= Date: Sun, 19 May 2024 09:59:47 +0200 From: Greg KH To: Val Packett Cc: stable@vger.kernel.org, Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066 Message-ID: <2024051936-cosmetics-seismic-9fea@gregkh> References: <20240519074019.10424-1-val@packett.cool> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240519074019.10424-1-val@packett.cool> On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > On the RK3066, there is a bit that must be cleared on flush, otherwise > we do not get display output (at least for RGB). > > Signed-off-by: Val Packett > Cc: stable@vger.kernel.org > --- > Hi! This was required to get display working on an old RK3066 tablet, > along with the next tiny patch in the series enabling the RGB output. > > I have spent quite a lot of time banging my head against the wall debugging > that display (especially since at the same time a scaler chip is used for > LVDS encoding), but finally adding debug prints showed that RK3066_SYS_CTRL0 > ended up being reset to all-zero after being written correctly upon init. > Looking at the register definitions in the vendor driver revealed that the > reason was pretty self-explanatory: "dma_stop". What commit id does this fix? thanks, greg k-h