Received-SPF: pass (google.com: domain of linux-kernel+bounces-183078-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240519092227.2101109-1-masahiroy@kernel.org>
In-Reply-To: <20240519092227.2101109-1-masahiroy@kernel.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Sun, 19 May 2024 18:34:40 +0900
Message-ID: <CAK7LNAQdNAEwaoe_fU5Pe2ieM+ayDsEnequQiY+MCKzn1=r8TQ@mail.gmail.com>
Subject: Re: [PATCH] kconfig: fix comparison to constant symbols, 'm', 'n'
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 19, 2024 at 6:22=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> Currently, comparisons to 'm' or 'n' result in incorrect output.
>
> [Test Code]
>
>     config MODULES
>             def_bool y
>             modules
>
>     config A
>             def_tristate m
>
>     config B
>             def_bool A > n
>
> CONFIG_B is actually unset, while the expectation is CONFIG_B=3Dy.
>
> The reason for the issue is because Kconfig compares the tristate values
> as strings.
>
> Currently, the .type fields of the constant symbols, 'y', 'm', and 'n'
> are unspecified, i.e., S_UNKNOWN.
>
> When expr_calc_value() evaluates 'A > n', it checks the types of 'A' and
> 'n' to determine how to compare them.
>
> The left-hand side, 'A', is a tristate symbol with a value of 'm', which
> corresponds to a numeric value of 1. (Internally, 'y', 'm', and 'n' are
> represented as 2, 1, and 0, respectively.)
>
> The right-hand side, 'n', has an unknown type, so it is treated as the
> string "n" during the comparison.
>
> expr_calc_value() compares two values numerically only when both can
> have numeric values. Otherwise, they are compared as strings.
>
>     symbol    numeric value    ASCII code
>     -------------------------------------
>       y           2             0x79
>       m           1             0x6d
>       n           0             0x6e
>
> 'm' is greater than 'n' if compared numerically (since 1 is greater
> than 0), but small than 'n' if compared as strings (since the ASCII
> code 0x6d is smaller than 0x6e).
>
> Specifying .type=3DS_TRISTATE for symbol_{yes,mod,no} fixes the above
> test code.
>
> However, this would cause a regression to the following test code.
>
> [Test Code 2]
>
>     config MODULES
>             def_bool n
>             modules
>
>     config A
>             def_tristate n
>
>     config B
>             def_bool A =3D m
>
> You would get CONFIG_B=3Dy, while CONFIG_B should not be set.
>
> The reason is because sym_get_string_value() turns 'm' into 'n' when
> the module feature is disabled. Consequently, expr_calc_value() returns
> the result of 'A =3D n' instead of 'A =3D m'. This oddity has been hidden
> because the type of 'm' was previously S_UNKNOWN instead of S_TRISTATE.
>
> sym_get_string_value() should not tweak the string because the tristate
> value has already been correctly calculated. There is no reason to
> return the string "n" where its tristate value is mod.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---


Fixes: 31847b67bec0 ("kconfig: allow use of relations other than (in)equali=
ty")


--=20
Best Regards
Masahiro Yamada