Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1901635lqo; Sun, 19 May 2024 04:19:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUnckwHbJhqQjSD4s/PJrKpJ3uXplzAldoT4QFxyD9FqsdvcrR9CzAu3cHX4FsCPkkVBzS11ooZAhNn4H1cTfTHBWVzZ0pOpi0fxcCL6A== X-Google-Smtp-Source: AGHT+IHr2nBo8QqTsuDnIDT3JV9l0IwaKko3abnhBH0w1XC1POtjDFBNvNbvTrpq5VQpF6ljUzW0 X-Received: by 2002:a05:6870:6588:b0:23e:b5e3:ac54 with SMTP id 586e51a60fabf-24172f8716amr28517263fac.56.1716117574227; Sun, 19 May 2024 04:19:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716117574; cv=pass; d=google.com; s=arc-20160816; b=Ar/xxJswVvgqwpq+SYlrGznhsHXOIihul6RCCI8Fp3hy5XT3cMtSrsUA6+yUtx0xZs DMR/5377iBRJPYDudcr2uOv2FdSDYLh6VJ7keP7aeMIFwgDck3QsX+i9AF2YdSOwFkf8 MxjGqOpk+IK4sMN3aaMJTqN4QrWGY7sQkPrtZKmDk24CyOrDbxlEA+3kSqWV/AA+fFly AKyO5isgEJwQr09rNPNOkety1PPK3t8NGbcpiqy4kMcX647xNT7y4SnrolnJgaKaxLv4 uQoWddVmhdYMaXscKMOUlp2JD7CRymLtk0S5tf7AodQ8bbfjmLuiYh3sA/OuE7WkqeSY cJ9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=pEfFZ5uWX6iBRbjnHbEDDBB0vDW86TmIDzEPatgkzPY=; fh=BtOZ7jpnZqEmNX142PkyEc09CqV7RPaibC+M3g3LvUM=; b=ZEsBKyeNX6Sq+2wtD4YkD/cJCH3r8cq18DzbrcCS0L2px//zG/HVf7jx5aQTskTID8 TJM8Q3IwkbuKVdNlyKZTSIEWNyShd4QeKy8Z0myAj9OcdEQX4qXyXIUG8aKNo/t6djUG uIG83PFwFyQgCHuXzsJobVqAeqNI5PZmYpmrleM8PLfms2hgbXV/Qg4IX2yzaoAYX/nq n9ptL6eONVsLtfzGmJJbZUy4ZZOe9zBNmDpdgoSCkGhdFlqJhDFR0VSbXtLViwD93IIu xwB7eVl4oMycTQA6u6wPh46WL5mU0Qpb2KEMRIdO1S+lKpEpxLzfjFTsORaWCquv3Doj sm6w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=jf8z4qKk; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-183089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183089-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6574625ea45si2059106a12.544.2024.05.19.04.19.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 04:19:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=jf8z4qKk; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-183089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183089-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9B35AB20C8A for ; Sun, 19 May 2024 11:19:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 46E0144C77; Sun, 19 May 2024 11:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="jf8z4qKk" Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2116D8F4A; Sun, 19 May 2024 11:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716117554; cv=none; b=YQZ/N9uA2nC3vLPUbQIjKzN9u+ELLaU9nTh58yMmj4Ul5QXdnBU4xWgAshVcf5x/77oX0/2qAUl40eK1vzafDRALkGyyzgXiA2xiMr1wd/VatMuYsyJ+Lj4Jdlq8deeFLS6L+ecWdCri4RThsgEWbVANYhn7/a2TZR5BjXRBHVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716117554; c=relaxed/simple; bh=o+j9jim2SFTtDeZRdbP+U9RKRjTg/+TlxstRhKWE3qc=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=RcBIEd0nlF8u6QJrFg24ytLxHON2m1Diwck8qmMC8lN6uGvkQDMJ0vOserDisp4SsTdXuI018D9GO6uLlMG9XLYvZe0ZZKFOMRkuGHTaEiLXpo4ZBS1yENiqideDcV40zSdYupAFFu/9cMCGrSs9nfLztRqYUAJWs5DUSEIrlqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=jf8z4qKk; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716117528; x=1716722328; i=markus.elfring@web.de; bh=pEfFZ5uWX6iBRbjnHbEDDBB0vDW86TmIDzEPatgkzPY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=jf8z4qKktxGMtw2M8TM27RLbM2wxzTwYKljdcCo8pBRMcVsQiVZocuUSDObfVKZ8 +JrDmzADJh0tLDAlnw4oVdFbJcZb5tmo32rl3z04fZUrLNLs9L89wYaLpVDGWoaLg LEJejOFHHrpcp0HnWvTyqzbzyAVGJocMgQ1rLRHn+nviUhsP1ImOPiscldHx59UhN fsz7hPgtOK32kEQ5DnnB7HBRGedkQiL5GxxFWLHR/vKjzM7JG7U0RiRLoccC0bEeo zaMSJmb5/3mh9MQWOnt6GiQILnVZ6UOi3ZURnfuhT7O1l9DestRVr9ftzidSwEVIy SeE3Ra7HE1rrcUn5EA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.82.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N6JxT-1salOr2p0z-016izN; Sun, 19 May 2024 13:18:48 +0200 Message-ID: Date: Sun, 19 May 2024 13:18:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: =?UTF-8?Q?Alvin_=C5=A0ipraga?= , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: LKML , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Emil Svendsen , Andi Shyti , Bartosz Golaszewski , Conor Dooley , Greg Kroah-Hartman , Jaroslav Kysela , Krzysztof Kozlowski , Liam Girdwood , Linus Walleij , Mark Brown , Michael Turquette , "Rafael J. Wysocki" , Rob Herring , Saravana Kannan , Stephen Boyd , Takashi Iwai References: <20240517-a2b-v1-1-b8647554c67b@bang-olufsen.dk> Subject: Re: [PATCH 01/13] a2b: add A2B driver core Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240517-a2b-v1-1-b8647554c67b@bang-olufsen.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:yvTbyO1e5gC/VYcAH6EfxvkQgIRu0/rRhJ/zMPP4ObyXuyBUpBv dY/VPRz/E5LRfDODkJldDZJc/mFZYMnQHvwRMZsd1qaL5zsOcRGPB/7Z4WoW8Q7kbKH/lrM 3wQ5WDZqp0wyznJRVbz+S3qLi1KYiVRpXALLtB1+F2vwmKcxXs/EwhVaVnfZLftxpd5iY7f RF5e3LhwMg4nXWoDvrZWw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gwN3dc436M0=;tpA+1NgyAhJH44JfOMHYIcQKkMs yvG1VOsgPdl8OM6I/LH7KMzMsn+RMzCqJQrWgc4kwp290KfCsPk8MGTuZI4bGQDJ1X+eUWDik MFj06ScZLuXHR52QE6Uq39O5FTfxQCc0jRbJXNjoDceXoATj4mgrxhJPsuxI3JnRwRnKbz5XL vBspQGFERoDJCVQpheBcUCejnShFm/WQVTqA34eLDDrrr72M190AzAGRqzgP7RntJUm1JXx4W 5cAJmjfqgMEPZO8mN0IhVljHM4V8yQs0umVqhHmkA5OJ686zu3J/86W4UEM5RUGBVY0fiS4RF hN8at8TDqslzV38oRU/FiteLZswtdqJrTju6VJ43+grBxAklJxzMRIH8z71M15csrVWN46Q5x b5UKIwfFcLF3fX5gygRtp/4VsRshzZJUfrgf6Y0fX2iZ1xPmGV+vfUsJss4bj/3S2+1wAWIYR e6ZIHW7hzMlhmIIpRoRGfBT4TMzoC9rsXbzLz8T8JX/y9nRXTX+leL9Bi6ajI8/5mTmHuc8J3 YmEgwexnh25oZKo2lDWN4vVvCROcvdgGHDzylu5FmVvQOMHTAk+sTLEkaP0dtQbgmuABPLLb6 wtJ8j5aIJkG5XnbFO4Y99vPGoPVHj6uzMeGIRpUnEkjt+dhOjIPNQjXFnU1EAoWRnqlAP1j0L XDvcQeKL+OOHkanR/XQi7UUUl2fPuyHXLKz8wUeWWI3hTNtUyw/nV6m9JSeqHa+9rxNjyRSdw J9JvJfZlhWbQxVgiXtGptB5xlP9Q7/UpZ5R7VEccQLg6AnPLwTXHo9SGhVyFu2RtRhgu8QFmE 0Yasz/CAB2jLcLkwMhbDkYHi50VAijJuDMihf7PKlFFsQ= =E2=80=A6 > +++ b/drivers/a2b/a2b.c > @@ -0,0 +1,1252 @@ =E2=80=A6 > +static int a2b_node_uevent(const struct device *dev, > + struct kobj_uevent_env *env) > +{ =E2=80=A6 > + if (add_uevent_var(env, "A2B_NODE_VENDOR=3D%02x", node->vendor)) > + return -ENOMEM; =E2=80=A6 > + if (add_uevent_var(env, "A2B_NODE_VERSION=3D%02x", node->version)) > + return -ENOMEM; =E2=80=A6 I suggest to merge three if statements into one in a branch of this function implementation. Regards, Markus