Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1905898lqo; Sun, 19 May 2024 04:31:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVYZW0Yfk0nfB1DGvOEwAq1Kx3ZMONILPWnA5wuhAJoiJOc9U+x9hXr03sTCp5ZelJSMVgF8I8Syyu9zYrhPPe9b9oCxWtxOeyeBo94Xw== X-Google-Smtp-Source: AGHT+IG1Xwh8k4Fv4D6H8tgOKvTAnBORdmq7Abo5J7dsb4drD28Kus44Sbd/GTEPG+EnmSBi6Yx0 X-Received: by 2002:a17:906:7f99:b0:a55:b272:ea02 with SMTP id a640c23a62f3a-a5a2d67b044mr1763490466b.75.1716118307984; Sun, 19 May 2024 04:31:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716118307; cv=pass; d=google.com; s=arc-20160816; b=bZvbYwfuoGOx0XSNfXc+YU7Z5+6VHMEUBqTtkj5ldMV0tUd9KjuEoMsRaHCjg7unx3 wOFzbk6x99Xlva3n5it5WDZuQEiwFSNgnyNCLRxhxHShSLafDiKCtzQfaiBMeatVOj+5 QRKtoULV388CcnntE0aeIhAEKj1eCE88cxOaJJC6NQbjkpoQuCDnIDPU9lTeo6lL9Pjg pyyk853HOpa6j7OeRo5SSx+SdaRuBEx8LTVAQY/xUj4bJR6VTzfKP1pApndvOCFHoTpf h6bgsm4D1cN9QKlhFW96FOK5NPX1rtXX7UGyngnlT5RhYoiK//SHyQnTlT9+ifXpk1Wq X7BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=q5K5Z31ykrIcu2QsUSB/qx6afSiiIrRvFMc4qotL5jc=; fh=0v+AJPDb74zeG1f/XKOGRpUdRCuhtuvd7xddR+O3Xkc=; b=RZvA6plWNlq6jpFOqGcYsu4nVD+69VEQW2XqP8UIIxzsPooBYRmvujLmDNeo0lJ2f7 4t2/RTUzUqqCa1uqHgzSADRJgol0RKcLz2np8PnAHC9UdNKPjRkzK8qrPOROJoa5vReX cq9dXKzFAWtC2d9+fW8i/3H18J3Mk1iCMub1TocM5o703DbXvZ0p33R6uPX0yM3QrqsU VPWU9KsrAzb7bGQcdM6DAMdfzMrGluMfwwTbx0EqfHf6CBQ2klvEx7T4/ErOVyfshDOP 7VVhNz8dMEZlcshnUNmg3moo2VL6y0ztwK9uogq3z3AYxWxojwvAsr+ro6YJHdxEJQQa Wfyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kmzqEEpi; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-183091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17b21e55si1269838566b.482.2024.05.19.04.31.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 04:31:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=kmzqEEpi; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-183091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B0A0A1F217B0 for ; Sun, 19 May 2024 11:31:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B64CD4436E; Sun, 19 May 2024 11:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kmzqEEpi"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="UJAczcpg" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A258F70; Sun, 19 May 2024 11:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716118299; cv=none; b=WAn4cZMJjFshYWP+VZxUpgO9o2l+WTKkzoceyJX90Ih5+BzxcapUz4noDVkFREVSlKxqyMm1fh5GrBfH5JmorXJ9A7mYeAlAUddDR7pojCEyfw49sceSf5f6n9GEW3acU/jR4iNcgv8rYz4E9DRymEHZkdaP6qWb6byttI0Aj+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716118299; c=relaxed/simple; bh=ReQMMxzun4YFGhofp27QdLTQlpx82RLAaLzrO32kGqg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=I6HxrHE/qg9xK13eYrpPv0LqB2iU602dlHx1vLl+85Znc1lc4PoAwh/8lm8QWtRPdAIi2g8zI9UUB9bJKgtGnQMOFGEl/Q+DWte9F48hD5q/eP36PNEwVLYGrpxO+Oo+7tFy8bhjwLoHVr42nAJ2Gez/iYBYR6GOCadeXAi47LM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kmzqEEpi; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=UJAczcpg; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1716118291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q5K5Z31ykrIcu2QsUSB/qx6afSiiIrRvFMc4qotL5jc=; b=kmzqEEpigp1LsbxDWlgB7C1vkKQfEg62EQYA9mNwmCkpNOeq6IiIKSpNkFdHa1pGB21YZC u7mJsk9aOYJh59ySHK06/FDzw9T2nz1rJ19S4GbShg5d5KMBRGC/FYfcfVGIlEEn0xmj+n qLas0q3+0ySq4OBaBKH1Yb1EIob1yaTagPe+cfd88Qa+HHwTrfl0/XKyrl4PLZZ9y8bnA7 lbQWCBB1ezDWU+Ox+ndy7kuc0S8/t4ijYghifD96nO3rcW9ehR6Q8IqTspcPAeo2ebcKjl Rt2oj5ApzHkHkAGofgmTc60eeSCpUt7WuKCtZCojzyZEvc2yy78aBuWSYT11Ww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1716118291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q5K5Z31ykrIcu2QsUSB/qx6afSiiIrRvFMc4qotL5jc=; b=UJAczcpgyYTRmoY1piF//aUNeA07bL4M/4KWLEURlRowFHwu7j+VARN1iNS3c/gUvSP5A5 6xOCkCVLrzJ4TGCQ== To: Justin Stitt Cc: John Stultz , Stephen Boyd , Nathan Chancellor , Bill Wendling , Linux Kernel Mailing List , clang-built-linux , linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] ntp: safeguard against time_constant overflow case In-Reply-To: References: <20240517-b4-sio-ntp-c-v2-1-f3a80096f36f@google.com> <87pltjj1bs.ffs@tglx> Date: Sun, 19 May 2024 13:31:30 +0200 Message-ID: <87le46hwbx.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, May 17 2024 at 22:18, Justin Stitt wrote: > On Fri, May 17, 2024, 19:33 Thomas Gleixner wrote: > I accidentally sent a Frankstein-esque creation of two patches I was > working on. Not my brightest moment. It got past my testing because (as you > pointed out) I only ran the reproducer against my _fix_... Shit happens. > Let me really parse everything you've said and v3 will surely knock your > socks off. You'll have to wait till Monday though :) Take your time. There is no rush. Thanks, tglx