Received-SPF: pass (google.com: domain of linux-kernel+bounces-183108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f9470c3b-5f69-41fa-b0f4-ade18053473a@web.de>
Date: Sun, 19 May 2024 15:18:52 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Siddharth Vadapalli <s-vadapalli@ti.com>, netdev@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
 MD Danish Anwar <danishanwar@ti.com>, Paolo Abeni <pabeni@redhat.com>,
 Roger Quadros <rogerq@kernel.org>, Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org,
 Misael Lopez Cruz <misael.lopez@ti.com>, Sriramakrishnan <srk@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>
References: <20240518124234.2671651-13-s-vadapalli@ti.com>
Subject: Re: [RFC PATCH net-next 12/28] net: ethernet: ti: cpsw-proxy-client:
 add NAPI RX polling function
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240518124234.2671651-13-s-vadapalli@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:OP4700k9zPo=;VCkvx6LeC7jih8NnSdv6M5q1hla
 /MVArGVPhR9LytY9FqUrZSLp0u0Rb3gvn0WcDR2AVoipaLTpBYylU27pqltJ2YSUtJgVKVjwb
 wZ8xFRsdaUVb5zqbTxA06n2SRw2+2svefzJ2/WJ1x7/jcSB2yJOcTXdGmkD4w11YoYj8PPLLD
 qaDhRPukJebcVcBUUzo2hFfwT97gUR/dX/2j+TLRGFs+ZqDJ+Vfr2BfR+NF4L8fyCBGHTRhF7
 ZyPBjZVy45SwgI62ZopPawEoXVG0ACuIcqHRbCTFUwtwkERV5oiueNnSHPPx5IQlL5XGQ6oxM
 RB8gLam/tTY3lQwZKDxJ0ugGsWM4FMkOWIs+VEvGxgQKZuw0L6nnqDIp2qH4OAsxqVZJh+iYG
 aRfTnsvYe8DEdsXfb+SjnP1AvtZm3oQXOYf6q6lYiphNHhwCY8U7yymEH/wv3N0q8JhV4+0v1
 1bzp+yKtezgRK2W88FvZ40/GmoYK6gbLNMUVgHr/fVzy4MPoiUr7DLxUznGtRVzW4UouiMYzN
 ypAM0XxrURiKWoRQ8vGOGnHnPXXYuve8YZB0kAzTXysjjAE7lqJ5dOsyYWBgYxiH2aJfaA3gW
 l8VKql/ilmLgNd8JPyomGnKeOZo5Via61cfLlzAv6N/A1/mrk8w8A0ULOxcejsxcA5WKU0/2k
 D2VBiIdNrnawpco5oRA83MjIkkqNd20k+X/lnoHuRikfnYeO97vriQWRdnMZofpd4FkNqwkP4
 N+MB+BnUMo/AX/+GRJEliUokzpadtlIFAk0gfwnLZhobz4S5xN/VcE5aDNxpdEGCmNZnbDEbW
 GHHNaXm8s0+EyBzAAbH1kKM0Fd3P1bOvro39qofQ7rnuM=

=E2=80=A6
> +++ b/drivers/net/ethernet/ti/cpsw-proxy-client.c
=E2=80=A6
> @@ -988,6 +994,189 @@ static int vport_tx_poll(struct napi_struct *napi_=
tx, int budget)
=E2=80=A6
> +static int vport_rx_packets(struct virtual_port *vport, u32 rx_chan_idx=
)
> +{
=E2=80=A6
> +	if (unlikely(!netif_running(skb->dev))) {
> +		dev_kfree_skb_any(skb);
> +		return -ENODEV;
> +	}

I suggest to move such exception handling to the end of this function impl=
ementation
so that it can be better reused also by another if branch.
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+go=
to+chain+when+leaving+a+function+on+error+when+using+and+releasing+resourc=
es

How do you think about to increase the application of scope-based resource=
 management
also for such a software component?
https://elixir.bootlin.com/linux/v6.9.1/source/include/linux/cleanup.h

Regards,
Markus