Received-SPF: pass (google.com: domain of linux-kernel+bounces-183112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b6f1d062-5f09-4d57-aa24-e8515c5cebcf@oracle.com>
Date: Sun, 19 May 2024 19:06:55 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] iio: temperature: mlx90635: Fix ERR_PTR dereference in
 mlx90635_probe()
To: Jonathan Cameron <jic23@kernel.org>
Cc: Crt Mori <cmo@melexis.com>, Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20240513203427.3208696-1-harshit.m.mogalapalli@oracle.com>
 <20240519132940.3714e57b@jic23-huawei>
Content-Language: en-US
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <20240519132940.3714e57b@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eGJ4N015WVVJeWtrNTBPUkFkY09jclBOWDRhS1hRMlhlOWFRUnIrT1VUNkJj?=
 =?utf-8?B?dmFZakQyNEhoYkdmclkzcXNWNnhVN1FKMmVPUERuUTdxbXBPTVJTaC9sblFa?=
 =?utf-8?B?eWN4bXBsRTZxcFcwOG1lOE11emgwYUdFMVNZV2NOZlhMVy9xbWdQTW9uUFo3?=
 =?utf-8?B?bGZNdXNuTUpkdW9NRkc1V2w0c0lveFNpQlBXand0a1EzVjFZVzczeWJaTXNW?=
 =?utf-8?B?NUZCc1Q0RUkxMUxCZVA5Z1YxdmlHVXhLMmNUQmswb3dFZUduL3gwTXlvRzBM?=
 =?utf-8?B?a1VxVkpMUnFtQ3JGRDNHTjcyTG9NZmQ0bDFiRkhGYnJOTHd2alhyUmFoZzNy?=
 =?utf-8?B?ZkYvNkRMckFXazJNaW5zMGU4YUhGbXlYU0NyVGJ4YXZHcXBiMzBGak8rRVh6?=
 =?utf-8?B?eEhhSDNoaWRJQ3g4WDBHc280YVkwclFNVzBtOFlZMzFwU3VESFlpMkxzTWtk?=
 =?utf-8?B?ZWxBaTE4OWhSLy9uS1BXL0N5ekJtQnpPMXdDaDZCajlTeTl0UkJTODhJdkdO?=
 =?utf-8?B?OW04b2xwQzh6aFB3M0R0Ujd2eVdSSjFMR2R2QjYyWXRsTUlYbHBMb1BKNERL?=
 =?utf-8?B?OGpMUWpsNU90UmFlNVV2N0YxNkxHL0tjdlJzSFJldHhvOEJ0a25aMStvRDUv?=
 =?utf-8?B?bE14Q25jVDU2cTgyZDRxWUY3c2U1SllUZis5U3lkOGZLdTRSV1Y3SzRSbUZ0?=
 =?utf-8?B?bEhWZS9meXhHYjdSRmVwUCtXeWlZMzFNeGJrZWlrVTR2NUhGZ1pJa0E4NFRO?=
 =?utf-8?B?VDFmb2U4UFFNdkNUZ1hjeGFZZDFjZHZsbVI3OVJoOG4xM3UvRVRzZ3p4TWZh?=
 =?utf-8?B?L1I1d2ZEb1JhSzQ4bFRQUVFTRGlGdytpUmxmTFNiZkdGN2M2L3ZrQmNYVjZE?=
 =?utf-8?B?aTA5bEZQU2RqcXZ6c3NnbGUrSmNXSWphZXhVMnZMK0o5TUJyRW10cysvSFBN?=
 =?utf-8?B?bFpQSHUvS1QraG5TVW5WU2JJanRlSnhEMWgrSXMybHlCVHNyM2hhQy9xK0xw?=
 =?utf-8?B?NE5nQXh1UHpNRWcvTU9yZit6UkN4SGhQNDR6MGZPU294OEJhRFJkZTRHOW1Z?=
 =?utf-8?B?c0FwR2oyVzJFNDc4NmpObys2Q2pNWnZ5a1YwZC9rWjd6TnFvODdETmdLd0RB?=
 =?utf-8?B?bzJjbkx0SFp4dUJheWx6OEpRR2s5b3FnSnNLcWZFTHZLdTc3UzBIUXNIUEUz?=
 =?utf-8?B?UVB5a3VhaW5jdlpzV3hrNGZQL1NKQWNCajhCUE9WWFgrMGMrbW1zSE42T3U4?=
 =?utf-8?B?bWEvOURSUmQ3SlFFVlpaYkg0MWNxUXlZZ0syVUorUWNiRVJ0dVZ2WHVpT0No?=
 =?utf-8?B?VUFVZDVUTUhrUkJDVHZiQ2FuZElDOHhTNHZHY3BDMi9wRGpIdWFoYkJqM3VW?=
 =?utf-8?B?a1E1UlJvdW5pNit3dzRmSGFpL0U5UnQ0NVh3cmxyaU40ZSt5YWIzZEpCQ2Z1?=
 =?utf-8?B?cFdZWk40U2M3YWZ3Q1d6R0p0UGo5bUhCdU1ZQk9Xekg0OGEyZmMybWUxdnIr?=
 =?utf-8?B?OXdtY1p4Z0JlbEV6OWFZYy9NWXhhd0tpdlhmYk9yLzJRN1l3KytabUxYNGV1?=
 =?utf-8?B?VGNIRS81QkZmamdXNFJPQ0lLdlovNENhNTIvbXg1UFN1RlVFYk1UU3FEeWxL?=
 =?utf-8?B?b2JVWDJ1QUNYS2VjVHY3MUpIRzVtazBjQTZRcDFKd2JKMmZOK21NLzJkdkhm?=
 =?utf-8?B?ZjRuZFU5TUJJYURGMlJBaWpBWFFQNkM1YzVZUFRnbVJwYm1sS1lzRC8yVURV?=
 =?utf-8?B?SGsxQ0FMR0t6ZG1BYUFzMnYzbmJjWGpDa1RHN01tYlNmRy9KSHZUWjROR3o1?=
 =?utf-8?B?NG5EeklRa3VOaFpEcEFWSTliUXFHV3JzazlPTDFmazhhNDlRQ3I2UU40dTRm?=
 =?utf-8?B?ZHROZmdPaTNiTmxmZjltM1dOUDFZZXpaQkY0cWtYdVNWZ0lzUmdVay9QU3Rv?=
 =?utf-8?B?VnBJeXViaDdjNCtlTmlLM2R1aTk2Z0NwRDBTNGJYRXUvajM1aTMxOTB1QWxE?=
 =?utf-8?B?SDJwTFJCcUJMNlY2U1F3YzFBUUY1c0FFeDNXdlF6bjIzTDFnMzhxdDVrTE5m?=
 =?utf-8?B?bTVEdUpDSXAxVEdFbFUvdUg5OExUdjhhR3M1Nmw1bDk0ckdSdGRxVXBzYXBi?=
 =?utf-8?B?MTQvcUVoRzVKNXJDT3o3SU9HbzFGYnFkakRaWjFQWWhrc0Q3Um9pWnJXNXR4?=
 =?utf-8?Q?YRuZcbBFpWEV4TTSq5wKcSk=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	tQl7/CGXwQpS64N7G31XgKJlol8d1V3V7f6/lqTV8DujxBoUsbOnERxkXcrZwT5nLn8vXMFjfNBcuH4cTYO7Rg2ojHDBke1r04ARjnu9rH1LMPVBcYUmi17RPr+JukFZ5szisBdEjiXoeqxkf2b10dyhR+NwimfsgUS5YHiqOAH2ZIWfoOjnKOT1P4p0BkkNdF9kpnSYK5aLZ3xDNEnI6E2yVawLu6YjO4EuR/4McyQ3XzC6ree8ZxTrj6VcWm/ohDlNUUFTu4mK6ujJ28WCZwR3fDn8hSKWGP8WPvQff4ToboFDiEAYyqFZlrpygaPTeANCKlCTpycBDagET9X1hK1wK6aLlaLQZTDyzSvIAblV1zwDCy1bdJwSOi6NeMzhw7ikUZm/9JTUqsPv/78NF6RoT4wjKQVLwPXM8ctTLAhUChsptyvZJcsVAMZnotmihxUIXqLnRazE4umb+pwEBC4HNJozVaGAc4xTs6ZKDCJuOtt4z8VAkoSegmnuu7HK/oEGG7OQNW7wxCwIwlvz5Pl47Y/nRbnuHAGZlFA9giSxP5NRmHpFNrC5s2Xask+M+kdvQuSGV0ITFr/1e4eeDt8PeWAkECNJetOyz+hNTJc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa7c1f1-adcc-49a7-42c6-08dc7808c726
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2024 13:37:07.9489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mk6lszAtMtCGE7FYqzsrrNvnW0bI6l0y8d1Hp3F8UGETIExWmvE7smtsMcspRsH6dOSZa1qHDdTz8yqMqCLfNYocsKhwwSFHEHiCby4PSdov5AeibM2XiSLhEbxkaxGJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4850
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-19_04,2024-05-17_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405190118
X-Proofpoint-ORIG-GUID: b7VUg8RkzE71DB9slilB-6S1zKDMQHMA
X-Proofpoint-GUID: b7VUg8RkzE71DB9slilB-6S1zKDMQHMA

Hi Jonathan,

On 19/05/24 17:59, Jonathan Cameron wrote:
> On Mon, 13 May 2024 13:34:27 -0700
> Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
> 
>> When devm_regmap_init_i2c() fails, regmap_ee could be error pointer,
>> instead of checking for IS_ERR(regmap_ee), regmap is checked which looks
>> like a copy paste error.
>>
>> Fixes: a1d1ba5e1c28 ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> Please make sure to pick up tags given on earlier versions.  You dropped
> Crt's Reviewed-by without giving a reasons. I've put it back.
> 

Sorry, I thought we should not add tags as v1-->v2: is for addressing 
the reviewers(Crt's) comments.

I will keep this in mind.

Thanks,
Harshit

> Applied to the fixes-togreg branch of iio.git and marked for stable.
> I'll be rebasing that on rc1 once available. Until then it won't be visible.
> 
> Thanks,
> 
> Jonathan
> 
>> ---
>> This is found using smatch, only compile tested.
>> v1->v2: Address Crt's comments.
>> ---
>>   drivers/iio/temperature/mlx90635.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/temperature/mlx90635.c b/drivers/iio/temperature/mlx90635.c
>> index 1f5c962c1818..f7f88498ba0e 100644
>> --- a/drivers/iio/temperature/mlx90635.c
>> +++ b/drivers/iio/temperature/mlx90635.c
>> @@ -947,9 +947,9 @@ static int mlx90635_probe(struct i2c_client *client)
>>   				     "failed to allocate regmap\n");
>>   
>>   	regmap_ee = devm_regmap_init_i2c(client, &mlx90635_regmap_ee);
>> -	if (IS_ERR(regmap))
>> -		return dev_err_probe(&client->dev, PTR_ERR(regmap),
>> -				     "failed to allocate regmap\n");
>> +	if (IS_ERR(regmap_ee))
>> +		return dev_err_probe(&client->dev, PTR_ERR(regmap_ee),
>> +				     "failed to allocate EEPROM regmap\n");
>>   
>>   	mlx90635 = iio_priv(indio_dev);
>>   	i2c_set_clientdata(client, indio_dev);
>