Received-SPF: pass (google.com: domain of linux-kernel+bounces-183121-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <2d7edd9b-f11c-4b8d-a63c-cecb104aa91c@web.de>
Date: Sun, 19 May 2024 16:12:27 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Siddharth Vadapalli <s-vadapalli@ti.com>, netdev@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
 MD Danish Anwar <danishanwar@ti.com>, Paolo Abeni <pabeni@redhat.com>,
 Roger Quadros <rogerq@kernel.org>, Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org,
 Misael Lopez Cruz <misael.lopez@ti.com>, Sriramakrishnan <srk@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>
References: <20240518124234.2671651-24-s-vadapalli@ti.com>
Subject: Re: [RFC PATCH net-next 23/28] net: ethernet: ti: cpsw-proxy-client:
 add sw tx/rx irq coalescing
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240518124234.2671651-24-s-vadapalli@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:tJ/qgRkzrIo=;jjTDvIgRZp/mIogqIqJa3Eu+L6x
 G+MT1/nmT0G7Vwx+01dEjtjSL67XhgzGod6vrXX9+C3+sKbuQIa7y/7YJQW8Cay/rO1g6/cQ6
 vUjj7Izgds1H3rWRVSDX7y5wCpaZibYntk67v2TlQSVrbs94b+qkUP3o96zUVQKfU0UkVCMR/
 wmBmM/cKJksBFvr3YWNi5G8yEnGdW5Pg5NRLxGJaimrWP37duxIvbSPi967MuCNovY60Z8Tdt
 /xjRVFjUMIT+nCcfh707SWYga+u3le988OlgY4bQ9vLrqPBSYl2XpS169nUWl005FGDv+NQC2
 FE01fwbbXoLt2Vgyad+R/tN6oGMmnsJez8zW3UEWD8x90R8c7DXW/QwKfb6yr7UiB1b3yleGx
 tM6xtgQIxoxnJuCBETJnMIIDSwUftjyD8JupQiVljDfLDwvYxwza946qoWYInpEqEh7SqZ6i/
 WZWJZSxYWKnSPmGqx3n0r/zpRG3JZz2VtRmOLel+iT/sJa7qgTkQV2L2dF9VvIxHXdOjm1NgF
 tfu/JI5CeGYTDW+64fCfnosdsREfVHTDiWFeepr10CqWdXPpqyeH3USNLamUvAjvFSErtv57R
 5KhLWQezfTaPiHgqxf4zmHKhEwj3iaC9CRAPFTftoYpFymopCxEAaP2JA4nV9nebjgidwBth2
 cCJQiebpHJ5h7ZSBiATWTZLXzPCJXSCNqjtjYOB8FOGeoYxAIBUUGE0frFUeN1QMAxdTEKc/7
 po4uxPTKkHm+NnRvhQXzrQ9QomYZiDxN6YUshE7nHwuCi/jTVBWPWMYL8Axr4tRsbkg2Y9DXV
 yXqqJT7l3jGLdSqxUM23SXvHGGVRDa7wpAc7s7VymyvMI=

=E2=80=A6
> +++ b/drivers/net/ethernet/ti/cpsw-proxy-client.c
=E2=80=A6
> @@ -996,8 +1001,15 @@ static int vport_tx_poll(struct napi_struct *napi_=
tx, int budget)
=E2=80=A6
> +		if (unlikely(tx_chn->tx_pace_timeout && !tdown)) {
> +			hrtimer_start(&tx_chn->tx_hrtimer,
> +				      ns_to_ktime(tx_chn->tx_pace_timeout),
> +				      HRTIMER_MODE_REL_PINNED);
> +		} else {
> +			enable_irq(tx_chn->irq);
> +		}
=E2=80=A6
> @@ -1179,12 +1191,38 @@ static int vport_rx_poll(struct napi_struct *nap=
i_rx, int budget)
=E2=80=A6
> +			if (unlikely(rx_chn->rx_pace_timeout)) {
> +				hrtimer_start(&rx_chn->rx_hrtimer,
> +					      ns_to_ktime(rx_chn->rx_pace_timeout),
> +					      HRTIMER_MODE_REL_PINNED);
> +			} else {
> +				enable_irq(rx_chn->irq);
> +			}
=E2=80=A6

Would you like to omit curly brackets at a few source code places?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do=
cumentation/process/coding-style.rst?h=3Dv6.9#n197

Regards,
Markus