Received-SPF: pass (google.com: domain of linux-kernel+bounces-183126-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 19 May 2024 15:22:35 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: lars@metafoo.de, andriy.shevchenko@linux.intel.com,
 ang.iglesiasg@gmail.com, mazziesaccount@gmail.com, ak@it-klinger.de,
 petre.rodan@subdimension.ro, phil@raspberrypi.com, 579lpy@gmail.com,
 linus.walleij@linaro.org, semen.protsenko@linaro.org,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron
 <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v7 1/5] iio: pressure: bmp280: Refactorize reading
 functions
Message-ID: <20240519152130.32ec84b9@jic23-huawei>
In-Reply-To: <20240512230524.53990-2-vassilisamir@gmail.com>
References: <20240512230524.53990-1-vassilisamir@gmail.com>
	<20240512230524.53990-2-vassilisamir@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 13 May 2024 01:05:20 +0200
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:

> For BMP18x, BMP28x, BME280, BMP38x the reading of the pressure
> value requires an update of the t_fine variable which happens
> through reading the temperature value.
>=20
> So all the bmpxxx_read_press() functions of the above sensors
> are internally calling the equivalent bmpxxx_read_temp() function
> in order to update the t_fine value. By just looking at the code
> this functionality is a bit hidden and is not easy to understand
> why those channels are not independent.
>=20
> This commit tries to clear these things a bit by splitting the
> bmpxxx_{read/compensate}_{temp/press/humid}() to the following:
>=20
> i. bmpxxx_read_{temp/press/humid}_adc(): read the raw value from
> the sensor.
>=20
> ii. bmpxx_calc_t_fine(): calculate the t_fine variable.
>=20
> iii. bmpxxx_get_t_fine(): get the t_fine variable.
>=20
> iv. bmpxxx_compensate_{temp/press/humid}(): compensate the adc
> values and return the calculated value.
>=20
> v. bmpxxx_read_{temp/press/humid}(): combine calls of the
> aforementioned functions to return the requested value.
>=20
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Applied with a fix...
drivers/iio/pressure/bmp280-core.c: In function =E2=80=98bmp180_read_press=
=E2=80=99:
drivers/iio/pressure/bmp280-core.c:2091:9: error: =E2=80=98ret=E2=80=99 und=
eclared (first use in this function); did you mean =E2=80=98net=E2=80=99?
 2091 |         ret =3D bmp180_get_t_fine(data, &t_fine);
      |         ^~~
      |         net

I guess something got lost in rebasing. Anyhow, fix obvious so not
problem.

Thanks,

Jonathan