Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2004681lqo; Sun, 19 May 2024 08:38:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUHgVaGwNqdzBaKEC/H1S9A0lhZRg/RjfZg0BbWJmrreYIK2gUGBBQbK0n5JitCko4pxmkMKi5JLH1KIDH6y2k7f2dssnDuXQAJtz3JSA== X-Google-Smtp-Source: AGHT+IFOPVPyCRYXeqhzWKbMCEf5jWCdXgIBD98bs8cD6EWH7J7kZEgUQQm7nSbqmMzGmR76+/mQ X-Received: by 2002:a05:6402:1d21:b0:575:d74:3387 with SMTP id 4fb4d7f45d1cf-5750d7433eamr8805064a12.7.1716133091174; Sun, 19 May 2024 08:38:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716133091; cv=pass; d=google.com; s=arc-20160816; b=TdAEMGCZpDheN8b905PgfwkzdvN1rP+lg0wK2aXQRxZsg5rdvXrnBX+Ep4eE2n2yf3 5vWWFa+0+T6iGKOVAth2q/kVmjNJacmf/9OlN0eV2+dyLmpA4oe8MEkGNTnXRpfJ+zOb NlH87/noDE03h/WCeJlMUHvuNt/iQlq2gFNgfPvp8EDKsVZ87NbXtVYvcwmTrDITkQLH cDZGbMAFPe6mkYNywPw1yc2N3yCItlYZEw6EQNw+3tYFEJaHI0E2qA9xhSdKpqTA/wUs TR/Ys1vXDrZUHbzWjwXNT7hTUNambH+SZOiaGjyCdLXcc3wzIHU1YwKzzKsv3YU/O1Mo y4rA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yPnxnFfwVRXtYrtep56kjTn1ZNOzZhEEVBAwe35GIWI=; fh=55ziMeHpFpQXYKUhkPNFJwPkw2NDg5CQviQ9xG+YWe0=; b=BJ2ZCe8w3dUvWNfC+Hhke0E4pTti6/N7PsWYaXgZ1fdgfBh9LGGZAmYT3axs023/kA HgAdJ1Mlyd021H9Sh0fxqUZuUZo2/WaNsjhMOsd3mzefOJFRiCiak2fixrkyQUzbCeYt BlstmubIvcgxyPCmLyW4L174FdIurFS+6ylozSoy5wyn7E9LpMWYbC/wyKSDiKQnnRVW YdkQxeQ5EY24lCtgxP1kht2BEOm5ux7C9ocWBpy6GLwGLJGkrkV5/kg6GFndG0371/KE bpSZY2gDL81Y0/iR+2D3Lrl4adV8bhsuDATdZC5BwNAEqfWpOYtd+GM2FhNbyLw2zlqa Kncw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p0lmc2Qq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-183143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5735c85a015si9875509a12.145.2024.05.19.08.38.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 08:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p0lmc2Qq; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-183143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D06701F21665 for ; Sun, 19 May 2024 15:38:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30F5D487AE; Sun, 19 May 2024 15:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="p0lmc2Qq" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790F314A81; Sun, 19 May 2024 15:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716133076; cv=none; b=anY+wlgU0V4lSMgEnoyhdNJzKhxwVwz2Zks407AEFcsGzI79NEj2TH2lbLi6vJezjo8dSOZtKtlSMKbhE/dtKr9r6FLgu+XyJtcsY0oFG4RP1/8MByfUU7CqFrP7eH34Fk+JuwF5EwMZ2cwjOM1kIdKjqg5NHYVL2S5+05Ezmhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716133076; c=relaxed/simple; bh=NXeERUwyQjx2KQdGfzB24z/wueRuWMxAyk0OIBGtnOs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PTJP4CJKF/E7sXNkPVBvoh0LJtdAyEGSEn0fNdzOmPSLEgwc+rShHFkTNMBST67WspqljNzwrLcmO8elQRAVLuA0+WW+K44KiviiipWT3f8WLJequilZJcxYP8UdBlh5B4tRx+79P7uBBteCrHoXqfYIQFp6tuv/Y8gU49APi6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=p0lmc2Qq; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yPnxnFfwVRXtYrtep56kjTn1ZNOzZhEEVBAwe35GIWI=; b=p0lmc2Qq/5//84h/ZOoyKw8i5d CTXWeKEwbvJK+gEqt69LaFX/W7o54IK4mZumoM5JcIX9KHTToXjux+pZM76MnA/TFfSqZ0vRheXBn AiMJ1a8bbjn35L3L4OIcNH4FnVe+kAQ7D+o0HgKjZvnktM9jwcCbmgbBKzepTNXhpAdU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s8ibT-00Ff0y-7U; Sun, 19 May 2024 17:37:39 +0200 Date: Sun, 19 May 2024 17:37:39 +0200 From: Andrew Lunn To: Matthew Wilcox Cc: Markus Elfring , Siddharth Vadapalli , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , MD Danish Anwar , Paolo Abeni , Roger Quadros , Vladimir Oltean , LKML , linux-doc@vger.kernel.org, Misael Lopez Cruz , Sriramakrishnan , Vignesh Raghavendra Subject: Re: [RFC PATCH net-next 12/28] net: ethernet: ti: cpsw-proxy-client: add NAPI RX polling function Message-ID: <433ffa6c-7ad3-4e28-a2ef-de699bf0e03a@lunn.ch> References: <20240518124234.2671651-13-s-vadapalli@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, May 19, 2024 at 03:00:42PM +0100, Matthew Wilcox wrote: > > FYI, Markus can be safely ignored. His opinions are well-established as > being irrelevant. I personally would suggest ignoring the nit-gritty details for the moment, and concentrate on the big picture architecture. I suspect the basic architecture is wrong, and the code is going to change in big ways. So it is pointless reviewing the code at the moment, other than to understand the architecture. Andrew