Received-SPF: pass (google.com: domain of linux-kernel+bounces-183144-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240518165315.3963142-1-sesse@google.com> <ZkjdQqN1dPsZDDRA@google.com>
In-Reply-To: <ZkjdQqN1dPsZDDRA@google.com>
From: Ian Rogers <irogers@google.com>
Date: Sun, 19 May 2024 08:50:37 -0700
Message-ID: <CAP-5=fXPFtS-aufdZE1_haEo6EpYYDw9JhG_4EjHi2AAzzf5RA@mail.gmail.com>
Subject: Re: [PATCH v2] Add a trie to map quickly from address range to
 compilation unit.
To: "Steinar H. Gunderson" <sesse@google.com>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 18, 2024 at 9:54=E2=80=AFAM Steinar H. Gunderson <sesse@google.=
com> wrote:
>
> On Sat, May 18, 2024 at 06:53:11PM +0200, Steinar H. Gunderson wrote:
> > When using perf to profile large binaries, _bfd_dwarf2_find_nearest_lin=
e()
> > becomes a hotspot, as perf wants to get line number information
> > (for inline-detection purposes) for each and every sample. In Chromium
> > in particular (the content_shell binary), this entails going through
> > 475k address ranges, which takes a long time when done repeatedly.
>
> I accidentally sent out an ancient patch anew; sorry, please ignore.

Presumably v1 should be reviewed?

Thanks,
Ian

> /* Steinar */