Received-SPF: pass (google.com: domain of linux-kernel+bounces-183166-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 19 May 2024 18:09:42 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>, dumitru.ceclan@analog.com,
 Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] iio: adc: ad7173: Add ad7173_device_info names
Message-ID: <20240519180942.6fa2bfe6@jic23-huawei>
In-Reply-To: <CAMknhBGGYztOsP74YEExG0OhAhMFtjh9Q=x3yAvSK=NQeL5e0w@mail.gmail.com>
References: <20240514-ad4111-v2-0-29be6a55efb5@analog.com>
	<20240514-ad4111-v2-6-29be6a55efb5@analog.com>
	<CAMknhBGrn+dSF=QJngUWaQ04tAwQf-9wmq0V2OgYS7sFKHroUA@mail.gmail.com>
	<167516cf-303b-48a5-ab84-173cea8e82f2@gmail.com>
	<CAMknhBGGYztOsP74YEExG0OhAhMFtjh9Q=x3yAvSK=NQeL5e0w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 16 May 2024 11:43:17 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On Thu, May 16, 2024 at 11:09=E2=80=AFAM Ceclan, Dumitru
> <mitrutzceclan@gmail.com> wrote:
> >
> > On 16/05/2024 02:32, David Lechner wrote: =20
> > > On Tue, May 14, 2024 at 2:23=E2=80=AFAM Dumitru Ceclan via B4 Relay
> > > <devnull+dumitru.ceclan.analog.com@kernel.org> wrote: =20
> > >>
> > >> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > >>
> > >> Add missing names from the device info struct for 3 models to ensure
> > >> consistency with the rest of the models.
> > >> =20
> > >
> > > This affects userspace, right? So probably needs a Fixes: to make sure
> > > this gets into the 6.10 release?
> > > =20
> > I don't think that it breaks userspace, just creates an additional file.
> >
> > This creates the file "name" in the iio:deviceX directory that reads the
> > string. I do not consider the Fixes: tag a necessity. I consider that it
> > resolves inconsistencies in the _device_info struct. =20
>=20
> Ah, OK. For some reason, I was thinking that it would default to the
> driver name if this was left out.

Hmm. I'd be tempted to take this a fix as some userspace code relies
on that name being present and it is unusual to not see it.

Jonathan