Received-SPF: pass (google.com: domain of linux-kernel+bounces-183182-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 19 May 2024 18:53:46 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: Alisa-Dariana Roman <alisadariana@gmail.com>,
 michael.hennerich@analog.com, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lars@metafoo.de,
 robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 lgirdwood@gmail.com, broonie@kernel.org, nuno.sa@analog.com,
 marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com,
 okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com,
 marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com
Subject: Re: [PATCH v8 3/6] iio: adc: ad7192: Add aincom supply
Message-ID: <20240519185346.01092b44@jic23-huawei>
In-Reply-To: <ZkNjYZew7Mko7iPX@smile.fi.intel.com>
References: <20240514120222.56488-1-alisa.roman@analog.com>
	<20240514120222.56488-4-alisa.roman@analog.com>
	<ZkNjYZew7Mko7iPX@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 14 May 2024 16:13:05 +0300
Andy Shevchenko <andy@kernel.org> wrote:

> On Tue, May 14, 2024 at 03:02:19PM +0300, Alisa-Dariana Roman wrote:
> > AINCOM should actually be a supply. AINx inputs are referenced to AINCOM
> > in pseudo-differential operation mode. AINCOM voltage represents the
> > offset of corresponding channels.  
> 
> ...
> 
> Possible cleanup with the help of
> 
> 	struct device *dev = &spi->dev;
This is a good thing to have as a follow up as it applies much more widely
than what is visible in this patch. In ideal world it would have been
a precursor to this series, but I don't want to delay this for a v9 just
to add that.

Hence I'm not going to tweak this whilst applying.

Patch applied as is.

Thanks,

Jonathan

> 
> 
> >  	struct ad7192_state *st;
> >  	struct iio_dev *indio_dev;
> > +	struct regulator *aincom;
> >  	int ret;  
> 
> ...
> 
> > +	aincom = devm_regulator_get_optional(&spi->dev, "aincom");  
> 
> 	aincom = devm_regulator_get_optional(dev, "aincom");
> 
> ...
> 
> > +			return dev_err_probe(&spi->dev, PTR_ERR(aincom),
> > +					     "Failed to get AINCOM supply\n");  
> 
> 			return dev_err_probe(dev, PTR_ERR(aincom),
> 					     "Failed to get AINCOM supply\n");
> 
> ...
> 
> > +			return dev_err_probe(&spi->dev, ret,
> > +					     "Failed to enable specified AINCOM supply\n");  
> 
> 			return dev_err_probe(dev, ret,
> 					     "Failed to enable specified AINCOM supply\n");
> 
> ...
> 
> > +		ret = devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, aincom);  
> 
> 		ret = devm_add_action_or_reset(dev, ad7192_reg_disable, aincom);
> 
> ...
> 
> > +			return dev_err_probe(&spi->dev, ret,
> > +					     "Device tree error, AINCOM voltage undefined\n");  
> 
> 			return dev_err_probe(dev, ret,
> 					     "Device tree error, AINCOM voltage undefined\n");
>