Received-SPF: pass (google.com: domain of linux-kernel+bounces-183202-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240407072330.229076-1-pvkumar5749404@gmail.com>
In-Reply-To: <20240407072330.229076-1-pvkumar5749404@gmail.com>
From: prabhav kumar <pvkumar5749404@gmail.com>
Date: Mon, 20 May 2024 00:10:52 +0530
Message-ID: <CAH8oh8UJUaq=Qg-jNYnEjL=auq9eDTcG24FZ3nCoZWcEDqwqEw@mail.gmail.com>
Subject: Re: [PATCH next] drivers: soc: qcom: Auto cleanup using __free(device_node)
To: andersson@kernel.org, konrad.dybcio@linaro.org, 
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: julia.lawall@inria.fr, javier.carrasco@wolfvision.net, 
	skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Are there any comments for me regarding the patch ?
Please let me know

On Sun, Apr 7, 2024 at 12:53=E2=80=AFPM Prabhav Kumar Vaish
<pvkumar5749404@gmail.com> wrote:
>
> Use automated cleanup to replace of_node_put() in qcom_smem_resolve_mem()=
.
>
> Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
> ---
> drivers/soc/qcom/smem.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index 7191fa0c087f..ad1cf8dcc6ec 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -1032,18 +1032,16 @@ static int qcom_smem_resolve_mem(struct qcom_smem=
 *smem, const char *name,
>                                  struct smem_region *region)
>  {
>         struct device *dev =3D smem->dev;
> -       struct device_node *np;
>         struct resource r;
>         int ret;
> +       struct device_node *np __free(device_node) =3D of_parse_phandle(d=
ev->of_node, name, 0);
>
> -       np =3D of_parse_phandle(dev->of_node, name, 0);
>         if (!np) {
>                 dev_err(dev, "No %s specified\n", name);
>                 return -EINVAL;
>         }
>
>         ret =3D of_address_to_resource(np, 0, &r);
> -       of_node_put(np);
>         if (ret)
>                 return ret;
>
> --
> 2.34.1
>