Received-SPF: pass (google.com: domain of linux-kernel+bounces-183261-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 19 May 2024 22:27:54 +0200
From: Francesco Dolcini <francesco@dolcini.it>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Parth Pancholi <parth105105@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Parth Pancholi <parth.pancholi@toradex.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: gpio-sbu-mux: Add an entry for
 TMUXHS4212
Message-ID: <20240519202754.GA3334@francesco-nb>
References: <20240517111140.859677-1-parth105105@gmail.com>
 <1675a33d-47af-4de9-a0e7-177cbe208e2b@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1675a33d-47af-4de9-a0e7-177cbe208e2b@kernel.org>

Hello Krzysztof,
thanks for the review.

On Sun, May 19, 2024 at 07:38:07PM +0200, Krzysztof Kozlowski wrote:
> On 17/05/2024 13:11, Parth Pancholi wrote:
> > From: Parth Pancholi <parth.pancholi@toradex.com>
> > 
> > Add a compatible entry for the TI TMUXHS4212 GPIO-based
> > bidirectional 2:1 mux/1:2 demux which can be used for
> > switching orientation of the SBU lines in USB Type-C
> > applications.
> > 
> > TMUXHS4212 datasheet: https://www.ti.com/lit/ds/symlink/tmuxhs4212.pdf
> > 
> > Signed-off-by: Parth Pancholi <parth.pancholi@toradex.com>
> > ---
> >  Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Where is an user of this?

The Linux driver (drivers/usb/typec/mux/gpio-sbu-mux.c) is using only
"gpio-sbu-mux", just in case you did not check yourself already.

As of now there is no DT file in-tree using this new compatible, FWIW
"onnn,fsusb43l10x" in the same file is not used by anybody. From some
old discussion here [1] (not exactly the same - I know, and coming not
from a DT kernel maintainer) I assumed that it was fine to send such
a change.

If it's not the case we'll send the patch later on, however some
DT files maintainers (e.g. arch/arm64/boot/dts/ti/) have a policy to
just accept DT file in which the binding changes are already merged
therefore I was trying to be a little bit proactive here.

Francesco

[1] https://lore.kernel.org/all/YgJjalw5O1aoBIX0@sirena.org.uk/