Received-SPF: pass (google.com: domain of linux-kernel+bounces-183267-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 19 May 2024 23:01:05 +0200
From: "Steinar H. Gunderson" <sesse@google.com>
To: Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] perf report: Support LLVM for addr2line()
Message-ID: <ZkpokaHRfQYCo3uG@google.com>
References: <20240518165335.3963530-1-sesse@google.com>
 <CAP-5=fW5YtzYz0R-9ZkgfdAFjkUDHu_Z1Sexs+2SmN0RwhrADw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fW5YtzYz0R-9ZkgfdAFjkUDHu_Z1Sexs+2SmN0RwhrADw@mail.gmail.com>

On Sun, May 19, 2024 at 11:23:26AM -0700, Ian Rogers wrote:
> I think we might want to display this in the feature list during the build:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/Makefile.feature?h=perf-tools-next#n123

Ack.

> s/HAVE_LIBLLVM_SUPPORT/HAVE_LLVM_SUPPORT/

Ack.

>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wunused-parameter"  /* Needed for LLVM 14. */
> nit: pehaps disabling this should be conditional:
> #if LLVM_VERSION_MAJOR == 14

It doesn't seem LLVM_VERSION_MAJOR is defined yet at this point, so I
don't think that would work. (I just checked; 15 has the same issue.)
In any case, I think it would be just more clutter for dubious gain.

>> +       if (file) {
>> +               if (line_info.FileName == "<invalid>") {
>> +                       /* Match the convention of libbfd. */
>> +                       *file = nullptr;
> Should "*file" be cleared if "!file" so the caller can reliably free it?

I don't understand. If “!file”, then file == NULL and surely accessing
*file would mean a crash?

/* Steinar */