Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2132766lqo; Sun, 19 May 2024 15:26:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU7tf1rfPl4eJMDT6VkBWqCOanHQV6if3XZ7k5zKmq9f0Wzc3TRYnsvjb54r8GVI2Nx+fgMVHGYJyxlbli+/tXDRFbOBfKTej1XEUZgNA== X-Google-Smtp-Source: AGHT+IFbbWsZ+7J1TqQwm9exQK4M3ty1fBuLTs8tewjmmyOeQU085VFm38ZbZkxKtWnRe6m60mS2 X-Received: by 2002:a25:8382:0:b0:de5:5067:6b4a with SMTP id 3f1490d57ef6-dee50a695a2mr24329971276.2.1716157577065; Sun, 19 May 2024 15:26:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716157577; cv=pass; d=google.com; s=arc-20160816; b=ALVlOEJ8OrheJ3/FmJ2af3pA539UL8YmMjMyId1Er6Cv0on9tqD+6V7nUdaIKqKWJA 72aNXs2ugGM39XVDEzJhikprUZIBU+OU+UFdTAyF3sfZhwh8g5cAyrSlmQ8/UwkPXpi0 3nZdiwStAixVb/AOs49qTfCogsaKXIx3b2iejuRxlLVUH+uuNORl75LMA1X/DgB4MdDr Ge4wJE4JFWhcB6cCQ9TOqpOBBl9Ng5MJKeLzdlKPuoLd6cbV+NegaSpRxcyCF2g8WN5W UW3hADjYe1nj7PTB00vlVAsiPJMOgzIVW06qh38jvc83Sl99yGKYp0jWQ3F92WNEyxEm CPQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z/u++8bFOJXJXg3s1d2RW1md24+mQv56EN7QzDG+NR8=; fh=GRyN3th5CpHzSLakLEayoJc6ZY2W9pKVlNJ7xO3Mr6w=; b=K6k7cwUDh0ObBTg7xiMx4VS3ZV9bhJPHEtcW4oLPO1TuxNanFAWkuyisEX2Fg86bJI AZGG7pBP+EZqq59wFHvwLWyHBPVE0/mRBUR7ih+FOgKRhqTCnlRwvXxHIAKfb1LD+6wc OQA2VcJrDdEqgABPNV1kFkWaSLtPjyuIgM2naCmTWMTkVvSkAUUTNbx8mma86t8+Mvwy tSBzvicAa9RaiDqovBvP39DAttjLXanUB1ut1062LOoKMJKay4YTeC81DmN7ygLjWwk2 5jmJq+9/Czd5EOkyN08Fjfxkqk2TZWV3adVZDVl1I/h9eHlG6yuCOg3fTEfOSmOMBVWh EECg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryCGgTsu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6a935b33d4csi33090316d6.377.2024.05.19.15.26.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:26:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ryCGgTsu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C819A1C2087D for ; Sun, 19 May 2024 22:26:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BBA87317C; Sun, 19 May 2024 22:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ryCGgTsu" Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F286EB62 for ; Sun, 19 May 2024 22:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157570; cv=none; b=oqr8Y3OMk630wofqENtKmM5GLNbudc3qudmngtBIKhqGzjf7SvZqaOD+ooiFN4TUv53duLEtp9qnQjq/21I3dXBtK1eMAc47FHjY9IDfv9Kp8H3p3LCaQT/6rhh3Yqevfi1Bhixc5X6uW8QBtMpmXigeNLmjMlzcIrgpDcn7feA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157570; c=relaxed/simple; bh=9tsQVsXkYAR/JXd8InHKzknLkf0H+ZfY0HgqfGFD+HQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HFuGp1kROoDYdUreIA6ftHnnwMHxJP1xxxnR1Iep9HxcoqS6NccFivb2YsGZ4pXUJc0bRZpRp0jI6YYijkiVN6B9NRD+07J1NBXwjd9t2kvngGG+z/eP4+8xfCoV8GkfWQGn3gLMBBy4yDxfQGYBN9aPuUXpt1+ForBChdN/HFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ryCGgTsu; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5210684cee6so2951704e87.0 for ; Sun, 19 May 2024 15:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716157567; x=1716762367; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z/u++8bFOJXJXg3s1d2RW1md24+mQv56EN7QzDG+NR8=; b=ryCGgTsuOUTdkBrl9p7C+iqK+AcY3GH2T+wtsmwjxR26BJrjxJlqHXLnksikmb1i8m Ucy3quwRcq0Br+w/+KTCINqki18KnmzJTJzMI0MQQuz1/Nq3GOyKhlBV/xGbZ+ciGFmX klz+4pqr2xxrsWIUTyhOwMeDsOPeV7mt6No4qSWeNgoJtIOyshvqGG3jdTpF1VH306P8 o2ThfRSQBD5Y0p6Uq1ROUsF3dWdp5C3cfZtURb4zTOZIDwKGDSRkDGKuUKgdPx6MfsQb w4n0xcEvSCQD7mlBfnUhzioV5tgbIPdHKq8pFm6qbSWLBTFKqcU1plJ0cWkqBXUuzM3E qbZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716157567; x=1716762367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z/u++8bFOJXJXg3s1d2RW1md24+mQv56EN7QzDG+NR8=; b=vYhk8OTgX00NQNKtGhSKDzMyNnnayxoyPwEd2aXvj6//225tv6g/UlbbA4e9fyAVX8 IclRUQgM7SujHr18kWZm5HpQizP8U7uWZ0DaFe4dj1Swe0evlDaOEvMQpgs48ziAzEAz h/1vlre9Vcp0LmkvYJg4mi4VLYVUFL0ZghXmDM2fRA04u2KGpKGLO/5TAZiiOHphJWpM lb8aav6f7sgVbJG/0ltinUQ2o7MAoHtPt1vgOYtKWPbTbDl3bLntDcjyVEkmlOxyB3Km sbuj/dNVVwCNP+3dW0zWreon/M+S2vm0eEPmxEwXWwPivNjKTNs2PEPEq06kyo4Rtr08 rEtA== X-Forwarded-Encrypted: i=1; AJvYcCUv+iKJbqSsn5cmiioZb1ynuiA/Pu5LyC5PP37KF3TN9XbKZtGTeDxlrcvyv/P5oyVB7xV/ASW/bsmLIksBLQTWgkuDK3Urtl4l5YMd X-Gm-Message-State: AOJu0Yxzrs7YfkVkyNXr5gViE+L7DC/VQoDksutKbaapZA874yAoQu+J 4wWa1H4qywLG7bSNaj769zrQsEJWXgCUNYIqQKQhiDpnMU0b1h8Zbcqu0zywqik= X-Received: by 2002:a19:914e:0:b0:51e:543c:a45d with SMTP id 2adb3069b0e04-5220fb6afd8mr16210701e87.20.1716157566952; Sun, 19 May 2024 15:26:06 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::8a5]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f38d3418sm4047465e87.152.2024.05.19.15.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:26:06 -0700 (PDT) Date: Mon, 20 May 2024 01:26:05 +0300 From: Dmitry Baryshkov To: Douglas Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Linus Walleij , Daniel Vetter , David Airlie , Jitao Shi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] drm/panel: boe-tv101wum-nl6: If prepare fails, disable GPIO before regulators Message-ID: References: <20240517213712.3135166-1-dianders@chromium.org> <20240517143643.2.Ieac346cd0f1606948ba39ceea06b55359fe972b6@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240517143643.2.Ieac346cd0f1606948ba39ceea06b55359fe972b6@changeid> On Fri, May 17, 2024 at 02:36:37PM -0700, Douglas Anderson wrote: > The enable GPIO should clearly be set low before turning off > regulators. That matches both the inverse order that things were > enabled and also the order in unprepare(). > > Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry