Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2133015lqo; Sun, 19 May 2024 15:27:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgDbIO3HzTr/Vz1qr+xW7KxpcwZ1VV5icPG8O1zAPNJv/fnTRIZBABUJr7b2vd6mhrPUH18jvy8GwfMAJQ+FpA8y/MC0zLjmPGXJWY9A== X-Google-Smtp-Source: AGHT+IHBvPeSAGbtLcuofCh+2MnO4k4c/kksoN2jFBFyiHtq/WaGx2isVaWVH6pq2M1kpG5HN06K X-Received: by 2002:a17:90a:5d88:b0:2b4:32ae:9a17 with SMTP id 98e67ed59e1d1-2b6cc56a7d2mr24576139a91.11.1716157637571; Sun, 19 May 2024 15:27:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716157637; cv=pass; d=google.com; s=arc-20160816; b=hZ1Y06jfSKdcQFJlEv0XrjlFyKiS55Be2UY4eEyvIyndZYWch5WIfsdZjPwhOGVaDF fQXY5CR4Cufx7w07diRIu+UveHIdV9QtNLK9qCijj9tuFEhgcZM8Dlkd2d1xykZb/Jeh U8+Htv52kX7IL9BGIaaLOJznLVbr6oDYcZ5y9Xz1TBN8RvDQUc1mpbhqEgqF7zZ1v+0X S2EwecSPrCr6vKgj7pi00tGOrIGSQpzdPizlceZVoXmHxWCuGeaNOZJEplbVrPqpWJ0k iI1v/YnH8yB46+z7roBz5yrueZsYyhWpWCOeVKaMkkpnkW1cUQVQ388fuuVdi4i7ymWa /+Wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JObSYzQBPhN8GXmYgBbRvZYZ/SCSfA1Ecyc4ynw/10k=; fh=AowEMFYx4q7WYPe7j8qSREXqHmKQ2sOZ5UtXpjT3GaY=; b=P9qfwCbC3OrufWJt5T3AYF0dXvsmrAXC6NUoCOTn/M7+Bu3gMC51g6sgylOKwro7xX wdOVr4SGNFOm4DPIBAxTB6AUWikA6n8RacB2Jwy8ES5qDxtC3DAV7BXP/UM1TijCdOVq +Y79iYdtz8koU8UmYwZco9Xu/Y41UwAXR9HnLs4vlIz9jqtxfm6rCMJBp+Rlkybynt8e x6zHkkJa/S+TLESi/h0FH3V6gFn7oCWKBwDHpfA9bdXKx23mkZM81+oUBdAz/Untgalj 0JvngMna6Nnt7pCWPFjy8nYvuNpq5Rc0MgWFG2l2YACXRxrBglSxyBv1w2iRH6k5hDS8 n8Jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nZ7OdG47; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bd6858d251si2624382a91.45.2024.05.19.15.27.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:27:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nZ7OdG47; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E8F4BB20DFB for ; Sun, 19 May 2024 22:27:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2893A73504; Sun, 19 May 2024 22:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nZ7OdG47" Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9736971745 for ; Sun, 19 May 2024 22:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157606; cv=none; b=gxQt0RfMMCc9ZKnR4TM6eGznyOhkQAofAO4Rwk7J2jezs7DkgF/CXDWqt6JC1uQPP3EP3ScuCNLv1b7m6qoFFqzOvqR0qi2EtwU1+dof18G/5lwOJg2p4L84F4c7brgmL2+lIIKwzfgXymSFp/jmnkPpA66lX0pot4rcwEWMyS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157606; c=relaxed/simple; bh=bhsmvXZL+pT7EmyzyVZPA1xgTKqR02mDPGlmGXciAs4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cj87bHfnAywEsejfqMsAMJDJFYM/tCuGwvMtxCDdGCzs0q8dpQHAT52LtVvbjeQsSabaF0npHrPX/IKiN3AMiYOLiQABNBjuzIac8SSD8uLpsoNxXIiSt05OaZoFge91VstjlYpC2xrBMOgvmT8N5K4ijVDjbHBZn5sMh5gNaeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nZ7OdG47; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2e6f33150bcso37922001fa.2 for ; Sun, 19 May 2024 15:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716157603; x=1716762403; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JObSYzQBPhN8GXmYgBbRvZYZ/SCSfA1Ecyc4ynw/10k=; b=nZ7OdG47AmzNx8CMCzNdKmkW2V44WzcDZJd0p9RdRqOqb3CzhnRRpnplxzMeGtXinx ib+bklGLm0smH/lKd9mW9Q/Z7zNW1bQ3Pvk7U7h8YNCWWgDvFUZZi1agHnzpwCp2zAow KFbxSBwb9Lp4HWvacXT8JTQJOEinGeg4Do03RF4Stkw623t8RbcBDeNBI7orYvc4QF4+ Coyh8tYvIjJrXEYgOAKUY3L/HYhmFbVNpQFk/iyh5Z8y87tf40YGNf7TnCKMEqDWw9dG X5EYgRLCleFxy9ZbL2Oht744HEWlQjmdrUoqms6tUIzrQK89NeBz2zZLnS+5ZMiSQflB x5sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716157603; x=1716762403; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JObSYzQBPhN8GXmYgBbRvZYZ/SCSfA1Ecyc4ynw/10k=; b=kiCU+PWWi6ejsIxTc5z/bl9yuHdNH1rojpHur5tb6koICBXHAMT2MZAGAX7GNDgAdp fJsrx/3q9Pk+MCtgdxH5ijmXQhTpeffGd+8TwQtUYWy+h1p3RjXTNYehB6N8h4Q7rB72 zD10trEcRrvuRewNSbLDCwDHGrrwPbIhpWOLc2i7jU8k2bWD/i3KWvfy+bwqq2EJzuDY fiCa1ODfZqNbhOE+/yfzLHfThVG15nqCnmFWC/3pXRFULwIor2fcW7qP7CcWMbsRbxgk eGKmM5V31FVaJWX5t4bjnrAVhTts4Pw05sbLGSEIppaXnud2OQPGQTdfcGUs8rzUtgrg qL/A== X-Forwarded-Encrypted: i=1; AJvYcCXMRYNo2+qVemoy9d0U9Y1b7+yBixpunoW7SoQubliWWp/ZaOm/vk1kgGBX95uz/xJy6Dc4WDE1hAZ6aQOoONGgfx62SOQOoiUy4niv X-Gm-Message-State: AOJu0YzNH7lK5i2GUX3odiBp9JCKKOGSTRck/BOrr79KsDxlfj19y6dW U9z2pnLYd8qOlUIHQuvUL3BMnQN+rjd+1FiggC6hD3cftsNMMBC7Tc5pyjvxPiM= X-Received: by 2002:a05:6512:b88:b0:523:8c7a:5f6 with SMTP id 2adb3069b0e04-5238c7a06e3mr11745122e87.51.1716157602727; Sun, 19 May 2024 15:26:42 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::8a5]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f35ad640sm4025069e87.61.2024.05.19.15.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:26:42 -0700 (PDT) Date: Mon, 20 May 2024 01:26:40 +0300 From: Dmitry Baryshkov To: Douglas Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Linus Walleij , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Shuijing Li , Thomas Zimmermann , Xinlei Lee , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare() Message-ID: <5n7uz7wacuz7cwlv5drr77l27kq7nsw34horh6o5iecrhs2tws@5gvxuusty4rx> References: <20240517213712.3135166-1-dianders@chromium.org> <20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid> On Fri, May 17, 2024 at 02:36:38PM -0700, Douglas Anderson wrote: > The mipi_dsi_dcs_nop() function returns an error but we weren't > checking it in boe_panel_prepare(). Add a check. This is highly > unlikely to matter in practice. If the NOP failed then likely later > MIPI commands would fail too. > > Found by code inspection. > > Fixes: 812562b8d881 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence") > Signed-off-by: Douglas Anderson > --- > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry