Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2133219lqo; Sun, 19 May 2024 15:28:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUt1JugSygTLfcwVxVWI+g4lX9+0RXHoS2mt4xLUc4TLH9hlmO9XF+gnsUKzdGGpnru+8jRZD3NdcvLHGgkRJNbq1lIGCT8Pt4H4/a38g== X-Google-Smtp-Source: AGHT+IGY4KD4Cb9p9XF5UuvO2M5p4yvCS0E/GrMB0xKmvBIjEKQkN9sL7T5GruphpgiRg9fbYOpN X-Received: by 2002:a05:6a20:6a22:b0:1a7:5334:fbf3 with SMTP id adf61e73a8af0-1afde1df5d3mr30813524637.55.1716157681717; Sun, 19 May 2024 15:28:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716157681; cv=pass; d=google.com; s=arc-20160816; b=K2sr2rCZkrGew+DZnZzU3vZ4Fkw18UTiixyHEYqGlBxoZYK4u7kmKQn1RRcNZ3MfNE CBOLTdhcixuHYAVqiRfz59aQv+IG/mzMeFaHJ13K6xyfzGCQ1WxNjYzRIiCk6v+XmyS1 ZTsKeUag/sp50qzZdSOedyFMOOJ9ieN5bAmFSSwBGvEv3q7ts+kUi6MV8oEXuDZ1Thhq RqLKB2DaNaVpDtRQgF1qfx/Dlom83ygvfJFCezNcta93dGNmZskzUVbKGNKEzaXEkyHy dy8eG/G+r0oGOuZH+7+kcouUFfHJ0G9WLgTkFG8QLB8P0fWAvoXvlgDql6EYp153wNTM vMvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BO5+7Q1RQRDjYzltuBgr3Uv8DKIwV1or1RwSqwkaB4A=; fh=if9KJlf/aqvAAPpFua9xLR7i0gSG1j5hoGltC4felM4=; b=ccPg4OisSNSMbQsdlCLSwMcvk2tC6GbTkfLiaOgsKPyJ0++EyA/aVqJu8Z4C0RRWPK ZJLGFDvXulHB/rUww8pYb1SkCh0aU84WluK7v4nq9UQfKImaLtIvwoJGAC9KQgY2uiN/ nxGcWQb8tzOJKPvid2PmBIVe03Uat6UNE+V6wyaYVLSOTaFOnTyHIzxF+9jLEUjcpPYp V8m0kMk7uw7RGnO3xFG3C6xu8LhvP0ZbCcSVYceGowTWckwnrNqGeNqEqAOur1x9xZn1 7YsrKD0JYJDrvflib0n4x4j3RRndixmU+MKpvaS5WrIXakfFWnC4/2/mDegn8UOb1yzo mRPA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JcEXA8sO; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4f95e4d60si15717748b3a.236.2024.05.19.15.28.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:28:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JcEXA8sO; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6C37FB20BA1 for ; Sun, 19 May 2024 22:27:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4C5BC73163; Sun, 19 May 2024 22:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JcEXA8sO" Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C345B4C80 for ; Sun, 19 May 2024 22:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157671; cv=none; b=AWFfGfOZ1iaMyDCTEzVaPCHL13dFhbSgHJV/MZAFa5/JNk8CtPEkGzesGF48pMOJW2y2K73qr5CCN+lrVIK5R1VindRTBcjEv6fLwts+B8SbgNZBwNooLRSKj1reYYvwyhytp1F8LnGkoIKnjKB0SCWuiXqe6N23D2JDDemZ56c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716157671; c=relaxed/simple; bh=gTUdex1Owj5iw2Rt44FVFhRRUu5Bw5Ce2vT1fJSrgbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uf+6eGWHMGVZN+WzqZ7KyOPt8vzTUc1VPaOi4+2Nyj+HjcPO1G7ysAswi4wO/pPrci0ZKjDhWw3n+OkacrN1yRr7RhWn+ONd2G9Gh9shCMRFmAdkSwmV85Nec4Za1JJDMUuTVF54yobOmwf/LWf9ts/PNaC5vIF2f6wPLcgTKLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JcEXA8sO; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-520f9d559f6so4616071e87.3 for ; Sun, 19 May 2024 15:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716157668; x=1716762468; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BO5+7Q1RQRDjYzltuBgr3Uv8DKIwV1or1RwSqwkaB4A=; b=JcEXA8sOBExqpUhe+byKKsSvXGmtndFEpZLx74VQqDKIYE8qYasLUD8XWz8e1bzkw/ HeBaTNoIIvFgI2nI+1Olv6U52K1lCbOARI4KHsZLLeJawEzFROO8ORBGLPohuBt68aE6 F6v/6L+sgjhsuh16CK62ZoCwFcBpXqotR9d0Mg6T+bZDbghDtuHqZOeQhH1Lw2dv7vJf n5VoAW8WBqdKbI+IaDL8g98srb3HhHDRIbeOiqZ84eNocyOrfHjdSJ4NkGgF21VpX8Cy EV+RYFuTtmz5/dUUViCkn0JhGTDd+jM8ktW1v/+8cTcZMxPAS0CIoO5PBw/ngRZb20ZI Wpig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716157668; x=1716762468; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BO5+7Q1RQRDjYzltuBgr3Uv8DKIwV1or1RwSqwkaB4A=; b=onAMXBVGzRpNUpXVCLuvUbl87mm0y64FfdHFjGkT/LwLMqTEZ6xs550+m+1r7ytiah TosrsQ4s7RnJBTqoaw9WQEGrAzXEHSrtCdBSklMT2arLQYkAVslT3v/q0+GUbGsdAY7c IQxyFAdFCWMQe0buaGftjdDG/i7jROZxLH0gfRqGV/ApvXhrhaI7uYLyqBSIKEOkiZck ExF5cVrHu3+dLvgiaa7H4DRGs/3nkgs9embznfLnkGGGmou9o/BqPbddDIUZfDfvRKKX Oe5h1AZ5bTI8qJAduVcfp/UqAUW1CmK7awt0eeFBlESzO2+XTSuFDCuuNVY+Q8zazqz9 o2Lw== X-Forwarded-Encrypted: i=1; AJvYcCVtlI+STKqtZ7ihv+ydiBuwLWGC9oDFR4oALXexturSUZ1DzFAObFQejh4TVNgI924CCg9Qf8H9p7hE0AXElVv1XafVIAXamc+BhmwB X-Gm-Message-State: AOJu0YzJllqI3MSS26AzLiTzooJNxNPwhjSVzesEStSJep/Ps3bh/Heo xb0A4NH3CNLhSM9A3C4HH9P8EYSNbYezYyFXerkNFAt6h4aD9c/XWu4LJR14zoE= X-Received: by 2002:a05:6512:23a7:b0:523:48f2:e3fd with SMTP id 2adb3069b0e04-52348f2e4f3mr16139805e87.16.1716157668006; Sun, 19 May 2024 15:27:48 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::8a5]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f39d2c84sm4046198e87.282.2024.05.19.15.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 15:27:47 -0700 (PDT) Date: Mon, 20 May 2024 01:27:46 +0300 From: Dmitry Baryshkov To: Douglas Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Linus Walleij , Cong Yang , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] drm/panel: himax-hx83102: If prepare fails, disable GPIO before regulators Message-ID: References: <20240517213712.3135166-1-dianders@chromium.org> <20240517143643.6.Id0659a80147cf51e0ebb8fe7fee18db86851960d@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240517143643.6.Id0659a80147cf51e0ebb8fe7fee18db86851960d@changeid> On Fri, May 17, 2024 at 02:36:41PM -0700, Douglas Anderson wrote: > The enable GPIO should clearly be set low before turning off > regulators. That matches both the inverse order that things were > enabled and also the order in unprepare(). > > Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry