Received-SPF: pass (google.com: domain of linux-kernel+bounces-183170-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240519144920.14804-1-egyszeregy@freemail.hu>
In-Reply-To: <20240519144920.14804-1-egyszeregy@freemail.hu>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Sun, 19 May 2024 19:27:51 +0200
Message-ID: <CAMRc=MctEsMiRgaV5UTiaxjoFDa2izX9wnLAU07=G8gBEcSKoQ@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: Introduce "linux,gpiochip-name" property for
 device tree of GPIO controller.
To: egyszeregy@freemail.hu
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 19, 2024 at 4:49=E2=80=AFPM <egyszeregy@freemail.hu> wrote:
>
> From: Benjamin Sz=C5=91ke <egyszeregy@freemail.hu>
>
> Optionally, a GPIO controller may have a "linux,gpiochip-name" property.

Oh, may it really?

$ git grep "linux,gpiochip-name" Documentation/devicetree/bindings/
$

Doesn't look like it.

> This is a string which is defining a custom suffix name for gpiochip in
> /dev/gpiochip-<name> format. It helps to improve software portability
> between various SoCs and reduce complexities of hardware related codes
> in SWs.
>
> Signed-off-by: Benjamin Sz=C5=91ke <egyszeregy@freemail.hu>
> ---
>  drivers/gpio/gpiolib.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index ce94e37bcbee..e24d8db1d054 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -860,6 +860,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, =
void *data,
>                                struct lock_class_key *lock_key,
>                                struct lock_class_key *request_key)
>  {
> +       const char *name;
>         struct gpio_device *gdev;
>         unsigned int desc_index;
>         int base =3D 0;
> @@ -896,7 +897,16 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc,=
 void *data,
>                 goto err_free_gdev;
>         }
>
> -       ret =3D dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev->id);
> +       /*
> +        * If "linux,gpiochip-name" is specified in device tree, use /dev=
/gpiochip-<name>
> +        * in Linux userspace, otherwise use /dev/gpiochip<id>.
> +        */
> +       ret =3D device_property_read_string(gc->parent, "linux,gpiochip-n=
ame", &name);
> +       if (ret < 0)
> +               ret =3D dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev=
->id);
> +       else
> +               ret =3D dev_set_name(&gdev->dev, GPIOCHIP_NAME "-%s", nam=
e);
> +
>         if (ret)
>                 goto err_free_ida;
>
> --
> 2.39.3
>

NAK, this is udev's task in user-space if you need this.

Bart