Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2158963lqo; Sun, 19 May 2024 17:00:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUKz9tyJPI6yEUSIFL//Idpo/VDAL0K8SiYYWFRXLE1g3k0PGIaJbbwJsPQB/z07q+cbsQ4X9IUphR9XyqOZk9PyBCoSYlf0Ls/d+u9bw== X-Google-Smtp-Source: AGHT+IHVz3dvtl1xKc2+lbaPOoU6l3Tr4hUSVSxgnonk6bzghF1/EnYhQA8psmldsOEOgtB5w6ME X-Received: by 2002:a05:6a20:7349:b0:1af:839c:d335 with SMTP id adf61e73a8af0-1afde1dda6fmr33114598637.55.1716163244285; Sun, 19 May 2024 17:00:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716163244; cv=pass; d=google.com; s=arc-20160816; b=his+fSIn2OWiXgmgZ0UZIfR0FNjP0IGLKQjt0yiPub5mG0EVxbjW/lQXX18zXa/iva PuIP4AjOjaLqS2tBOCKt6LsOje0g/uTFmb/JdaKbbhcK2pnGnN73FaE30f9Pi9TEmulJ OY4vuMQPiD153z/LTCf/ucxoVaC2Cp+YTxIMWOQaZnzMJ+mew6ElIaGjtyMfVWcnIHmk dT73JBPJ4SIptQlqOgBNGPvE8ZitPbrdC88RHbyIRC3RGcgkZW01tL0fUISv3V1D5Xss S4UglISZ88VWR5OPQ1kZ/vWLzCLNEeTrctQMiNSsQe1FD+v7SSE2bNWk4WqV9af7DD0D t9Iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=V5Uixl3CtpDv5Q6rCKFx0U7He6H+TxRQtbN4bXKiRHw=; fh=E0DbcmpaWUMU3tsh9qMXjeTDw4iIX563hSZx7yhoIM8=; b=U0xayAAV1ObSdS92HiurBq8zIHxyexvYWURMVNdYZJHrZfQ+jk8zOz513jnMcJRMyr yjxQhFC5ZzUt51afQFL3INGU3NX0+88ieJiDda1HLbIbylJVM5DpwLzR1Y8+tkSutj10 E5idsJ6mO0sRuETXweFVIyt0ewvcjPFiFKmqoJ1WEhKAQgbEDGoPftPfVN1KsEj5Qj8I eYuhpiGvouyIBulV8I35VlVHwdKUN999BXYNgOzwQVcQp90dunYAMKPfTmEkQZ77gWNe VXjscM1+7EMJPPR8kRw9CVsJ6oLrL+FyTKe7aWJi4VKEPKgsc4FaTlMVgnXL0KcGc2L5 3k9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=uJZPEt6u; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-183311-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183311-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6341276eff2si22363972a12.619.2024.05.19.17.00.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 17:00:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183311-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=uJZPEt6u; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-183311-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183311-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 034C8B20C42 for ; Mon, 20 May 2024 00:00:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A17948CC7; Mon, 20 May 2024 00:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="uJZPEt6u" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAAD923BB; Mon, 20 May 2024 00:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716163227; cv=none; b=OGMjlBnMUDKcvNT0vMHGJM+DejxxA8VLkPogrcgyNrmiqK7vtBAsWnZUZODSdFjaW/On6VdR9ihEaKOlHsiVbgpZB53sO70zDM7B/+9Rk8ojat0c3laxzXHqYt5pw8Bc6A70w3JH0iLj3hXq4uiTtNGLcYUJeP66RNaHZuCe4Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716163227; c=relaxed/simple; bh=K7ZdYke6mZmulP4ruJdT4qcASJpvqUrfFF/cByhd60g=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=IE8NetejBn/sjMdxd9s/ij3yxmD5r9PH8edY2rWfq2B6F/Zr6GaG+KIeCiN2SlPqxd1bnUMxqnseqnLNCMfwBU4jDS42oAkQWp1a/dspLC6wbewFgYTl4G8li4okRZheqnjFwcDbOXNRCxwkXaWXm0w0qYX2FcwDCtL2AXgWvh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=uJZPEt6u; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC232C32781; Mon, 20 May 2024 00:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1716163227; bh=K7ZdYke6mZmulP4ruJdT4qcASJpvqUrfFF/cByhd60g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uJZPEt6u0yI4sB5B3ecpMDU9I0b6fOLkd9ufi2t25EcTCkJKF5Lia2tXV7gf9Avum MnrGy/0w34CNeNEdRg2NI7CcRNv242+GLp7YI/xpMfLJHn97CdGU08TwiSeK/TnpJG +ThJICjFGkaWjfRwa0FQWU1+eEIqbY31jKGiRHrE= Date: Sun, 19 May 2024 17:00:24 -0700 From: Andrew Morton To: Dev Jain Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, sjayaram@akamai.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] selftests/mm: compaction_test: Fix incorrect write of zero to nr_hugepages Message-Id: <20240519170024.c2e62a7b69b00bb30e86a157@linux-foundation.org> In-Reply-To: <20240515093633.54814-2-dev.jain@arm.com> References: <20240515093633.54814-1-dev.jain@arm.com> <20240515093633.54814-2-dev.jain@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 May 2024 15:06:32 +0530 Dev Jain wrote: > nr_hugepages is not set to zero because the file offset has not been reset > after read(). Fix that using lseek(). > Please fully describe the runtime effects of this bug.