Received-SPF: pass (google.com: domain of linux-kernel+bounces-183374-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <7e84c37f-e3f0-42d3-a9b7-c810b641b95b@vivo.com>
Date: Mon, 20 May 2024 11:12:57 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/5] dm: support retrieving struct dm_target from struct
 dm_dev
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>,
 Mikulas Patocka <mpatocka@redhat.com>, dm-devel@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240514090445.2847-1-yang.yang@vivo.com>
 <20240514090445.2847-4-yang.yang@vivo.com> <ZkTXzG1yrPmW64Z6@redhat.com>
 <80ddcd90-2e1c-4fbf-a45a-b1b5ff4d60fb@vivo.com> <ZkYmZaGWPtGIwedG@redhat.com>
 <8f49b95e-88df-48b8-9311-8a15414d8107@vivo.com> <Zkdqpl5SN3RV0smg@redhat.com>
Content-Language: en-US
From: YangYang <yang.yang@vivo.com>
In-Reply-To: <Zkdqpl5SN3RV0smg@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZHZFcWYxLzBDcjFvLzZrUndGck82Z0lmTkZVa1ppOVNNMWFpcFBNcDZZRkt5?=
 =?utf-8?B?MXc1Q0pBOVNHUk9ndlhFa3E4WlVGK3grMWZra0twSzZMU3lrdjExTjAyS3kw?=
 =?utf-8?B?WnZIZ3JhRE05RFpGeURtOUNaVG1TbjBSR1ZLbEhWWUN1RTFMRGx5amJRdWNr?=
 =?utf-8?B?Z1ZTZ2JhaFZuUG5yNE4va3duSXA3aWhaaFdaWVp6dkdrOEVPcit5MEQvOVVn?=
 =?utf-8?B?UzRvUUwvWXNiRXhncXFEMEpaa3BtR3lIZ1FWUDZ2ZzFnaHcxazNFRGpiVEZu?=
 =?utf-8?B?cVZ5emRkdTdpYlEyMjJ5WDM5S2sxeUJkVWgwaXFDaEFlV3N4ZUpKaHlac1Ns?=
 =?utf-8?B?OFRIMmxwV29PaVJzTnByYzcwakRXSzgwSnYxSTkrVmJ0RmE2RFloQ3VFZStV?=
 =?utf-8?B?RzIwQlVrYnlibVB1VXpvb1ZOajhKQ2xGYmtsQ1duRk1BZzRyUm4yUno2ZW1Q?=
 =?utf-8?B?NzBTQlY4WG5GaGhWdVRLaEdwdjZDZmQyTVRVVG9yYm1pOS9vRThlRURnRDFQ?=
 =?utf-8?B?TWFXd3JXZU5Hd1Vhd1cwTHlvVkxNc29ZSzRWK29xdVFzeUlJY3R4WFFUbTZJ?=
 =?utf-8?B?VW0zK3lwQnU3QVUxYzIrWWQxczQ5NVMvSXhuc3Z0V1UwTTBFSDRZRHoyd1Rt?=
 =?utf-8?B?MGlKNFgxL2ZuU3VsU044VHArRzZHdzVQSVJDbzdPWllCUEdPdldrb0JqTlp4?=
 =?utf-8?B?Ny9zeUVCTGFMdXZEYU1BSjkxS3RxNFdseTc3eFlxT0JlUlpaMFBqOTlJWkMz?=
 =?utf-8?B?RjFNb0NHVDBZUXdabHVSS0hmMFoxaFh3ajFueG96b0c4VzNkMGJWeFdlSFVr?=
 =?utf-8?B?SDdkZEY0ZWd3UVBORTdzY2RwbHFlajdpdWRxUDdyQndtdTJKdzhDb3IwOFRD?=
 =?utf-8?B?Z3c2ci9aY0M3WHJPQ21jOVRDVlJXTVN1Q3VxWm5Fc0dmaGZuK2hXaUFMalQ5?=
 =?utf-8?B?S2NUck8zYy9EeWZtYjBaaVNJQy9uSFBHVjdkdjBicFVwbnI0cS9RNTBybkli?=
 =?utf-8?B?WDBzTzNqK21NUlhUU0EzQ3V5SS9mTTdRbndLcjZnUmN4Q2FJWEhPekdwYWJh?=
 =?utf-8?B?NklENndacFY4ZGpDdEJONHJZdHA3RUFlckZ2R0U2ZkFBK08yVGJyK2ZKWDVL?=
 =?utf-8?B?Nzgrdk5TeVhlaWdtQUFlYkJtZTdENFJ1VURORlFFNXBIZDhMM1BLOUZBRjV0?=
 =?utf-8?B?RUNiektQT29reXZrNDZVSE5GY3M3SFZSZkVDcTFIVkk0OXdFVHZFeGdUNUtZ?=
 =?utf-8?B?U2VZZHZYTE5Ibk52cFRxeE9LeDljWlpwQ21QUzk2TG9oUnlxTG1yQ2V3ZzEw?=
 =?utf-8?B?ajA1V0trNW5FNzZtRHFtM1VEcVhxVVUwQ2dwc0syd1dGcDIyZjZRcU12ODBh?=
 =?utf-8?B?cUtXTFJuT3B0MGl3ZXJ6MXhaSjhnVGM4dHJRQzY0cG1LbUZjZlhLOFNWSzh2?=
 =?utf-8?B?L3BqRTlWWm55dXk4aTJQRkJINkJ2ZWl3KytMdjl1eXE3anZ3d1p5VDdYcm9q?=
 =?utf-8?B?T05sbmFWL1V6RVRLbS9CSzJIWDc2blpUZiswei9zOGVRZlBUbHhMYjVtNUg3?=
 =?utf-8?B?ek9INVZac0d6N2RTc00zbGFCMCtyZlFHMWt5VFFhc0MrL1IxWkxCT1UwbWtP?=
 =?utf-8?B?TjNQeGdoY0dzWmVJT3VZT2FqVVJienRUdG1UTUxSOUJNU2J2Z3NIVmZyQktx?=
 =?utf-8?B?TlQ4S0xYTWtLbzI1aFdJSk5adWlPbzM4d3R6Z0U2UC9WU3lVMGxOZG5KV2l4?=
 =?utf-8?B?RUxzYzJFRnFBeWVyMjlQM0tRT3ZYTjdVdForQXNQa1lFWmRhKzJUZnN5Y2Va?=
 =?utf-8?B?VGpkSTFJYWZsRmVKZDY1SmxkRDgyUTdua29WTGpLOVpLN2xpeU41YkJiQWRF?=
 =?utf-8?B?L291cmo4Z1gvdzFjT3hGZmxYNWZ1aThNSnVvMENyNlZRdjZyTjB4R0lLaFRy?=
 =?utf-8?B?aVNEemsvLzRhWkdlNUpWY3pzTU1CR2xBb0RUaWhza2dESzZVcmwraVZhbktV?=
 =?utf-8?B?T3F6TzlVK2hwMWF1NHgyNE9PVWZVQmo1VkhoVTFWei8vcmJOSUxIclo4b3pI?=
 =?utf-8?B?c0lJRjNkYUlhZDFqVFh1bUl6Nkkzb0dOMjc2L1pmOTlFUEJ0Rmd2TXpnOVZ4?=
 =?utf-8?Q?xOUPdkYkYk1EmkN/awPV794vw?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6670b4a3-9047-49d4-3261-08dc787ac1fb
X-MS-Exchange-CrossTenant-AuthSource: KL1PR06MB7401.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 03:13:01.7322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bzo6d3DGzgtiAjhGhJgGdFxnUwaIf6+gcGezuGlG3kXy8DinCafjDEUVqm2rrLSN5MzrV8m/VQ4JycETW7ptAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5392

On 2024/5/17 22:33, Benjamin Marzinski wrote:
> On Fri, May 17, 2024 at 03:48:49PM +0800, YangYang wrote:
>> On 2024/5/16 23:29, Benjamin Marzinski wrote:
>>> On Thu, May 16, 2024 at 09:55:53AM +0800, YangYang wrote:
>>>> On 2024/5/15 23:42, Benjamin Marzinski wrote:
>>>>> On Tue, May 14, 2024 at 05:04:42PM +0800, Yang Yang wrote:
> 
>>>>
>>>> If I understand correctly, you are suggesting to iterate through all the
>>>> targets, handling those with sends_pass_around_flush set, and skipping
>>>> those where sends_pass_around_flush is not set. I believe this approach
>>>> may result in some CPU wastage.
>>>>
>>>>     for i in {0..1023}; do
>>>>       echo $((8000*$i)) 8000 linear /dev/sda2 $((16384*$i))
>>>>     done | sudo dmsetup create example
>>>>
>>>> In this specific scenario, a single iteration of the loop is all that
>>>> is needed.
>>>
>>> It's just one iteration of the loop either way. You either loop through
>>> the targets or the devices.  It's true that if you have lots of targets
>>> all mapped to the same device, you would waste time looping through all
>>> the targets instead of looping through the devices.  But if you only had
>>> one striped target mapped to lots of devices, you would waste time
>>> looping through all of the devices instead of looping through the
>>> targets.
>>
>> Yes, I get your point. This patchset may make things even worse for
>> the striped target.
>> I am just curious, in what scenario is the "dm-strip" target mapped to
>> a large number of underlying devices from the same block device.
>>
> 
> I don't think anyone in the real world does create dm-stripe devices with a
> huge number of stripe table devices. My point was that it didn't seem
> obvious me that looping through the targets was a significant problem
> compared to looping through the devices.
> 
> At any rate, Mikulas's patch already does this optimally, even for
> targets like dm-stripe, so it doesn't really matter now.
> 
> -Ben
> 

Yeah. Thanks for the explanation and your patience.