Received-SPF: pass (google.com: domain of linux-kernel+bounces-183412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b66ea07a-f57e-014c-68b4-729f893c2fbd@amd.com>
Date: Mon, 20 May 2024 10:34:41 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From: Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2] KVM: SEV-ES: Don't intercept MSR_IA32_DEBUGCTLMSR for
 SEV-ES guests
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, thomas.lendacky@amd.com, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
 hpa@zytor.com, michael.roth@amd.com, nikunj.dadhania@amd.com,
 kvm@vger.kernel.org, linux-kernel@vger.kernel.org, santosh.shukla@amd.com,
 Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240416050338.517-1-ravi.bangoria@amd.com>
 <ZjQnFO9Pf4OLZdLU@google.com> <9252b68e-2b6a-6173-2e13-20154903097d@amd.com>
 <Zjp8AIorXJ-TEZP0@google.com> <305b84aa-3897-40f4-873b-dc512a2da61f@amd.com>
 <ZkdqW8JGCrUUO3RA@google.com>
Content-Language: en-US
In-Reply-To: <ZkdqW8JGCrUUO3RA@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkpYczdXRlVtQVYvSVpqN05BUUQ1d2xVcjZXVUZXNitXMFVIRFQ0dzNHOENT?=
 =?utf-8?B?L2pacm51WFNqNEN3UWpyVHlZQ1R3dlhhNENLbHhUd1V3c3QzeVhIcGJjSVlE?=
 =?utf-8?B?d0JSaXphc2FtZ1c0TUJ0ZWZHbThnbkxtNmJkaDZDOFl2WXl0Z2lEUDdxMmF1?=
 =?utf-8?B?V1VxcHBHc0NhRzc5YUVLbXBUOUtoUlA0QUpJRXN6YWVKd1hOdExvR2cwdWxU?=
 =?utf-8?B?dWJrTWEzTDIyY3Q1TmxJTDRrYlFFTC9COEF5SDZLZW1oNUQxUDBjV2w0SmdP?=
 =?utf-8?B?UDhoUzNsM3F3V0xneDBTQW5RbmcrQVBXaitVbUh5dFhZUWZiSGtCR2pJZnZi?=
 =?utf-8?B?aWNMQ2JwZEpsRGtibjNyMDROd01FYTdOODlUbDVDQm1XUU5jRGtURENZblZD?=
 =?utf-8?B?OWh2S2U1eSs0czV4alFZaXNaRnZXazFmZk1NOHNuZm0yRE1lYkJHOFIxZTh2?=
 =?utf-8?B?ODluMzMyZ1NaUGM4TFo1REhicnJiSTZ5eldMUFk3a1hMTU5xZ3ZKemZSLy9W?=
 =?utf-8?B?T2FvSytXYVg5V0xIelR5UzRGZ0czcEYzZStma2lYM1puR3JmR1Nyc21ocnl0?=
 =?utf-8?B?dElXUHZUcm14Q2xHT3RjNU9OeG9sdXdBa0lYVk5TREVFZUVoZWl4VWRRMkl0?=
 =?utf-8?B?M3pKNko1V0V1T1FpNUlLSVM5aW1tcXRkMm03UUs0alM2Y1FpNUJYVkZJQ01X?=
 =?utf-8?B?ZGtka1BtVzZlc2QzeHRRQVlEbTZ4aTloRGNTUEtZNnVmRmV3Tm5qdE9QcjFH?=
 =?utf-8?B?ZVQ5WFZMM3N2OFZIVG16d04vUTV0em90MFBzRGFmT1Jxa2pVWTRqdkFkcDND?=
 =?utf-8?B?d2VVWHh4dDc5K2UvQk4vOFg1UG0zU1pCWXZnSWhlZGJJaTI0OUY2VXdXRUYw?=
 =?utf-8?B?WGhYU241QUFvUkRTVkpEbFQxalhISEpVY2RrVGdHL1J1NE43RFBuTUw1TWpQ?=
 =?utf-8?B?ck15NksrUjY2T1ZwalJoTU1BaVNTMUJIb2szWlN5Y1RMNE9yUm1GdDlmOEli?=
 =?utf-8?B?bzF2Rk9BWTNieVVTU09RdFdrbkhMbWpjalJKQU9qMlAvRkVDNGk5eC9rOW9w?=
 =?utf-8?B?WEZmOHMxcldxZDI1M3pyRzdKR2dtWnVFM2dCWE5ZTGtONWZwL0F5cFdPc0ZO?=
 =?utf-8?B?OTdld3krbzJZa0d2eFYrbS80KzQxSzh6TlZlQnYva1lUNWxVUTJ1OVMwaEkv?=
 =?utf-8?B?czNPOEtvME1ETmx2MDlybjkrdGNhL2dRVEZkNWNJUXFZUTZUME9acEE1UFNk?=
 =?utf-8?B?VnFMNDRta0JRQkRmUTYzaklwM0ltcjIzaTZvVmZERmluaTRZdk0xNnFVc1dE?=
 =?utf-8?B?QUhhN2tzSVdaWkk0Z3NXVEFjOWhZTzVOeHZrUlU3cWNDNjJMaXNvL29KaCtP?=
 =?utf-8?B?S2haNkYzbHYyOEtJZTdRT203VlZmdzJsWnMrSGlNWHRvNEJMNFV6aC9mbmh2?=
 =?utf-8?B?QkxheVVMbmlueTE0S2c1amh0Smd2bndRMGI5WlhEbXF2MEQ4Q05Jdll2Wnp4?=
 =?utf-8?B?K2o0NmNtTEN4OHFTaWMvWG5Ya05UbDlKcERGSmxHaUl2RUFvWll6dDl0OWZy?=
 =?utf-8?B?eklYTzRVbHhZYitEK2ZTZkp2Y2pxakRla0tEYjdaMys2Y0Zab09kaEt2c1NC?=
 =?utf-8?B?bFl0d0h6YkQvRytWZ0xmcjJ4Q05mdG1WbzlxVkdIdWpidE9yamtTaXBLTTAy?=
 =?utf-8?B?a1lscUhXSTJlK2Rtb3VmYjF1SG1sazdjcE5wckFPbkZqVms4OFVLcHp1R2Ri?=
 =?utf-8?B?OEVySzNLYjdXWE5LNmpwVnRHMTl6Z0FwcGZSL25iVDZpcFVrR1NXQkdrU0Fh?=
 =?utf-8?B?Ukh3STE2SkQvdzZTZzZBaU9rSUhFYVNSUGF1WWQxKzdIc1NlTTU2OXcrOCtU?=
 =?utf-8?B?TGIwakxkNS9MQmVJM0R6SlRGdXMvNktITUN0K3F3QWxsNnQzVTVDMGxSbmJ5?=
 =?utf-8?B?K0VHdGVHVzNuTVlxeUZQZ2Rka3BBSlloU2JNT2c2M3lodFd2VjNQKzY4dXky?=
 =?utf-8?B?VVBZZ2FCN3VHY2FOZ0hiQ0trTjROZENlck9xRjdHWksrNVZTck53d0tMMEU1?=
 =?utf-8?B?RUdXNVlaVlJCM0FOSnRkSHJscTdPNGpUOG1OTmtVWjBENzU1RVduMFp4cy85?=
 =?utf-8?Q?bC9heAfvgryvTPvbo/vHMG9li?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e61ab2-a77b-46b6-5723-08dc788a5f7b
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 05:04:48.6366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ePJSWs3XLZ9jWs6amRfrNsvCe24IS4BwB/bS8OXWzsmABmB1F9VS4Z4S8ELY67lbVH6g1iOV+D/1OKburmWOBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8287

On 17-May-24 8:01 PM, Sean Christopherson wrote:
> On Fri, May 17, 2024, Ravi Bangoria wrote:
>> On 08-May-24 12:37 AM, Sean Christopherson wrote:
>>> So unless I'm missing something, the only reason to ever disable LBRV would be
>>> for performance reasons.  Indeed the original commits more or less says as much:
>>>
>>>   commit 24e09cbf480a72f9c952af4ca77b159503dca44b
>>>   Author:     Joerg Roedel <joerg.roedel@amd.com>
>>>   AuthorDate: Wed Feb 13 18:58:47 2008 +0100
>>>
>>>     KVM: SVM: enable LBR virtualization
>>>     
>>>     This patch implements the Last Branch Record Virtualization (LBRV) feature of
>>>     the AMD Barcelona and Phenom processors into the kvm-amd module. It will only
>>>     be enabled if the guest enables last branch recording in the DEBUG_CTL MSR. So
>>>     there is no increased world switch overhead when the guest doesn't use these
>>>     MSRs.
>>>
>>> but what it _doesn't_ say is what the world switch overhead is when LBRV is
>>> enabled.  If the overhead is small, e.g. 20 cycles?, then I see no reason to
>>> keep the dynamically toggling.
>>>
>>> And if we ditch the dynamic toggling, then this patch is unnecessary to fix the
>>> LBRV issue.  It _is_ necessary to actually let the guest use the LBRs, but that's
>>> a wildly different changelog and justification.
>>
>> The overhead might be less for legacy LBR. But upcoming hw also supports
>> LBR Stack Virtualization[1]. LBR Stack has total 34 MSRs (two control and
>> 16*2 stack). Also, Legacy and Stack LBR virtualization both are controlled
>> through the same VMCB bit. So I think I still need to keep the dynamic
>> toggling for LBR Stack virtualization.
> 
> Please get performance number so that we can make an informed decision.  I don't
> want to carry complexity because we _think_ the overhead would be too high.

LBR Virtualization overhead for guest entry + exit roundtrip is ~450 cycles* on
a Genoa machine. Also, LBR MSRs (except MSR_AMD_DBG_EXTN_CFG) are of swap type
C so this overhead is only for guest MSR save/restore.

* The overhead was measured using instrumentation code, it's not an official
  number provided by hw folks.

Thanks,
Ravi