Received-SPF: pass (google.com: domain of linux-kernel+bounces-183414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <35c0dee9-0e25-4000-5386-2480db4ab1b4@amd.com>
Date: Mon, 20 May 2024 10:36:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2] KVM: SEV-ES: Don't intercept MSR_IA32_DEBUGCTLMSR for
 SEV-ES guests
Content-Language: en-US
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, thomas.lendacky@amd.com, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
 hpa@zytor.com, michael.roth@amd.com, nikunj.dadhania@amd.com,
 kvm@vger.kernel.org, linux-kernel@vger.kernel.org, santosh.shukla@amd.com,
 Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240416050338.517-1-ravi.bangoria@amd.com>
 <ZjQnFO9Pf4OLZdLU@google.com> <9252b68e-2b6a-6173-2e13-20154903097d@amd.com>
 <Zjp8AIorXJ-TEZP0@google.com> <305b84aa-3897-40f4-873b-dc512a2da61f@amd.com>
 <ZkdqW8JGCrUUO3RA@google.com> <b66ea07a-f57e-014c-68b4-729f893c2fbd@amd.com>
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <b66ea07a-f57e-014c-68b4-729f893c2fbd@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVJjeFBHaWxaaWpnUmVZd055aXp0amwrVm9tbGQvMzMrd3ZkL0xQdUZJd3ZB?=
 =?utf-8?B?WkVWWnRsQ21qUFl2cTUyYTU3NlI4TytmdzhRQm1UNkM1SWVqa2wvOG9wQVBH?=
 =?utf-8?B?NjR4Y25GZDZwWXNFaCsreW5FQVR0U0lUemtwSU14L0xpaGp6bTRualgvcmF3?=
 =?utf-8?B?RlpTNE5sMWhKSmtFcVhFQndCSTJ1RVN1THdQR0VWMGg4M0pCS01HQlpLZDBF?=
 =?utf-8?B?ay9Qc3ptZTFMRW1TQWVHM0xRVEF0UmRIbmRoZ3N6Ulg3eGpzdnM1NHFjbDlz?=
 =?utf-8?B?b1hwVi9ZQ0dRMDA2ZmE2NndmZDhuNitUR2tSUTdYMTZjSG9wRXJ6eUtXZHBz?=
 =?utf-8?B?S3BKbWJyNkZNd2NzVlluYkhJZDRMZTNULzVERWhJeW1rMTlpKzAvMUt2a3gw?=
 =?utf-8?B?K0cxYVRMZll1Ym42NFZHa3VGY0kzQ2VaTmhMNldOc2ZLdjhIOGV1a1B6L3Iz?=
 =?utf-8?B?R0hiR3RJSW5TU3c2MVoyNlJiUWdWaW0xd042M1lSaWNTOThxQy9VSUNYUStG?=
 =?utf-8?B?NFBNR2RrZUwvZ1BkOXR3LzBqQU50ZWt6SnpXOUlFZnJBNFJ2d1hvSGY1WEJt?=
 =?utf-8?B?UHBXZ0ZPWFV0cjNKcDdiMnZCb3psc2U5N2VVb21CcEhYYU9Wb01oT3k3ei9H?=
 =?utf-8?B?RXZJQjVTNEJwMlJlT3ZLZnVhV0Nyb3NOYmpJR1hpbW1Zclk0VWc2Y2g4YTY0?=
 =?utf-8?B?UWU4cS9WY3dmR21OZ2M1WHc2YVdpMVlDWHgzaHpoQ1VIZXI4ZVpJb3kyM0t0?=
 =?utf-8?B?aEI5OFJFZkRQMzMydS9BbFJESlRZYytmSnpxYWowdmtrM3hRRmY2WEZQWldI?=
 =?utf-8?B?QlpNL201RlRGSEtuU09MU29NMno4VnFkbG9xUmRSNk1wOEFQZjQrS3Z2cmE4?=
 =?utf-8?B?a3dzT2RrZ1Y0eGdhQlhjMnJoY3pqcXFZU2tmUEdQcTg1RmpNNEZaaHk2WFF2?=
 =?utf-8?B?dFJMMGNqcDErSkVJWklMSnpxcXFZN08vcG8yanNwQ0krbno0cEFtSnV5dFZx?=
 =?utf-8?B?UTQ5bnRIVEhLbHkwUm1JbXJrem11ajVBT01wVlByYVFMYWM5RG5JaXg3QnBY?=
 =?utf-8?B?ZzZaaUR3Qk5LQWNBV3FkOWVCTDloM1c2WkdmMC9uaWl1alhndVZZdldrWlhH?=
 =?utf-8?B?M3pQL1Y2NXVKcGExUW9obHlzaHlUNDFobnlXdHNVY2dLdTdobTFXbTIzZHNw?=
 =?utf-8?B?eWxRL29jNXJFcjFiUFBLS0VWSGZnWnlEM2llQ0QrV3VHYWs2bVR0WkZQcGo2?=
 =?utf-8?B?bEJObEQzejZIeFhaV2pqUVg0NXpCZTZ6TjNRSFBGNjRHZWFGVzBLUjFhZXUr?=
 =?utf-8?B?UlVtSWVzTkxuQ2Q0Y01TUWdMTjhqZkF6dnlHdXpTVlhLT0crRWllVURJd01P?=
 =?utf-8?B?TWpOSjNPcTFxTWs4YkpIem53YnRWbVVvMzR5UmcxcDRWa3Q4NUtrZ1BJNS9Q?=
 =?utf-8?B?OTltK1dFWUtPU1Z5K2VIUlF1UTdrR1RhVlMrTXplenN1Y3NWSURGRkdzeTJV?=
 =?utf-8?B?RXBiRVl4UXVuU1dtTk5vREN2SlZKYkR2NWtqbWRBNnhnWGxlbEN6bGY3Mm1V?=
 =?utf-8?B?UUtLclcrSXgvTUN6TUNJcndic3pzTW9YTXFTWGtYUEJrTyt3YVUvbEVxeTVj?=
 =?utf-8?B?TUxjVkNkWXZBMHp5VkhEM3ZjN0NqODRKV3Iwc1E5N1p1L0tkVXdtTmtXdmxO?=
 =?utf-8?B?R2FkRzdqMWhtQ3ZHMzVvYUVTNW4xZmlOSU4wckxsaW9aZmM5NHVNV1psZFVr?=
 =?utf-8?B?K25nekY1UnZmTmFjMW1CQmZoTFNaY0tJT2dUVGw3STB5cGN4cTBMbE9jdVNU?=
 =?utf-8?B?MUJ0eUpqU01Ha0FwaG9OeEF5eWFIeU5neEhQNUdzZWdza0xIVmI4S2MrT0pS?=
 =?utf-8?B?SFgwQytJaWRxNHZXWVBtNFVWdWY3Z2JzOUFGZkZXQVdFd2tGZDNzenNnRXc0?=
 =?utf-8?B?aHIwMEQ2QlEyYlVYTUkvakJwNjh4Y3F2cjR2bGZNOXovOGczMFJpWW4wbnMz?=
 =?utf-8?B?YXpXaVJPSVRnZ0dpNkZjdHBCUE5seXpUd1JUaWI3RGZBaVY4djRhMkduemJK?=
 =?utf-8?B?RERiMFZzUEJXRFF4TG9BSGR1NDRGRmVTeEpsQjRUcUQwSlpyMDlpT1d6OEp6?=
 =?utf-8?Q?chKabC3O2FZrzgNNT7BnJh+7k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b9b3901-51c3-4a75-9fa3-08dc788aa8b4
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 05:06:51.4219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aQe4Se7Wshv57r/rs4Pab4zNbP49pl958nxPrZftgTB/G2G2hV2uUHlDky9hajaJwXDa5JS2kVs1IfTNZr2sAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8287

On 20-May-24 10:34 AM, Ravi Bangoria wrote:
> On 17-May-24 8:01 PM, Sean Christopherson wrote:
>> On Fri, May 17, 2024, Ravi Bangoria wrote:
>>> On 08-May-24 12:37 AM, Sean Christopherson wrote:
>>>> So unless I'm missing something, the only reason to ever disable LBRV would be
>>>> for performance reasons.  Indeed the original commits more or less says as much:
>>>>
>>>>   commit 24e09cbf480a72f9c952af4ca77b159503dca44b
>>>>   Author:     Joerg Roedel <joerg.roedel@amd.com>
>>>>   AuthorDate: Wed Feb 13 18:58:47 2008 +0100
>>>>
>>>>     KVM: SVM: enable LBR virtualization
>>>>     
>>>>     This patch implements the Last Branch Record Virtualization (LBRV) feature of
>>>>     the AMD Barcelona and Phenom processors into the kvm-amd module. It will only
>>>>     be enabled if the guest enables last branch recording in the DEBUG_CTL MSR. So
>>>>     there is no increased world switch overhead when the guest doesn't use these
>>>>     MSRs.
>>>>
>>>> but what it _doesn't_ say is what the world switch overhead is when LBRV is
>>>> enabled.  If the overhead is small, e.g. 20 cycles?, then I see no reason to
>>>> keep the dynamically toggling.
>>>>
>>>> And if we ditch the dynamic toggling, then this patch is unnecessary to fix the
>>>> LBRV issue.  It _is_ necessary to actually let the guest use the LBRs, but that's
>>>> a wildly different changelog and justification.
>>>
>>> The overhead might be less for legacy LBR. But upcoming hw also supports
>>> LBR Stack Virtualization[1]. LBR Stack has total 34 MSRs (two control and
>>> 16*2 stack). Also, Legacy and Stack LBR virtualization both are controlled
>>> through the same VMCB bit. So I think I still need to keep the dynamic
>>> toggling for LBR Stack virtualization.
>>
>> Please get performance number so that we can make an informed decision.  I don't
>> want to carry complexity because we _think_ the overhead would be too high.
> 
> LBR Virtualization overhead for guest entry + exit roundtrip is ~450 cycles* on
> a Genoa machine. Also, LBR MSRs (except MSR_AMD_DBG_EXTN_CFG) are of swap type

I meant LBR Stack MSRs.