Received-SPF: pass (google.com: domain of linux-kernel+bounces-183419-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <24063964-fa44-4093-bbfe-950eeb7d01b3@quicinc.com>
Date: Mon, 20 May 2024 10:55:49 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cpufreq: scmi: Avoid overflow of target_freq in fast
 switch
To: Sudeep Holla <sudeep.holla@arm.com>,
        Viresh Kumar
	<viresh.kumar@linaro.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        "Cristian Marussi" <cristian.marussi@arm.com>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Taniya Das <quic_tdas@quicinc.com>,
        "Ajit
 Pandey" <quic_ajipan@quicinc.com>,
        Imran Shaik <quic_imrashai@quicinc.com>,
        Vivek Aknurwar <quic_viveka@quicinc.com>,
        Mike Tipton
	<quic_mdtipton@quicinc.com>
References: <20240517070157.19553-1-quic_jkona@quicinc.com>
Content-Language: en-US
From: Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <20240517070157.19553-1-quic_jkona@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/17/2024 12:31 PM, Jagadeesh Kona wrote:
> Conversion of target_freq to HZ in scmi_cpufreq_fast_switch()
> can lead to overflow if the multiplied result is greater than
> UINT_MAX, since type of target_freq is unsigned int. Avoid this
> overflow by assigning target_freq to u64 variable for converting
> it to HZ.
> 
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
>   drivers/cpufreq/scmi-cpufreq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index 3b4f6bfb2f4c..42be87aebe6f 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -63,9 +63,9 @@ static unsigned int scmi_cpufreq_fast_switch(struct cpufreq_policy *policy,
>   					     unsigned int target_freq)
>   {
>   	struct scmi_data *priv = policy->driver_data;
> +	u64 freq = target_freq;
>   

To keep type of freq consistent with the rate parameter of scmi 
freq_set() callback which is unsigned long, will move the above freq 
variable from u64 to unsigned long and post the v2 series.

Thanks,
Jagadeesh

> -	if (!perf_ops->freq_set(ph, priv->domain_id,
> -				target_freq * 1000, true))
> +	if (!perf_ops->freq_set(ph, priv->domain_id, freq * 1000, true))
>   		return target_freq;
>   
>   	return 0;