Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2273249lqo; Sun, 19 May 2024 23:45:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWflN2ijyfZkst57SaGTcbMJRZKU9B1vMysvV16EIb2kAkUckZXOAl0+7BhP8N9bo+H0kxZMKJDUnLAXJg3w8lxZQyhRj8rdzJ4nhR+bQ== X-Google-Smtp-Source: AGHT+IG1a8kTWe/jceHT7iBIAyau5CVHI9jqkPyNWGDrZez4c/84EbtoNm77qXupFMAukgj5X+/c X-Received: by 2002:a05:6214:419f:b0:6aa:7bd5:8b8f with SMTP id 6a1803df08f44-6aa7bd58c29mr21344736d6.49.1716187525153; Sun, 19 May 2024 23:45:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716187525; cv=pass; d=google.com; s=arc-20160816; b=L7d0lJfnIJtSd1QGcZ7Wvon7QfbBLxFEmeLg8YnMLouy+EeotBR8w2NE6KWiFdmz67 Nqdr8GFUg4cfgXoIrhBvgTdyg+bucyxOQDePa5lwxdZw052fiUwd08RXC5RigUkjAilQ tI8dAZj+MnTR7Trfjsm2aH+7ev20j7klWqHjEzBG+3bpBVGdmE7b6/t0M5ENwwdDl7ic qbAhE/ltLOkJsbZ+GeSXm2ExRU8OtfomHdvMo5S1PoKkn8bAStkEsMi113fdElS9aslF zz7vwfKyikUafSJYCmPn48h01oFngtesMzFHXBGtUZVqtz3Gq7fl+opCK0NbuBFQ9H6L sTtw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Z0V+uNbmY7tN3qWcpBZkwWLP1qbT3At4MWvLMcy0LGI=; fh=vyXUUtDGHd6aShUfhRnk46tZNS97H7JyjuIcZ4OndJQ=; b=C5Hw8teRowC9O9KcRsEI9TJ4lcLYQ8iKbB4WyU8GrDHpcNMrdrd6Oun3S/+Fm2GKXz rmCfZ2Dtk8e6BBtchXJn04S3vRgBCiB4Bp2MzYgc+GSp5WMZdsczpEaUTEMh3vO47wxC 46yuCJKFOz+3DOyaSzved0R11FedcEaNeZY8FWNF43x+tmcELkYlL8BMoLOu4NwcMESy DCcy75/+GQAED5tE/bpih4MAlc4m7MTTxdVa6+3XpHKJyoSTtko0/gIt/ssUvEeqf0a0 IluXhNqIAq/ztWK3Y8zFrhWo2ifrM0SsWmqK4gKAaiUh3de4SC9hz+tkNcCtis5RYOMl PQKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SB/u7ulb"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f2ed228si249396876d6.449.2024.05.19.23.45.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 23:45:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SB/u7ulb"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B66DE1C20CAB for ; Mon, 20 May 2024 06:45:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5675317C67; Mon, 20 May 2024 06:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SB/u7ulb" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91028168DE for ; Mon, 20 May 2024 06:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716187514; cv=none; b=s6gyIinjaLxer1NCzpksaMPl0N/U+X9IFZ+o31yH2Wx6EdHyWl1Vzobus0/YLQfOwqeBsEkt/QRgt36CXhLUQjjf2zf122nfaUlXunHUn2ShNVMQlQnrAzfYx9SE77S0hFc0jVDUAGrse1nEXfhN0OLx8fDYhO2eY2vzJ/B/qg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716187514; c=relaxed/simple; bh=hr75UYv2qEd7xP77FZGkKrnpVYDdbRGTw6NR1qgODD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r+wo4iXudGgYqI3BTMr+G79LN7VPrzc0zR0RKRPMCskHp9oWdgdr+ETZhiYfJT1lRYfsOdqnem7ts2iNc6cn9rf2u26NDA2AInPBSIdMy6tUD53T/dqtH+G4b3SJVv/t+gOPSBeVyNC8Y82HUN7FPvno59NXWB+qIMpJqTl1W6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SB/u7ulb; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-574d1a1c36aso6817361a12.3 for ; Sun, 19 May 2024 23:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716187510; x=1716792310; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Z0V+uNbmY7tN3qWcpBZkwWLP1qbT3At4MWvLMcy0LGI=; b=SB/u7ulbCsvRA+e/9nRqenVZ+XOF6wc4OcyyAqdNFaCsxPiA/yqxxMBACbJqNWylch PP6fDvAxGAdsPAQ5ATr/JtXf53kAjrwXj8nVddMNXQEQPQtGXTr5yQ3NHJ4KEBeqkofA ZNckKAWalUJS9JwpE24VS/SslyjxAxfd+QhJz5zRrovkfTsic5skUHYqhIAm6Xovq+eX HR6nmAiouS9enEUuPHJjNefBtpt0q/Uuc7u3Pb03rkDclXxUh/co5/Wd+7WA3ZuGrJzJ pXHTKZu/1HakUq8a+EjHenHilMy6B1kPzM2NPvc6OFUyarnBuhZQ3SJtkrQmPJyFrZyV VzOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716187510; x=1716792310; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z0V+uNbmY7tN3qWcpBZkwWLP1qbT3At4MWvLMcy0LGI=; b=EbQT855r30EOeM73mnVZo7t8fFoR1taqLBYMi/i/1n4YQRyKoWOe4hGo+5TrsFDd7B hCWxQE3HGLLCkdIqgMAA8gMHNoZyQPatQVDSNyKeLnF6QhLuhAUCKxwYviLyU+Fn6qZo 6rRWoXTUGQp3RCknEQzJsLqIz344YX8RjlmgDZYaxvTthuipvVAooUzbVUHPX1pFQmxC MqOzXAduZJycrq3WbtNIMuZr7mTIVcEKqzn32Ha04P7vIxJ87ZXHNKHb/ocidRDWRSdy CV9CKFsIVP9oqN9V5f0s9/DrsyqXINA52H33ZCQX3IEdB1SVY50uZv5bzGhNZXXiC+W+ 6URQ== X-Forwarded-Encrypted: i=1; AJvYcCV2JpWXP5/5OBLylbbh6/RWAj7SECm778RHLuc1Rp3kDIYg3Hgz1FkXbntUWiQzIZM83Rm7n0J8GkZ1EsG7fQ1gPL943azQREqUqlTz X-Gm-Message-State: AOJu0YzhkIJjK3ckMSXdbDOVE8SfoRj1/8HARJBUOs71WmnqJSImfFZY siqamjLdbd+RNfOoUiRZIjQ/Z3iI5gRMmZeBDgOKc/WVIrAmas224oLcs1ZF3kU= X-Received: by 2002:a50:a6dc:0:b0:574:ebfb:6d90 with SMTP id 4fb4d7f45d1cf-574ebfb6e1amr9598442a12.4.1716187509796; Sun, 19 May 2024 23:45:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.206.169]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733becfcc1sm14224510a12.45.2024.05.19.23.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 May 2024 23:45:08 -0700 (PDT) Message-ID: <6f7ae5e6-d20f-4980-9b6e-25ba6d7b5558@linaro.org> Date: Mon, 20 May 2024 08:45:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] arm64/hyperv: Support DeviceTree To: Roman Kisel , arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, mhklinux@outlook.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Cc: ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240514224508.212318-1-romank@linux.microsoft.com> <20240514224508.212318-2-romank@linux.microsoft.com> <1766fc9a-1d10-4c93-a9db-a7e0db8b01e7@linaro.org> <267ef0e2-2384-44bd-81f9-f33dda7bb9d2@linux.microsoft.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <267ef0e2-2384-44bd-81f9-f33dda7bb9d2@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/05/2024 19:33, Roman Kisel wrote: >>> static bool hyperv_initialized; >>> @@ -27,6 +30,29 @@ int hv_get_hypervisor_version(union hv_hypervisor_version_info *info) >>> return 0; >>> } >>> >>> +static bool hyperv_detect_fdt(void) >>> +{ >>> +#ifdef CONFIG_OF >>> + const unsigned long hyp_node = of_get_flat_dt_subnode_by_name( >>> + of_get_flat_dt_root(), "hypervisor"); >> >> Why do you add an ABI for node name? Although name looks OK, but is it >> really described in the spec that you depend on it? I really do not like >> name dependencies... > > Followed the existing DeviceTree's of naming and approaches in the > kernel to surprise less and "invent" even less. As for the spec, the I am sorry, but there is no approved existing approach of adding ABI for node names. There are exceptions or specific cases, but that's not "invent less" approach. ABI is defined by compatible. Best regards, Krzysztof