Received-SPF: pass (google.com: domain of linux-kernel+bounces-183454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 20 May 2024 12:55:13 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: liwei <liwei728@huawei.com>
Cc: rafael@kernel.org, lenb@kernel.org, Pierre.Gondois@arm.com,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	liwei391@huawei.com
Subject: Re: [PATCH v2] cpufreq/cppc: fix perf_to_khz/khz_to_perf conversion
 exception
Message-ID: <20240520072513.vtlqwjbmxugvuppj@vireshk-i7>
References: <20240506075816.1325303-1-liwei728@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240506075816.1325303-1-liwei728@huawei.com>

On 06-05-24, 15:58, liwei wrote:
> When the nominal_freq recorded by the kernel is equal to the lowest_freq,
> and the frequency adjustment operation is triggered externally, there is
> a logic error in cppc_perf_to_khz()/cppc_khz_to_perf(), resulting in perf
> and khz conversion errors.
> 
> Fix this by adding the branch processing logic when nominal_freq is equal
> to lowest_freq.
> 
> Fixes: ec1c7ad47664 ("cpufreq: CPPC: Fix performance/frequency conversion")
> Signed-off-by: liwei <liwei728@huawei.com>
> ---
> v2:
>     - Fix similar issue in cppc_khz_to_perf()
> 
>  drivers/acpi/cppc_acpi.c | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh