Received-SPF: pass (google.com: domain of linux-kernel+bounces-183533-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 20 May 2024 12:28:12 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] spi: gpio: Make num_chipselect 8-bit in the
 struct spi_gpio_platform_data
Message-ID: <ZksXrM-W_69e5q2m@smile.fi.intel.com>
References: <20240517194246.747427-1-andriy.shevchenko@linux.intel.com>
 <20240517194246.747427-4-andriy.shevchenko@linux.intel.com>
 <ce75b03e-e061-43ac-94fa-1539c8fe6203@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce75b03e-e061-43ac-94fa-1539c8fe6203@sirena.org.uk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, May 17, 2024 at 10:55:55PM +0100, Mark Brown wrote:
> On Fri, May 17, 2024 at 10:42:03PM +0300, Andy Shevchenko wrote:
> > There is no use for whole 16-bit for the number of chip select pins.
> > Drop it to 8 bits.
> 
> because...?

To make the type stricter, but since there is no other benefits and
this one likely won't help to catch the (incorrect) use of big numbers
I think we don't need it.

> It's the only field in the struct so it's not like it makes
> any meaningful different to struct layout.

-- 
With Best Regards,
Andy Shevchenko