Received-SPF: pass (google.com: domain of linux-kernel+bounces-183534-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fb6ee370-54d7-4eff-8a44-ee7cf2d13e61@web.de>
Date: Mon, 20 May 2024 11:28:09 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Viresh Kumar <viresh.kumar@linaro.org>,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
 linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
 Andre Przywara <andre.przywara@arm.com>, Chen-Yu Tsai <wens@csie.org>,
 Jernej Skrabec <jernej.skrabec@gmail.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Peter Zijlstra <peterz@infradead.org>, "Rafael J. Wysocki"
 <rafael@kernel.org>, Samuel Holland <samuel@sholland.org>,
 Yangtao Li <tiny.windzz@gmail.com>
References: <20240520083522.vvga3aqjg4w3adkj@vireshk-i7>
Subject: Re: [PATCH 2/2] cpufreq: sun50i: replace of_node_put() with automatic
 cleanup handler
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240520083522.vvga3aqjg4w3adkj@vireshk-i7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:QBI3m0Ncq0k=;c3cL6gMCHAggpVYtmQaIPDAmjqU
 7/YAfq7dareu5KT74iLb6rfqNfT6Mmh+8HRex9EkUFLjXkl0tTM811TYZ9WSkLRCii3kPi3/X
 5jDVp5EaDEij5R8iB6g84/Lqkk16yasgKeuuuk3EnWYCR4FCbqWxvXHWryeIIsL1oFdMUCjfC
 t3uGwR/uzrp4qr1s+wj64EAvaoRABsw+k5XB28bbd3c/5vXMjXWFZU2V3+/IrBgOvh+mZ6Avi
 UpmxzjtPcFP9w30CPXhVK38EL2PoAWUDsGMndFCUc4/Ig+emvYLWDKi2XadVcf1knnlvr4AzY
 IGgY+eYCboDteS6AZzHSzkMXERru82JtjaIL3dv+pol6YzHKJN4xoSRbckERtRKbXzOZJv1mw
 Kl77HmCC0pbL3TGD/HXrHT8JzL6QzvUNbmIezJlzxZcxGqUb7GFG5nzHmbtHmJaMDRI/LYZDn
 /Evzkb2gHuHCNB+6YwqPpkQgRyztc/u+sm77mur2FQvy9RAjC7xc8DFJVx5+h4PjUJ/lnQ52q
 GdlfzoNkk0NF4SizfPWb5jCYg/sVEd6EuR6vWCXZsTsSkz90doCR3L9s8lj8rQNX+5WCfKRNM
 DoNl7SG2LhranQYdqYeWT/qtmXBRaWX7jEAiRT6c/4Ur3Wf/F6N/31KOuI27UEQRmuhTNypzS
 LQEh3s/livmf7VnAiEnzLHUFOcQAdgyAULqe79VXG7eo8otr/K8EbCwnSs3h2KGGQTj+4Q2PM
 9Nxg9YVhkpWEmB6JVYac2amaIrw8NrZx2c57m6grarJdxAp8tGZej768wLcXAOgntuogsYFWa
 u28cNRuVWTy5LsdyGfXS1216jtauRgwdnhcM3zMRhELvk=

=E2=80=A6
> > > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> > > @@ -131,14 +131,14 @@ static const struct of_device_id cpu_opp_match=
_list[] =3D {
> > >  static bool dt_has_supported_hw(void)
> > >  {
> > >  	bool has_opp_supported_hw =3D false;
> > > -	struct device_node *np;
> > >  	struct device *cpu_dev;
> > >
> > >  	cpu_dev =3D get_cpu_device(0);
> > >  	if (!cpu_dev)
> > >  		return false;
> > >
> > > -	np =3D dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> > > +	struct device_node *np __free(device_node) =3D
> > > +		dev_pm_opp_of_get_opp_desc_node(cpu_dev);
>
> Won't that result in build warning, mixed code and definitions now ?

I suggest to take another look at a corresponding information source.

[PATCH v3 04/57] kbuild: Drop -Wdeclaration-after-statement
https://lore.kernel.org/all/20230612093537.693926033@infradead.org/

See also:
https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Warning-Options.html#index-W=
declaration-after-statement


Would you like to stress a scope reduction for the affected local variable
by adding any curly brackets?

Regards,
Markus