Received-SPF: pass (google.com: domain of linux-kernel+bounces-183542-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] livepatch: introduce klp_func called interface
From: zhang warden <zhangwarden@gmail.com>
In-Reply-To: <eb464408-5567-4130-b899-90ba9756adc1@web.de>
Date: Mon, 20 May 2024 17:34:12 +0800
Cc: live-patching@vger.kernel.org,
 kernel-janitors@vger.kernel.org,
 Jiri Kosina <jikos@kernel.org>,
 Joe Lawrence <joe.lawrence@redhat.com>,
 Josh Poimboeuf <jpoimboe@kernel.org>,
 Miroslav Benes <mbenes@suse.cz>,
 Petr Mladek <pmladek@suse.com>,
 LKML <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7F8BE9D1-D68E-4560-8D5C-9025122963B4@gmail.com>
References: <20240520005826.17281-1-zhangwarden@gmail.com>
 <eb464408-5567-4130-b899-90ba9756adc1@web.de>
To: Markus Elfring <Markus.Elfring@web.de>

OK, I will try to optimize my description after the patch is reviewed. I =
am sure there are something still need to be fix for that patch.

> On May 20, 2024, at 16:00, Markus Elfring <Markus.Elfring@web.de> =
wrote:
>=20
> Please add a version identifier to the message subject.
>=20
>=20
> =E2=80=A6
>> If the patched function have bug, it may cause serious result
>> such as kernel crash.
>=20
> Wording suggestion:
>=20
>   If the patched function has a bug, it might cause serious side =
effects
>   like a kernel crash.
>=20
>=20
>> This is a kobject attribute of klp_func. Sysfs interface named
>> "called" is introduced to livepatch =E2=80=A6
>=20
> Under which circumstances will imperative wordings be applied for
> another improved change description?
> =
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do=
cumentation/process/submitting-patches.rst?h=3Dv6.9#n94
>=20
>=20
> =E2=80=A6
>> ---
>> include/linux/livepatch.h |  2 ++
> =E2=80=A6
>=20
> You may present version descriptions behind the marker line.
> Would you like to indicate any adjustments according to your change =
approach
> (from yesterday)?
> =
https://lore.kernel.org/lkml/20240519074343.5833-1-zhangwarden@gmail.com/
>=20
> Regards,
> Markus