Received-SPF: pass (google.com: domain of linux-kernel+bounces-183550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240519175906.138410-1-kanakshilledar111@protonmail.com>
 <20240519175906.138410-3-kanakshilledar111@protonmail.com> <171614715439.2941344.11264816105918092609.robh@kernel.org>
In-Reply-To: <171614715439.2941344.11264816105918092609.robh@kernel.org>
From: Kanak Shilledar <kanakshilledar@gmail.com>
Date: Mon, 20 May 2024 15:09:44 +0530
Message-ID: <CAGLn_=tLdJU1F-i9YV5aCZQbS0L7y7Wu+_k6Dn=6HwH5JmZoMQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-riscv@lists.infradead.org, 
	Kanak Shilledar <kanakshilledar111@protonmail.com>, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>, 
	Conor Dooley <conor+dt@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Albert Ou <aou@eecs.berkeley.edu>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Samuel Holland <samuel.holland@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 20, 2024 at 1:02=E2=80=AFAM Rob Herring (Arm) <robh@kernel.org>=
 wrote:
>
>
> On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote:
> > removed the redundant properties for interrupt-controller
> > and provide reference to the riscv,cpu-intc.yaml which defines
> > the interrupt-controller. making the properties for riscv
> > interrupt-controller at a central place.
> >
> > Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com>
> > ---
> >  .../devicetree/bindings/riscv/cpus.yaml       | 22 +------------------
> >  1 file changed, 1 insertion(+), 21 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/r=
iscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed=
, one must be fixed:
>         Additional properties are not allowed ('$ref' was unexpected)
>         'type' is a required property
>                 hint: DT nodes ("object" type in schemas) can only use a =
subset of json-schema keywords
>         from schema $id: http://devicetree.org/meta-schemas/interrupts.ya=
ml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202405=
19175906.138410-3-kanakshilledar111@protonmail.com

I have fixed the above warning.

> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.

Can you please clarify this part? Is my base commit ID incorrect?
I am currently using the 6.9.0-rc3 kernel version form
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/ repo.

Thanks and Regards,
Kanak Shilledar