Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2341678lqo; Mon, 20 May 2024 02:49:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVtB9scU81cQ8cSAVd4LguQyRE2uAqJrHpxt2JVfSxaONiTus1QQl8lHQA91bndQxP3DSr2XFe4Rt3pnUY89T3KWU0WtPp9LI/jcD8IgQ== X-Google-Smtp-Source: AGHT+IEEQP2i6ylzV9WXUtWL0913mh7sQ+odwqEtMj17rhDNEocMCfWHU6yRLr/+oWphq3evtrJd X-Received: by 2002:a05:6a20:2d24:b0:1af:f640:13fd with SMTP id adf61e73a8af0-1aff64015d2mr22689292637.62.1716198581798; Mon, 20 May 2024 02:49:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716198581; cv=pass; d=google.com; s=arc-20160816; b=rQh4XfIRrAzLy1OXYH/POvZPang/5+vpu7uxbjSBnEqL6MM+QPqgo2t+58d7SlN9V+ tk4mV+SC3U9j2R9yj6fGydv4WcZhg++U3AnLeKqJgLLb4y8nuLn7qMu2dGSU7Vw2RENH r/qSjftb/d9+P0ycxgt9IiCNg9g4283MFAxI+iT1HSca7S/rMUkRo/L30xHaoz5KFwiL oRE7gY4XUGiEF8Ik6kl/ebBgduYWfRm/klm/jSDZe8ytasdnJtakG78+wb2oIaHjem4i Z3XklGe/dRG6B2ystd07WK9bf5IildUL7/WSQtCFLpWclKkWFuglRGd77rgQSVCf+7r1 yhnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=G+VhwNcwinV04Y/iUbmQmuBk/a75lqlMMGIFzyqu6dg=; fh=oIv/MhmgO5YYbwGbR5FkR35MiBuJfTgy6Df1qOFqBR8=; b=oZ8VbBO1EOsym84C5uBMSGIIcp0kgB9iAfcKogbHS3PodACIAoAqXf86ogwuXkc7iQ c569zx+7V0+dy10FJqfu5I4DMmCsC1tUuaCLKV4CLL5yXdMAhzBeWhMrVM1CPFD6EFLi X21Z64XNjbk0CDJlhts2RaUrFW5rEf963apNVUeV9YmS7XpwhHstQrbhM69WhTNcfDS7 hvBZCInOkTde8YN+v9wh5R0+ZW5wdnlWl5GLdbvJqNDM6Oez75SF3gHdGBhCT676pl6/ y51dH1jmBonhgxyg9HU0AvKisbGkDnglSxGHTHmI+7RlOLzrPekw2yCC6w7Lg5Dy1J5S MiCw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=T0evZWkN; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-183566-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b6290d1948si2749062a91.183.2024.05.20.02.49.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 02:49:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183566-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=T0evZWkN; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-183566-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A7CB5B2207F for ; Mon, 20 May 2024 09:48:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2ED4646444; Mon, 20 May 2024 09:48:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="T0evZWkN" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F3B545949 for ; Mon, 20 May 2024 09:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716198521; cv=none; b=snd2P/1os9REIDkFiw7RYYi4Et0AVmYW42I0zNAkWHJVZeY4Rm6Fzy+h488YInmLFmb/iw965nPduuj5dWBMtdkeDgZjy9jXdKOLO25+Cc1mZzTGc1iITgUoF67XiHu2fBYVwcSX0wJeLQxc4AhwwqSeMCQ5olKfKQvNibVhw84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716198521; c=relaxed/simple; bh=thi7surURGed3HD6kvRIjW8Ud8uvGfTlOLEu6z0HL5s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PWN2k84uETzbCdksz8Ib9SsDT0sv1q9ruZE3par1Yx8Ka+5LafpI+YjFUOb7IBX6SNEYVNBSiEINRqLF2E12KSzGrtyjbeEWSzZ1BaPy97DS0uL2pXzExDOgcrn93dL0VXHhfxHoVgqU3eT5OtftTSIw84yQwYBbPmmwUDrHk7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=T0evZWkN; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716198518; bh=thi7surURGed3HD6kvRIjW8Ud8uvGfTlOLEu6z0HL5s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T0evZWkNvuwzG7GkhUyvVpjzu/Tp912PHnbjefH66ew2QMMzjB9P/iT/4flVzku6y 2LKPBcWyk6wYtH6Sj+TdO2Kpa8ZNGRdbfgog1//5nrNv/wAfM4nuGOPQsbL80ybf4t ZzlM7hPeY7X6BjUZogGHHpGluirIU7sp4kMreEu8AMQICt8JYnZ+8j9/Ic5oZFlHzl tBv5s/jLEaJqWBC4YjgwChwAT00VpDfsfBrJztCnGW2RTsxHgD53TY06SMGquvnbv+ AMNklmv6wk/uTm7pZp/9gRv1P+kNNawvzCNlNzmJSHyxTNBRRtsDDLGLPUWQRyLsyu 1hS8bBAGKlPEg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 82FCA37820CD; Mon, 20 May 2024 09:48:37 +0000 (UTC) Message-ID: <3efcc6c1-054c-444e-abd1-230124964307@collabora.com> Date: Mon, 20 May 2024 11:48:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare() To: Douglas Anderson , Neil Armstrong , Jessica Zhang , Sam Ravnborg Cc: Linus Walleij , Dmitry Baryshkov , Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Shuijing Li , Thomas Zimmermann , Xinlei Lee , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240517213712.3135166-1-dianders@chromium.org> <20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 17/05/24 23:36, Douglas Anderson ha scritto: > The mipi_dsi_dcs_nop() function returns an error but we weren't > checking it in boe_panel_prepare(). Add a check. This is highly > unlikely to matter in practice. If the NOP failed then likely later > MIPI commands would fail too. > > Found by code inspection. > > Fixes: 812562b8d881 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence") > Signed-off-by: Douglas Anderson Reviewed-by: AngeloGioacchino Del Regno