Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2346771lqo; Mon, 20 May 2024 02:59:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWu29r5MKaWg8wszl+6pGWVVt++EUKH+Lztvv51QkxkV8KyQUPzI1vMjBlE64WK8MBKLEbaNQ01Hd7iwvIB4hpmILrANIudI8FRr5fcZg== X-Google-Smtp-Source: AGHT+IFq0Oxq+91GR5J+FYxk397a14Ut75528BqHL4DfDbz4yMVPS/xJjrCo7n1AoaXLwYSEINGR X-Received: by 2002:a05:6808:220f:b0:3c9:6a90:caa4 with SMTP id 5614622812f47-3c997023d43mr37262028b6e.10.1716199147061; Mon, 20 May 2024 02:59:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716199147; cv=pass; d=google.com; s=arc-20160816; b=xMXJLMz7m2iKTYMtnWgUndEdetogsjZwjuQeRzUQtmeHzkk9YUKsomfAERRLDnOQdT ZixvevOYYrhKZRgiEAnIWYKkbNd+JCcDTTZNs/+dB0YoVyMdSOn1OsFBgmO+E47vXxFD so4DRpVlAkPtuYTTH+/Yrs1BVLvTQJIjSXSvvUdEcmGV5pKAR5n7rQe6gl8QhfttzpFn Bjopn2VpxEtfLwiQHrYLYmE6kRMJZVFJgQx/Nr3vJPPtX7m54cskDmrAU1wZE0HfUyI0 m6ys7bcyibmoHPDdnL01rpzPv6RfXZeQlLzueDUbJTeXNp8MdKowVBviGy0bppHS2sQU Uz7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=x9yrCaIzutKq/tugWBnjvw4VFRkOOZ3xTD5wXoVXhiU=; fh=/AAIHU7Nbzx0kL85NmzVEL5zNJVnOSJRyOLWyy292lE=; b=KOIfBVn0h0m3mxWry4BNwzPFP/o02xuG877n8vNlKAX1u1P6DDePv0RQCbicMej8US /F2MaMx46OwF++F3JTvsy40dT+x54rSjd3cao6lWjt+T62O9KfIFqLQ/0rxJxPwTyDO5 qCWYOCs7KvypdmVgY5WV5LpeZ5vvnaWpuP7y7M/7ggAq8TkFDLesKOyN6VXbcufB8a9q MWkS6hwDW+yLxlsBTDDfByZ0vouGI+0TkNHqvG1D2pU9q/fn0sGV+ugGl2pcJ6eVhLu9 LEZfXyfz8IP4nkVfT9sqlO9dHSFPGvTem2WmH3vlUe3fBzV2q0bah0mEah4yaZDZL4H0 ULIQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H5ZEWH+F; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-183573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183573-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-63411530b8esi22319090a12.466.2024.05.20.02.59.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 02:59:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=H5ZEWH+F; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-183573-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183573-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 10867B20979 for ; Mon, 20 May 2024 09:59:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 12CCC48CC7; Mon, 20 May 2024 09:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H5ZEWH+F" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39286481C0; Mon, 20 May 2024 09:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716199133; cv=none; b=LXMEVoBtBEHQsgqfVMPAfdQBfx4agxCL1RMdQpPPCRUjdd5H5jCZqkatuQ6ATeMPd6cMA/YJkobC8AFu8Us1AJpDEaMpWnjycZvngG/RAdRHnFnFynm2UaJfBA0tE6OexX2HaNTQGV/FnY/b0tqTiRXk46KpY1Uj0Fsgg7x/LBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716199133; c=relaxed/simple; bh=5DFkN3Tprj5e+wQJ3KzoBJ39w9B9HhjPq1Ww2oCI7XU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CDNiNOqdRPo5nt/KUH8eFqTe1SMEqEZGALLIrrf2iM3jcnlFTzavB2Jp+4Ni+2CbkVezcdIR3Dimhkb2vOE+CpkLDYUiv9GcEP+5tbYeUIOgKrx+7qgwwYF/dXkdkuJHcOSyun6eezkeukBjTgNBEyLGf8JVg8rY6cQydk/42HE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H5ZEWH+F; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07A6C2BD10; Mon, 20 May 2024 09:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716199132; bh=5DFkN3Tprj5e+wQJ3KzoBJ39w9B9HhjPq1Ww2oCI7XU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H5ZEWH+FyVBQyKjBl17EW/hWdhta5ga3Axflcnb3ea8pRSIpdMydiINrbvIzFf6gV Pd4X1K9g1PsOCWA4qcS41hmozNfh1MiDuyXd/P5XJvhNRXZocPXftY+FCZHuaqjxTZ mRRTbi58jwp97SIK63KGgLd0GqGrehcWYllsJi/RdCJGJ8egfuPo72a/yZpu22NENN lm8XXXCi4bAaSvzOOLalmZQR8t1I1LWeyyc2R4PZu9X6niybtqKJ2YUCIaYccq3cU8 3DBFZKszFnwOE2ABHwnH8J3MVr06OFtzS5A8heeruXRzfwp2exy4KCicw290qp8CRO YgpcVbMurY+Rg== Message-ID: <8947cb3f-39b5-4483-af1d-82d3fa4bb7ad@kernel.org> Date: Mon, 20 May 2024 11:58:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() To: Ryosuke Yasuoka , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, syoshida@redhat.com, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240517020609.476882-1-ryasuoka@redhat.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240517020609.476882-1-ryasuoka@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2024 04:06, Ryosuke Yasuoka wrote: > When nci_rx_work() receives a zero-length payload packet, it should not > discard the packet and exit the loop. Instead, it should continue > processing subsequent packets. > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Reported-by: Ryosuke Yasuoka That's not a valid tag here. Every bug we find - like hundreds of my commits - is reported by us... Drop the tag. Best regards, Krzysztof