Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2360403lqo; Mon, 20 May 2024 03:29:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXIXJvx9EAflBZhXrylLXnWQN5qAHpBH0I4wpZFPyZUIqtdTXgUNavFFJp9s7xEvLc8bkq1exOeWNzpFLoagrUEKZU2MyxKNEbtBnxNZg== X-Google-Smtp-Source: AGHT+IEH1rapzhGCdnkv1b7K9MDOfhEVF6nXYzzFAg8UMhEuEyk3QMUXkpJqY71CkQXna56+SMxH X-Received: by 2002:a05:6a00:21c6:b0:6f4:9fc7:daf2 with SMTP id d2e1a72fcca58-6f4e02a5f45mr33544276b3a.7.1716200971741; Mon, 20 May 2024 03:29:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716200971; cv=pass; d=google.com; s=arc-20160816; b=b8Hgavm7BWjSunpbhjZ+3nz9T8PWUsdHrab7J19NPQ0OsW3G7xdsEy/pimWTyUt/Zt VrDzMK7xYHZvsZj82SIw5snGXmDLMILAgI2x9iWx3dYBRACuXbXNEk9z0zFXkk/JX/sd wloBHDaULGMGV/LQZ1XqeleQlsEFjyoFVZ34q1ylrk5CpjWmriZximxXqN4o4MuWTCpF 75Fh30Q8L7Mz4Xx+Naxmmk8HZy+P85e2NKq8a8PIFXt4tTXKZ7tdC7MR+aqL/vL2fkSy kPXIoM67KpbHi/+zNk4yI9P3fwFZlhQ2KknStxry74zG+rpMPBCR6CJ7kz8B4Z2Hgul+ 4YDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=p5BgnpxvIdvwCUBBX92qJk66NJ04cMwQMD5QktP8CYA=; fh=/iCR2L84TNyZRkxgkOP72FGpME3THMAMek30F/9PSQs=; b=uoAj4nh5TY1XXgnTk6mYueJ/+JNrwGDspTMwMrNYLM6FSumY27kgAZ5pYrwi94vI6B cood4LOaGbu3AG5TSKNuOKCjWWnsahgtUODauep4pfJoyionnko9PeXznoXT7nd93zQu mw2CbPX+ga/Mh1wJSonSxpq4x6x6bBAVAd7FI4J+E3AaxzsvqvAA9z6McTX334+aaLDQ UV1kFDPAIUc02//mu0YKkl4NpOmmePiCTiW0NRgVQq2OCGMyH7fwZA2Qv1EVaXYfkXTN TcsbjbwOtSIRd/I1TD0zNzIJJ+vlk+wJksZBgczqjjEd9WjDfP4vCBvnU/IdRxjk0szM Fy1g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DTBY7NOn; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4d2aeee36si168545b3a.159.2024.05.20.03.29.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 03:29:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DTBY7NOn; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-183606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183606-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D7076B21DDF for ; Mon, 20 May 2024 10:29:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EEBFB50A72; Mon, 20 May 2024 10:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DTBY7NOn" Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29DD94F5E6 for ; Mon, 20 May 2024 10:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716200956; cv=none; b=R3YZg5HEa81idK59SnqmYIVqMVswEhMPAxFE9vZi4z9NtGuZe12fBdvybpzFBU9sGgm2Obb7c7Q9f1MdgwwiB4mZgjWphGrlnhEJckobxKzizkexPk8RZiQexpVK1Hc3EuShLDUTLIVGxo54XsZNNjSk1CmYkYCbEhTuqBuvVoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716200956; c=relaxed/simple; bh=w2v+Tu34CMn7RKVYb55dqY247JQr2d92gD+z+UlCjOE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UCmNuITCbspKR1U1BrlcVhfD1MAce7da6Ikn+D/aWNH/TkUmi8K+8jhL6kdyFES8XIJKLFPJHZZF4I9HvCz++vOE9aWB9w+X6aRjj17yfEDu+hD4hznsL1AmqMsAfYYvzBmhsNwpmTp3agKLpnDIyhdgkKpkk7wUFgpv54TNdQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DTBY7NOn; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52389c1308dso3399398e87.3 for ; Mon, 20 May 2024 03:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716200951; x=1716805751; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p5BgnpxvIdvwCUBBX92qJk66NJ04cMwQMD5QktP8CYA=; b=DTBY7NOnJxKRUw6I3XYcOttLl/M+TCdOKfTfnsenrf3CWER467UhAsTmrtVYkMLZ9J P4Gii10ZWV/oyU9/8BvMXv/cE6IPWsBLXCsg+ioQCwq7EALqV5b9/iIX1OCUzJkHEECa TNe2d9LuJ8IOo3IJP9KuHI9HC/eGvBQfloHRxRvRtFYeyDJ6xLb5uqcoE7L9C3tj6WUf KM9eBbexDaVwcooLrR5c4/hCDhoG2efeJe+By7/vTKA98MEOhjMItppKP/3XH/zQOdhv k2naSeL0r6m16LEReEHgT5IPZ5gCNEUq2N+NKM2VmtmE7WBwjrfXXzd280roa4JAsKOA ssOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716200951; x=1716805751; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p5BgnpxvIdvwCUBBX92qJk66NJ04cMwQMD5QktP8CYA=; b=wTWt/qF+Z/5byokeQ3rJPnrEAY2cFQijHr5FK28GKYCaFEeun7kqjjl92z1QiX3s3Z /QCYrs0fAWB4SM1OFJKfKIyWqudYsIy48cMC6G4dDi+F6djOLJ2VXnr/WQ7FMAJS+hvE hrnPRwdZyzsYiR9l/gusv8sHP5SnEWM6MHiNQ8T5GdchM9GSrzF1cs7M57t878j+QsBV gMkEnmNo7nLiYGppjUWPlyVUrZFcqvIHOnTsjmCaGX2sD20gFzEN49Spf/0MfOSlh6WB UhaJTrBP3x4sDiSLpbMVc3aQKSzjJdoRUxfU6Jbtyx5i0Kg1xMuixLeoyuRrOrMIxTfE OHdw== X-Forwarded-Encrypted: i=1; AJvYcCXSiJfezB/uerUd11k29uuYZxE4HWvleSV20FkJpXNXuYazdHQRAAC0M/kZEg4YI/J/ZyDAZMq+kvpHXrxdYtlOrq1/9mKN1h3UFcOp X-Gm-Message-State: AOJu0YyTULwW0FgJOiUUkDw8ze5aHUNjdtwyAwjLyTPXXkvStNTa1gtU 3VXxE5Mde9prm0CUXkuNH7mmlD0bh46E2DBIw1dsBSNL40FRzLM2iuakqX+uOuE= X-Received: by 2002:a05:6512:459:b0:516:d0e3:9275 with SMTP id 2adb3069b0e04-5220fc735e5mr16898943e87.11.1716200951305; Mon, 20 May 2024 03:29:11 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyyykxt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::227]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f38d33dfsm4221651e87.139.2024.05.20.03.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 03:29:10 -0700 (PDT) Date: Mon, 20 May 2024 13:29:08 +0300 From: Dmitry Baryshkov To: Christophe JAILLET Cc: Sumit Semwal , Caleb Connolly , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Vinod Koul , Marijn Suijten , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Caleb Connolly , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/panel: lg-sw43408: Fix an error handling path in sw43408_probe() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 20, 2024 at 11:34:31AM +0200, Christophe JAILLET wrote: > If mipi_dsi_attach() fails, we must undo the drm_panel_add() call hidden in > sw43408_add(), as already done in the remove function. > > Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") > Signed-off-by: Christophe JAILLET > --- > Compile tested only > --- > drivers/gpu/drm/panel/panel-lg-sw43408.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry