Received-SPF: pass (google.com: domain of linux-kernel+bounces-183614-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 20 May 2024 13:35:15 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, 
	maarten.lankhorst@linux.intel.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct
 'bridge_init'
Message-ID: <la43b5ra7aziiv7dwt4o5zha3px7jarfmk45dwsf24qn6pgcre@pcmcsicjdrus>
References: <20240517232427.230709-1-linux@treblig.org>
 <6tfxkc3foarpfuo6viwmsm4e2ujxjmhpqsku37d4ov6ppufpjr@byrbjs7srqri>
 <ZkqAoG9ZGg0_dC-9@gallifrey>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZkqAoG9ZGg0_dC-9@gallifrey>

On Sun, May 19, 2024 at 10:43:44PM +0000, Dr. David Alan Gilbert wrote:
> * Dmitry Baryshkov (dmitry.baryshkov@linaro.org) wrote:
> > On Sat, May 18, 2024 at 12:24:27AM +0100, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > 'bridge_init' is unused, I think following:
> > > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model")
> > > (which is where a git --follow finds it)
> > > Remove it.
> > 
> > Please rephrase the commit message following guidelines in
> > Documentation/process. Use Fixes tags if suitable.
> 
> I specifically don't want to use Fixes in these set because
> there's no need for someone to backport this to older
> kernels that use the original, and many backporters
> use 'Fixes' as an automated means to find stuff they should
> backport.
> 
> Other than that, is there something specific you think I've
> missed?

It's not about missing things. It's about a way it is written.
Consider something like:

The commit aaaaaaa ("drm/bridge: foo bar") has dropped all the users of
the struct bridge_init from the exynos_dp_core, while retainng unused
structure definition. Later on the driver was reworked and the
definition migrated to the analogix_dp driver. Remove unused struct
bridge_init definition.

> 
> (I'm also purposely being less certain here, because --follow
> is showing it in a ptn3460 and I don't quite follow
> why that changes it here).

The mentioned commit is a correct one. Historically exynos_dp_core had
been creating the ptn3460 bridge manually. Later on this was fixed in
the ptn3640 driver and the code was dropped from exynos_dp_core.

> 
> Dave
> 
> > 
> > > 
> > > Build tested.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > > ---
> > >  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > > index df9370e0ff23..1e03f3525a92 100644
> > > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> > > @@ -36,11 +36,6 @@
> > >  
> > >  static const bool verify_fast_training;
> > >  
> > > -struct bridge_init {
> > > -	struct i2c_client *client;
> > > -	struct device_node *node;
> > > -};
> > > -
> > >  static int analogix_dp_init_dp(struct analogix_dp_device *dp)
> > >  {
> > >  	int ret;
> > > -- 
> > > 2.45.1
> > > 
> > 
> > -- 
> > With best wishes
> > Dmitry
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/

-- 
With best wishes
Dmitry