Received-SPF: pass (google.com: domain of linux-kernel+bounces-183548-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 20 May 2024 12:38:55 +0300 (EEST)
To: Markus Elfring <Markus.Elfring@web.de>
cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>, 
    platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org, 
    Hans de Goede <hdegoede@redhat.com>, 
    Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, 
    Zhang Rui <rui.zhang@intel.com>, LKML <linux-kernel@vger.kernel.org>, 
    Dan Carpenter <dan.carpenter@linaro.org>, 
    Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2] platform/x86: ISST: fix use-after-free in
 tpmi_sst_dev_remove()
In-Reply-To: <d5203ff5-8ed4-48ea-8e58-a2e6680b0542@web.de>
Message-ID: <6d1bf351-77cc-7fe9-2d62-8bd99789e4f1@linux.intel.com>
References: <20240517144946.289615-1-harshit.m.mogalapalli@oracle.com> <d5203ff5-8ed4-48ea-8e58-a2e6680b0542@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-129071608-1716197769=:5522"
Content-ID: <2d9bfb7c-a268-9795-b90f-6138f88f9a83@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-129071608-1716197769=:5522
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <68320c4c-2329-261b-89c9-f624e9d11f16@linux.intel.com>

On Sat, 18 May 2024, Markus Elfring wrote:

> =E2=80=A6
> > Fix this by reordering the kfree() post the dereference.
>=20
> Would a wording approach (like the following) be a bit nicer?
>=20
>    Move a kfree() call behind an assignment statement in the affected if =
branch.

No, the suggested wording would make it less precise ("post the=20
dereference" -> "behind an assignment") and also tries to tell pointless=20
things about the location in the codei that is visible in the patch itself.

--=20
 i.

> > v1->v2: Add R.B from Hans and fix commit message wrapping to 75 chars.
> > This is found by smatch and only compile tested.
>=20
> * Can it occasionally be nicer to use an enumeration also for
>   version descriptions?
>=20
> * Is it helpful to separate additional comments by blank lines?
>=20
>=20
> > ---
> >  drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +-
>=20
> How do you think about to omit a repeated marker line here?
>=20
> Regards,
> Markus
>=20
--8323328-129071608-1716197769=:5522--