Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2427453lqo; Mon, 20 May 2024 05:52:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+yXqTSDaL/n5hbbwaGU5TyQk59r3EAQ/1a47l6uY8ODGNEtTavdjuT+fnK70m+TSL2IflqtqQj5U9tIqWXs5m/tS8wfxkFnMb+SEgHQ== X-Google-Smtp-Source: AGHT+IH78WQ1VT+4JJfPswK3OFfQRKbnv6VI6UcLOwZlLTrvvxtZjw5Nw3kuRV5umcyFL9C4bUpQ X-Received: by 2002:a05:6a21:819f:b0:1af:d057:af96 with SMTP id adf61e73a8af0-1b1ca3e9f77mr7677598637.13.1716209542607; Mon, 20 May 2024 05:52:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716209542; cv=pass; d=google.com; s=arc-20160816; b=nyNSqolYI2LZvnz6n1t2kK+yK8d++4KelLt4QjWxsO/uUhWqqhvbYFAiGzJpR3/AKt /XPG8HSId6SchLh9vmloiNDjkVbjZELX5a35FLDhHD3lOUwVlqJf0fhCtMkLG124yYYR wql3fwxKA5ztAvn4IoTVmd80BorIPLDg/YM9UHZz1iCi9s0xCa3IbP9vvA6ZH7OQT1kg RuUsglPXiU1G5AETnATQ/DPMtqAJ/Emhev2zXaFDpMSA2ea/tKhHdgHgoquqMWihZu1a oJODnPNsVDNzfVdWY/eWXVAGt7VfyQUZAlvCngJp+PbByV0SrggWzZYvm634k/5fAgil wwMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=A6+9qvcDGnLQuaFAHT2Q0e0l4H4wa+c0ZJfQCfwsSgQ=; fh=omdpUpX1xCh6qMry4IYyxSMcZPKyQFzkCpjfUFSbgqY=; b=ALcwq77ulYVIUpn32IEw1nXzxRBfZO5y1zD8+Xh+xUpDKPzprQ7+a+i2I0sr3WNHd1 FauiFsXYV0hFOcRnHc4dhQeXBuuzK1Usecj/BcYCskT0gJCSAMsGv23ox9NCp5DSqsJf s+9XhTDS56GeEMPRgq0IvjfdkoC0iIkcMrZHdkC50C1qJ/JarggR/9szpcgC5H1xOrVT LWPRGG1m01JfNwqhXFgss3H8zB3uq2PEKGGrqDI0XCfiIPgAcOPY30Cg+cmHp84F9Em3 nUU0pRIHB/IxG+jmFhnsVKLgG+wFq6VK7PBEyZ8ac2Vy23puLMSfjk4PYsgLK73/z0VE ZZpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=IhqlqkS6; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-183752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183752-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-634103f5676si19229125a12.366.2024.05.20.05.52.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 05:52:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=IhqlqkS6; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-183752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183752-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E9042B21DB0 for ; Mon, 20 May 2024 12:39:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B9525644B; Mon, 20 May 2024 12:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="IhqlqkS6" Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC718535BF for ; Mon, 20 May 2024 12:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716208755; cv=none; b=P9oMKFqXxdwWTlBIArWOUkYVvfwWXNanx43GTlZWB6LvM+FZKUlrEPm0y7PZICASYseontUUSHixUpbyr5U3LeN731Ivkb9x1DAP8sr6YtwG0lA2z8o0MEhbtNQFiY8r/bIxR6Zcd3Bpb5EeHEBzpDsYT50EzhtXawXBjiWvHmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716208755; c=relaxed/simple; bh=hiqO6nf/twieLGm1SVLytWK3tuB7lTlsoCNchPnguGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dia4DUmy9kp1VX6zpBWvMHJSw+ytPW4QEWO+NdsLIVyTQzOburEJX4Goqng7ubWarLWAm8W0Tsxulr8QAFDqjR/fInFX8kwwPUl3DpIgZCjVmmrNrDkIj9qtJg7/fnnTQYqz+5gcaMYLtjgblfeHY5KoWico3cJ78hFaDM20vD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=IhqlqkS6; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1f30a419500so405865ad.0 for ; Mon, 20 May 2024 05:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1716208752; x=1716813552; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A6+9qvcDGnLQuaFAHT2Q0e0l4H4wa+c0ZJfQCfwsSgQ=; b=IhqlqkS6QvSIgnh5lQM7ljtxt/tX+NoudSd9uraOVsg7a9XN2OhxBeLW6ou9Xz8ALk cbCffwCGaVjXDj7lmxVytFlGHzeQeGBd90ocSudcXcMB2IaSqPT0D8barRFKOdiTOSQm TjBz1Hzmj2Wzdhmv9ZXG96RQo4dHROUgvvCpMNhn49An8jUfPJILC+vsMaTj2IePcSbb gtftKeTNXMp5ESPlmoL7SVvk1aiURNeSUFJRz/kebczx5puYVWyO5bNPkN0J7nYI/fuK BnBXoIklYIicjSGNSX/6NhE/NZjiEBMC3V0G1I1Vnzy0StqHrp+ZYRv8HVD5yl+Wurj6 zuUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716208752; x=1716813552; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A6+9qvcDGnLQuaFAHT2Q0e0l4H4wa+c0ZJfQCfwsSgQ=; b=wIXeXVCkURD6WJ6570wKtdnOmZjV1SnpBnS6AiUx/E+7ZtXmlsowDYs5ydu+g3i9G1 mnN0f+ZZJHcOI+xYK6e6Be5P/Ju8HXoAF5lQSSNNiYY6n4t4MZ7AvkfmkhCqAiOYNnrb nowOaLRSyi//YG4CpzSu5WJms0st3OVFUjkMz6bJCmCuAD79V0Wu6w5bf91JCP0Daw1D 7YQ8+7p8/GmHywGnzMShKYl/MsNcdqy0u2JvHb8XJo7aYu7f9DFIR0SwJU/WEpCadE4p 5/Li4SjrU4J8EmVPjAsPZvgRa7E+PlHcr7wk5ZnhgpUeVIQhZesHW2unaL5CrpW0oL3p f3Fw== X-Forwarded-Encrypted: i=1; AJvYcCXPsFsyQuQUV0MqVdsbwKyF2yy6QloYZxdOIY5HLP2UPafwuCXWHPJ/6teb0glt1LNtDu942QaNzGP1X6mbKfxiXLmUU3OWLPGL6Ikh X-Gm-Message-State: AOJu0Ywx6o0sXQT+L+Gas32h+PoI71elqMlps4QECPzaYM6QWtaPXjXw 9YtBmW9xzjd13NhAICWbFJ5kIBJwksvrxJJAhIZAeRFwmUNWELcJPko/z25vGRk= X-Received: by 2002:a17:902:ea0f:b0:1f2:f12e:27f6 with SMTP id d9443c01a7336-1f2f12e3103mr60545005ad.0.1716208752241; Mon, 20 May 2024 05:39:12 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f30664fe46sm11260135ad.225.2024.05.20.05.39.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 05:39:11 -0700 (PDT) Message-ID: Date: Mon, 20 May 2024 06:39:10 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] signalfd: drop an obsolete comment To: Fedor Pchelkin , Christian Brauner Cc: Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org References: <20240520090819.76342-1-pchelkin@ispras.ru> <20240520090819.76342-2-pchelkin@ispras.ru> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240520090819.76342-2-pchelkin@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/20/24 3:08 AM, Fedor Pchelkin wrote: > Commit fbe38120eb1d ("signalfd: convert to ->read_iter()") removed the > call to anon_inode_getfd() by splitting fd setup into two parts. Drop the > comment referencing the internal details of that function. Reviewed-by: Jens Axboe -- Jens Axboe