Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2432999lqo; Mon, 20 May 2024 06:02:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVQKnLjYDdwkntb7GOteMqpoM0yxI00szru6LRzY6O5sgAHQhOFxYNY/84HzEb7bHehFEJ6cwuVkQ9DNgMpVxvK1llRF7MUhz9HWkn9tQ== X-Google-Smtp-Source: AGHT+IEorWuUQw9RUmKUdCAGy5RuJ2hdJE/diblwHcj0dEclLaH7WeDqwlu9ydqak+q+viULOxe5 X-Received: by 2002:a05:6a21:788e:b0:1a7:7358:f108 with SMTP id adf61e73a8af0-1afde0b5c64mr32806890637.24.1716210156827; Mon, 20 May 2024 06:02:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716210156; cv=pass; d=google.com; s=arc-20160816; b=Q/g83vyoRmgK5v4qIxVwVdFnB92CllmxQZZHnrU0i1NJqa64gsnRXXaZjbiV8IlfV5 /G/5/qzvXZI76kyQO95q+qY5WaJ9tCpkTqYw4jTCOwkUUPU7mf6m7mUkHeMvRnfNMlc3 4fCagxXQDnkdLVl2RlttNQLspW655InCyUp7AUWGqR/9oqzvjnB3F1BcRHTxrpXU252Y pOG2KSUR3NV7otMNqVhyJTcprHbBiP2UitBdBBJmS7EJLwN7QZTt932cx5hJ3ndtgBha HgF53R4Gmfk8rofj1fIRMVREGm2IgFL6eRGZmhEORp9owpySFIG6jTnYys7SMGlGk4em M14Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YYDw7VEWVcEkPk0Wu8QEJ6CQBSmQxXFl8+dCB+LEctc=; fh=3yLBqrvUt26jo7SOuxRSKRhtc/wP0B/UPnZjWXJyuck=; b=Qt4dRCj10kosdyJFqWTH6bCXEdPt5FqZq/xxM97m0a2DmsgfYrM3pw9aRKDWMDoZ+g MU/vVJORJQx8L3xKy1ZlrNJDeMP4DXRDXdwN9BXNCmTm+c20BRN70Os1EjODecUEPyXf 9eW1bBtFLaCSvF5O4qmxqptA8mE9BNajJ/+gGCY5Ht3m0MI92a7hBpL1coGeIPn1KUyV vUPaUpSh8unQImrjPTHHUppHtMA38FYlEnt0DLxevL8v92vRq36NDSiAOTx4vM+oKNpK 4vD71bRAMjewAj+C9FiW9PcUGCsbuz1nijDCoSKhpdM5wld8a04c8giEi3Wqjp01ZURL kr2A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F2N4F5ja; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-183636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-65c6bba52f5si6777236a12.341.2024.05.20.06.02.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 06:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-183636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=F2N4F5ja; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-183636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-183636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 01EB5B21903 for ; Mon, 20 May 2024 11:02:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD79751C54; Mon, 20 May 2024 11:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="F2N4F5ja" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9822C14AA9; Mon, 20 May 2024 11:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716202937; cv=none; b=U14XXhs83mYrzZEErI9eVXXpAp7Qiq+mjOlf16rYjSkNnDe7BjwHWwK3osn/8zOPyJVEtNncCVwwGh6hwF/iL3E6EC4sLk5zWv29+pWDuWOnNV+T2zfuYcgHJ3/J91mJZTkMscVWKcbc2gt8PPZ3POEuE9tMZvx0PVdRxDgx370= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716202937; c=relaxed/simple; bh=1Ukz21FCOyFvuXyrhqtkSqqNSZCXa2QKyEzhl885guw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dEfM+C01JeGmfNhYpRpccs9MQWbvmSDKe8+fPTUHYM4LY7aRan3CwadvbL+kN39eIbvoI9cKRycH853MQrSl1g7+vDiklMEVu/IMF5CThtOhnIiXJBYcZ5D5NCZhubw5dxHZNCzXA4Kak4zl326M8HEZRpN85/X1c4gaR4kNcWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=F2N4F5ja; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716202936; x=1747738936; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1Ukz21FCOyFvuXyrhqtkSqqNSZCXa2QKyEzhl885guw=; b=F2N4F5ja/LSXnF0UQBtBal4fj66ysdjj1rd/Z+TPZBor1xXchGQjfeUJ G7LVG3a38X6IXbucNIEoRgqlDBAwcISLtlV3cj28iYURTMgkBWvyLiW76 2pGASezRlPbgX3P2hMPJnM9t2/9NquchGcX2vaJAp0cbLbXweU6j/2aLq LkY7JOlUYqi66KHB3Pvo5o+77vXC65jJNYcdpbtckw+SBYh49Ci9DVOiF BTT9OAhk1x1pU4BpE2AF4SBZ5J7/LV82shJ7IOhED5n3Q6u+MSeYIGAHw y2yTYurHCEbKIS4P/4WJik9zh/ooxXejvQIOjsC2CeNjM8pSqokgontOa Q==; X-CSE-ConnectionGUID: UecCH5eTTMq6SjW6Gw6m8A== X-CSE-MsgGUID: WoEE36v7SuCxKaXJpAoO8g== X-IronPort-AV: E=McAfee;i="6600,9927,11077"; a="12166588" X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208";a="12166588" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 04:02:15 -0700 X-CSE-ConnectionGUID: 56OFHfI9S2+J4epdvHTpCA== X-CSE-MsgGUID: axccaSldRzSG/bBV2SDGQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,174,1712646000"; d="scan'208";a="32358748" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa010.jf.intel.com with ESMTP; 20 May 2024 04:02:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 5A1242AD; Mon, 20 May 2024 14:02:09 +0300 (EEST) Date: Mon, 20 May 2024 14:02:09 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Sean Christopherson , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Josh Poimboeuf , Peter Zijlstra , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH 16/20] x86/tdx: Convert VP_INFO tdcall to use new TDCALL_5() macro Message-ID: <4fl6wyclb3kmduupljfqlqfjw64qtexdluwcu7vmumsq6ff4rs@ottpuuold45w> References: <20240517141938.4177174-1-kirill.shutemov@linux.intel.com> <20240517141938.4177174-17-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 17, 2024 at 08:57:10AM -0700, Dave Hansen wrote: > On 5/17/24 07:19, Kirill A. Shutemov wrote: > > - /* > > - * TDINFO TDX module call is used to get the TD execution environment > > - * information like GPA width, number of available vcpus, debug mode > > - * information, etc. More details about the ABI can be found in TDX > > - * Guest-Host-Communication Interface (GHCI), section 2.4.2 TDCALL > > - * [TDG.VP.INFO]. > > - */ > > - tdcall(TDG_VP_INFO, &args); > > + tdg_vp_info(&gpa_width, &td_attr); > > Why is the comment going away? By mistake. Will fix. -- Kiryl Shutsemau / Kirill A. Shutemov