Received-SPF: pass (google.com: domain of linux-kernel+bounces-183771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 20 May 2024 15:02:21 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= <SkyLake.Huang@mediatek.com>
Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"dqfext@gmail.com" <dqfext@gmail.com>,
	Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= <steven.liu@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"daniel@makrotopia.org" <daniel@makrotopia.org>,
	"angelogioacchino.delregno@collabora.com" <angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next v2 5/5] net: phy: add driver for built-in 2.5G
 ethernet PHY on MT7988
Message-ID: <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch>
References: <20240517102908.12079-1-SkyLake.Huang@mediatek.com>
 <20240517102908.12079-6-SkyLake.Huang@mediatek.com>
 <cc0f67de-171e-45e1-90d9-b6b40ec71827@lunn.ch>
 <283c893aa17837e7189a852af4f88662cda5536f.camel@mediatek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <283c893aa17837e7189a852af4f88662cda5536f.camel@mediatek.com>

> > Is there a version available anywhere for the firmware?
> > 
> Currently, I use "$md5sum /lib/firmware/mediatek/mt7988/i2p5ge-phy-
> pmb.bin" command to check version.

An md5sum is not really a version. How do you tell if one md5sum is
newer or older than another?

Is there is an MDIO register you can read to get the version? Or a
version in a header in the firmware file?

> > > +static int mt798x_2p5ge_phy_get_features(struct phy_device
> > *phydev)
> > > +{
> > > +int ret;
> > > +
> > > +ret = genphy_c45_pma_read_abilities(phydev);
> > > +if (ret)
> > > +return ret;
> > > +
> > > +/* We don't support HDX at MAC layer on mt7988.
> > 
> > That is a MAC limitation, so it should be the MAC which disables
> > this,
> > not the Phy.
> > 
> Actually this phy is strictly binded to (XFI)MAC on this platform.
> So I directly disable HDX feature of PHY.

Sorry, i don't follow your answer:

Can the PHY do half duplex?
Can the MAC do half duplex?

The part which cannot do half-duplex should be the part which disables
half-duplex.

You should be able to take any vendors MAC and any vendors PHY and put
them together, if they have the same MII interface. Say this PHY does
support half duplex. And some other vendors MAC supports half
duplex. We want it to work.

	Andrew