Received-SPF: pass (google.com: domain of linux-kernel+bounces-183801-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 20 May 2024 15:41:30 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: grygorii tertychnyi <grembeter@gmail.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>,
	bsp-development.geo@leica-geosystems.com, linux-i2c@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Peter Korsgaard <peter@korsgaard.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled
Message-ID: <a42d75ad-8065-49f0-906a-c8ae3761457c@lunn.ch>
References: <20240517191000.11390-1-grygorii.tertychnyi@leica-geosystems.com>
 <6eee1069-81ae-495a-850f-7f526006db8b@web.de>
 <CAGFuAuyXhBT8Nkvz5qN8iejeoHMFmx1b86tTNmpVfQ2xqjMtLw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAGFuAuyXhBT8Nkvz5qN8iejeoHMFmx1b86tTNmpVfQ2xqjMtLw@mail.gmail.com>

On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote:
> On Sun, May 19, 2024 at 7:25 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> >
> > …
> > > Sometimes it causes failure for the very first message transfer, …
> >
> > Does such an information indicate the need for the tag “Fixes”?
> 
> I'm not sure: the original initialization order was introduced by the
> very first commit
> 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller").

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

  It fixes a problem like an oops, a hang, data corruption, a real
  security issue, a hardware quirk, a build error (but not for things
  marked CONFIG_BROKEN), or some “oh, that’s not good” issue.

Your description of the very first message transfer failing sounds
like a data corruption? Using the commit which adds the driver is also
fine, some bugs have been there all the time.

Remember to add a

Cc: stable@vger.kernel.org

    Andrew