Received-SPF: pass (google.com: domain of linux-kernel+bounces-183824-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6da2ddfb-02f3-43a7-89f4-60d1613dd5a4@web.de>
Date: Mon, 20 May 2024 16:16:24 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: KVM: SEV: Fix unused variable in guest request handling
To: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>,
 Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-coco@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
 Sean Christopherson <seanjc@google.com>
References: <20240513181928.720979-1-michael.roth@amd.com>
 <76413d53-4572-4a38-baff-8b01f6179c8e@web.de>
 <cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com>
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:VuoImDyM+jw=;lCZXNa4RMjhVsyhrxwbpcvYzk6h
 4Y//926hKszc/v2JHc9lTXy8ZcXvqD/zRzO9E6V5cVAUHuAHEeprVfK4YsX1VE5w7eSfA67tY
 r6pzOCfpdHQtGnKQY/7UcXoNw83vK4Ee9ypZjtE4HKyabsUIy+2kfAnrwSsmX74GdW0h3iZDT
 RNtkE4CKdAQzQw2S/n7q93w68U7L9xRAqVuXRXG342u/n44ucZkh1IUiFFh8jkGoqWRNJu0x0
 DFPwfBTYrdsxKhRsbEwrDW2d6lTM9YVVy4MWXqv1Jn+wiCYay2vo/W0QwS+2zsqZbo4yLCYtM
 IghiCezqP2iA8p6s65Rp9Qs8/vXwSBI27Lr4tFf6Vo+VMWPiRgSLl73IkPB/4uWscGvX76GAU
 6TVigxZtKb441qG455VM9WZixUa8RPfRFq7xTjl99X7k7ZTI3pXJtqk6pwukNlKFhHgf7riCh
 ZeyVhEGsWczWyW2QIl75lApFsI3IjN9kziJYWhoPm4A3LA7LdgJRCkIfyykn6tUXULgFItiKq
 unOBaT3lzABdioswZo4xDgEN8iOYD3BAWHY1zCPyLSiH1ZdcJsiW6oggpzRUCE6XP1TGUtKM4
 153Gp1gGb+Awj4DPfiLvDf3rv7PaLVISK96AmVRNInGqJQY0l1l/02sfujmkkGJgFiE2+4MUq
 Acl76rfdjY9wmF5ImMrHxkVaKHmIgiuAdlT7Bi8wpc6rFxHSznyvWNrgHi1S4LOBMhCdn6z/P
 vAfWjtcLlvtByNSv7GF+/GGxWgtXajdTxRfmuvwBM+QYwMiYgIf8pgaNi26mSLD8ckAgPBAOz
 o4EWEhYylzmk0q3isHgJ7dtk2MBzXtL5tBo9OvrWQ6ygU=

>>> The variable 'sev' is assigned, but never used. Remove it.
>> Would it be a bit nicer to use the word =E2=80=9COmit=E2=80=9D instead =
of =E2=80=9CFix=E2=80=9D
>> in the summary phrase?
>
>
> I can find many instances of "Fix unused variable" in the history of the
> kernel:
=E2=80=A6
> but not a single "Omit unused variable" commit.

Some implementation details were fixed somehow because of a warning or err=
or message.
You would probably like to point the desire out in your summary phrase
to get rid of another bit of redundant source code.

Were any analysis tools involved in the discovery of corresponding change =
possibilities?

Regards,
Markus