Received-SPF: pass (google.com: domain of linux-kernel+bounces-183835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fae7fd93-27b7-4f94-964b-9c909f85f2fe@amd.com>
Date: Mon, 20 May 2024 09:25:16 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
To: Peter Newman <peternewman@google.com>,
 Reinette Chatre <reinette.chatre@intel.com>
Cc: corbet@lwn.net, fenghua.yu@intel.com, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
 hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org, tj@kernel.org,
 peterz@infradead.org, yanjiewtw@gmail.com, kim.phillips@amd.com,
 lukas.bulwahn@gmail.com, seanjc@google.com, jmattson@google.com,
 leitao@debian.org, jpoimboe@kernel.org, rick.p.edgecombe@intel.com,
 kirill.shutemov@linux.intel.com, jithu.joseph@intel.com,
 kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
 james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <CALPaoCjZ3oLdKymJjASt0aqtd0GGOme7LavvYOtPYTb_rA-mYQ@mail.gmail.com>
 <b35dc4e9-7e8b-42ed-9a51-ae50d521cf4b@amd.com>
 <CALPaoChxYoJx8eR48EkSKf-hu2p2myQJLZEhj_Pq6O4R15-=5A@mail.gmail.com>
 <6edffe1b-e9a9-4995-8172-353efc189666@amd.com>
 <ab2a6a4b-3740-47c6-9443-e6bb7a0c1adb@intel.com>
 <CALPaoCiYFKeASPMDwzzaHLw4JiMtBB6DTyVPgt0Voe3c3Tav_A@mail.gmail.com>
 <b725e4ca-8602-eb26-9d47-914526621f52@amd.com>
 <CALPaoCiu2_UHyGjsyitz28BL1N93TSn28E1r-6nhXg--bzmU+Q@mail.gmail.com>
 <d7f3c5b1-c39d-4c66-92c3-5b096b9e0579@intel.com>
 <CALPaoCiJ9ELXkij-zsAhxC1hx8UUR+KMPJH6i8c8AT6_mtXs+Q@mail.gmail.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <CALPaoCiJ9ELXkij-zsAhxC1hx8UUR+KMPJH6i8c8AT6_mtXs+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnpxNnB1NHNMUDB0eXQrZVM1eUZ2Wko2bjRBelFrZ2Y5bkgvYzl6NU5lUXpl?=
 =?utf-8?B?blRYZ0dOcWZoOFhBNEdZa2hWL2d2VjhsenBwdG0rc0RVZFRGNWNLNHRSenNS?=
 =?utf-8?B?YnRHanNqSDMxT2pjaitxS29FVXVXbUZnTHJKTytGL0JvWGdCU2RmVlpabnpX?=
 =?utf-8?B?UzdxM3lrTkhsL0dhRGsxS0l2REZ2K3BiUUxjSllrRHdTbStrN1l0OVVXYzFN?=
 =?utf-8?B?RldYRTViVUp4RFRYSW9rQkNlaWF6RVlpWlg2ZVluOU5OZzYzbEp3K3VaUWVC?=
 =?utf-8?B?Z0FCZURyTkk0OFlaUTJPanN3NStUVFppcE1FM0ZZOWE4ZEUrelUrYWI5cjFB?=
 =?utf-8?B?NzR5Y1dwQVJvRXRtUGdYemZYK0xwTmh2K3J2N0JqdUJJdkpXMEtZMXdiQi9s?=
 =?utf-8?B?Y1lJeEk2eVQ2NWorM0o4SkozbVFFbGtUV2RyNWg5R0pGMlU0YmdzbHpyY0R6?=
 =?utf-8?B?cFl4VVcwUUR4NXJULzRKVFRES1ZSRlJFdzRQKzhvM2pCMnFUQ3duMXNWOEkw?=
 =?utf-8?B?UkRNcEREeU8zYmdIdk9LdUNiWnJZaStOeWM2ODZ4Nk9wNi9Ddy9WbTJ3WTMz?=
 =?utf-8?B?YU4xdHQ5aStuZ09sbEx5dCsxbm92WHF1MXhpZ0dwaXd6UUFCa21UeFZCMHAx?=
 =?utf-8?B?QUNOam44WmVsWmVTNTNhdGtrU2JJOFNvVDlBT2lobVZ6Tk93QkpaSXRVdHlB?=
 =?utf-8?B?YzZEbmpRTFI3M0dudGpQcU0rdkQyK3gyWnJWazRHZk45TWJYS0N6emxzMnZI?=
 =?utf-8?B?b0d0ZU1YcnlXLzRObVhTci9uVGxKTjh5NzB0RUREZ3JveEYvOTVhN281cXJz?=
 =?utf-8?B?UTF6dXR2UXBLNlZ1QzI2dVJSdEVZSG9RK01jd1FON0ZrZWZHRUtsRjcvTHBP?=
 =?utf-8?B?VXdDamZDcjNFSkREWlNmOUZvaUdlQnFyanVaaTVScEtTSDdHOEpEaEJ1V2g0?=
 =?utf-8?B?eFRBbmhlUUIrNmxpcGd6Z3NVb25xdnFRbnNFa2gybUFoUGphOUNIRlRES3pF?=
 =?utf-8?B?SFhHTFdOdWZ1aVZKMS9wRGdQckJxcFEzODBYTTByQU5hS05UTSsxbFpETGZi?=
 =?utf-8?B?NzVldzJZS1BoSFpHY2VCdWZIcjVLY29VOFVzYWZJdDEzNksxUlNjdk1FaldM?=
 =?utf-8?B?VXl2VnByQzgrLzZjWUNOeEJ2WjF3bGxsT2lZWXZjd2NLVlI0WmpOMUVPZDNy?=
 =?utf-8?B?YlV5blFpWlN0TzdpZlBmbkpReGVOZ1A5dmNVRkNQa3NnRDBCcFFXWVdaN0Vs?=
 =?utf-8?B?M2hraDZXSzVCQ1Z1bW5icmx2ZUw1T2RjbStnVElKZjdZb3VZWFJXaGJmak1J?=
 =?utf-8?B?bDU3cU5KZzg4UjgrZ0NoT216T1BKWHI1VWYrbzg5UDRYM245TFpBV3FSamJO?=
 =?utf-8?B?L3Vmb1M2YWJnSnZOa2N0YlgwZmMwdkNGZS9zYXlBS29NODdZUW0rc1dyU0ZD?=
 =?utf-8?B?eHh3WG9DN1Q0M3h6d041Z2JUMGx4NkNxSVdBcWFPZjVkVHU5S3BLVjhRVklk?=
 =?utf-8?B?QlNVV010NlAranVpZjh5bmxrcU1FZlpBWjdyQ204RERwc1FoazVQZnRURGRm?=
 =?utf-8?B?RVZKb05YUlp0WTc2eHkzRXFTRmdZa1ZNc2Y0dGdnVUw0c3psaUgwTFdCNTFt?=
 =?utf-8?B?RkM4NGozMG9hMTQrdmpzYVAyYzlnaWZmd3dTTk9sMC9Jc2wwSlFIa3hCbllV?=
 =?utf-8?B?dEtsVm92bk11djkrWkNJdjUzY2MwVmFlQUZXYjg0b1ZJbmZBUnJNVFNocjBF?=
 =?utf-8?B?TU5QbUVkZk5ZcUk1b1BJV2lpNzRrc0tNQ0JPa0hjZGo4TFJWTmZvNlQwQit3?=
 =?utf-8?B?Mkg2NWxtenhEaGlKVTJ0NUhDUXdWRjFPdmVYOVFpNkR6eENiWHpRS3dUVlhz?=
 =?utf-8?B?cytqT1dzOWhNbFJwclhvbmZlRUNkV0tWb0dSek1LNEhkNjNoTDJKbGtVMlp1?=
 =?utf-8?B?YzNxcTlGNmdOTHhKZDUvQXJpMnV0S3RXY05YQzNHcXVTaEFoaEd0Nlk4UENV?=
 =?utf-8?B?VGZpdEd5Umc5WFNUb2NibE5XZDBxenoxeHJoWDhrZjZ4M0JTUjdsQWFtem5h?=
 =?utf-8?B?VGFvSUtwSU8yVU0xNGJ2MUZPNWZLK0VFczgrY0NaMHdUSmM5VUhkYU1XZjl3?=
 =?utf-8?Q?UoWw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26eed1f4-c545-442e-1ffa-08dc78d8ae21
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 14:25:21.3720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vwMWMyA+L/rc0C46/+zl+cUcwRVAsxxfsO+jgtyTyblUAsHb0s/xOyqEb1CTjyPU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8547

Hi Peter,

On 5/17/24 16:51, Peter Newman wrote:
> Hi Reinette, Babu,
> 
> On Fri, May 3, 2024 at 2:15 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>>
>> Hi Peter,
>>
>> On 5/3/2024 2:00 PM, Peter Newman wrote:
>>> Hi Babu,
>>>
>>> On Fri, May 3, 2024 at 1:44 PM Moger, Babu <bmoger@amd.com> wrote:
>>>>
>>>> Hi Peter,
>>>>
>>>> On 5/2/2024 7:57 PM, Peter Newman wrote:
>>>>> Hi Reinette,
>>>>>
>>>>> On Thu, May 2, 2024 at 4:21 PM Reinette Chatre
>>>>>> I do think ABMC should be enabled by default when available and it looks
>>>>>> to be what this series aims to do [1]. The way I reason about this is
>>>>>> that legacy user space gets more reliable monitoring behavior without
>>>>>> needing to change behavior.
>>>>>
>>>>> I don't like that for a monitor assignment-aware user, following the
>>>>> creation of new monitoring groups, there will be less monitors
>>>>> available for assignment. If the user wants precise control over where
>>>>> monitors are allocated, they would need to manually unassign the
>>>>> automatically-assigned monitor after creating new groups.
>>>>>
>>>>> It's an annoyance, but I'm not sure if it would break any realistic
>>>>> usage model. Maybe if the monitoring agent operates independently of
>>>>
>>>> Yes. Its annoyance.
>>>>
>>>> But if you think about it, normal users don't create too many groups.
>>>> They wont have to worry about assign/unassign headache if we enable
>>>> monitor assignment automatically. Also there is pqos tool which uses
>>>> this interface. It does not have to know about assign/unassign stuff.
>>>
>>> Thinking about this again, I don't think it's much of a concern
>>> because the automatic assignment on mongroup creation behavior can be
>>> trivially disabled using a boolean flag.
>>
>> This could be a config option.
> 
> I'd like to work out the details of this option.
> 
> info/L3_MON/mbm_assign_on_mkdir?
> 
> boolean (parsed with kstrtobool()), defaulting to true?

I am thinking is not a big concern. We only have limited (32) counters.
Automatic monitor assignment works only for first 16 groups(2 counters for
each group). When the counters are exhausted auto assignment does not
work. In your case(with more than 16 groups) the auto assignment does not
work. I feel having a config option is really not necessary.

 --
Thanks
Babu Moger