Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934907AbYBAFBL (ORCPT ); Fri, 1 Feb 2008 00:01:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933204AbYBAEoG (ORCPT ); Thu, 31 Jan 2008 23:44:06 -0500 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:48664 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1764596AbYBAEoF (ORCPT ); Thu, 31 Jan 2008 23:44:05 -0500 Date: Thu, 31 Jan 2008 20:43:58 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Robin Holt cc: Andrea Arcangeli , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com Subject: Re: [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges In-Reply-To: <20080201042408.GG26420@sgi.com> Message-ID: References: <20080131045750.855008281@sgi.com> <20080131045812.785269387@sgi.com> <20080201042408.GG26420@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 21 On Thu, 31 Jan 2008, Robin Holt wrote: > > Index: linux-2.6/mm/memory.c > ... > > @@ -1668,6 +1678,7 @@ gotten: > > page_cache_release(old_page); > > unlock: > > pte_unmap_unlock(page_table, ptl); > > + mmu_notifier(invalidate_range_end, mm, 0); > > I think we can get an _end call without the _begin call before it. If that would be true then also the pte would have been left locked. We always hit unlock. Maybe I just do not see it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/