Received-SPF: pass (google.com: domain of linux-kernel+bounces-183869-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f23e2669-c5b9-4257-ad75-f1431690a544@linux.ibm.com>
Date: Mon, 20 May 2024 09:56:07 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] dt-bindings: i2c: i2c-fsi: Convert to json-schema
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-i2c@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
        andi.shyti@kernel.org
References: <20240514205454.158157-1-eajames@linux.ibm.com>
 <79bed5c3-14be-4f15-a2f8-2e2342cb6b57@kernel.org>
Content-Language: en-US
From: Eddie James <eajames@linux.ibm.com>
In-Reply-To: <79bed5c3-14be-4f15-a2f8-2e2342cb6b57@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 5/19/24 13:03, Krzysztof Kozlowski wrote:
> On 14/05/2024 22:54, Eddie James wrote:
>
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ibm,i2c-fsi
>> +
>> +  reg:
>> +    items:
>> +      - description: FSI slave address
>> +
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 0
>> +
>> +patternProperties:
>> +  "^i2c(@.*)?":
> Either you have or you have not unit addresses. Please fix the pattern.
> Why is this so flexible? Do you want to deprecate i2c-bus in favor of
> i2c? If so, then example should use new naming. I am fine with children
> as i2c-bus, assuming this is allowed by dtschema. Did you actually test it?


This is the exact pattern of the i2c-controller schema node name, which 
I thought would be good. I can make it more specific. But yes I tested 
it, i2c-bus works fine


Thanks, Eddie


>
> Best regards,
> Krzysztof
>