Received-SPF: pass (google.com: domain of linux-kernel+bounces-183873-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240517191000.11390-1-grygorii.tertychnyi@leica-geosystems.com>
 <6eee1069-81ae-495a-850f-7f526006db8b@web.de> <CAGFuAuyXhBT8Nkvz5qN8iejeoHMFmx1b86tTNmpVfQ2xqjMtLw@mail.gmail.com>
 <a42d75ad-8065-49f0-906a-c8ae3761457c@lunn.ch>
In-Reply-To: <a42d75ad-8065-49f0-906a-c8ae3761457c@lunn.ch>
From: grygorii tertychnyi <grembeter@gmail.com>
Date: Mon, 20 May 2024 17:01:34 +0200
Message-ID: <CAGFuAuwot_7+R=J4NC=0Z_48YZ-RTJjRUoQnSjZUvpt=AWF39Q@mail.gmail.com>
Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled
To: Andrew Lunn <andrew@lunn.ch>
Cc: Markus Elfring <Markus.Elfring@web.de>, 
	Grygorii Tertychnyi <grygorii.tertychnyi@leica-geosystems.com>, 
	bsp-development.geo@leica-geosystems.com, linux-i2c@vger.kernel.org, 
	kernel-janitors@vger.kernel.org, Peter Korsgaard <peter@korsgaard.com>, 
	Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 20, 2024 at 3:41=E2=80=AFPM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote:
> > On Sun, May 19, 2024 at 7:25=E2=80=AFAM Markus Elfring <Markus.Elfring@=
web.de> wrote:
> > >
> > > =E2=80=A6
> > > > Sometimes it causes failure for the very first message transfer, =
=E2=80=A6
> > >
> > > Does such an information indicate the need for the tag =E2=80=9CFixes=
=E2=80=9D?
> >
> > I'm not sure: the original initialization order was introduced by the
> > very first commit
> > 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C contro=
ller").
>
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
>   It fixes a problem like an oops, a hang, data corruption, a real
>   security issue, a hardware quirk, a build error (but not for things
>   marked CONFIG_BROKEN), or some =E2=80=9Coh, that=E2=80=99s not good=E2=
=80=9D issue.
>
> Your description of the very first message transfer failing sounds
> like a data corruption? Using the commit which adds the driver is also
> fine, some bugs have been there all the time.

Thanks! Yes, it is a data corruption.

> Remember to add a
>
> Cc: stable@vger.kernel.org

I will send v2.

Regards,
Grygorii