Received-SPF: pass (google.com: domain of linux-kernel+bounces-183875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, "Ismail, Mustafa"
	<mustafa.ismail@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky
	<leon@kernel.org>, Kees Cook <keescook@chromium.org>, "Gustavo A. R. Silva"
	<gustavoars@kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>
Subject: RE: [PATCH] RDMA/irdma: Annotate  flexible array with __counted_by()
 in struct irdma_qvlist_info
Thread-Topic: [PATCH] RDMA/irdma: Annotate  flexible array with __counted_by()
 in struct irdma_qvlist_info
Thread-Index: AQHaqbqLrIM5z5IgKUCP6kN3olXXYLGgOYbQ
Date: Mon, 20 May 2024 15:02:01 +0000
Message-ID: <IA1PR11MB7317A294F4AAFFBE7263EA6CE9E92@IA1PR11MB7317.namprd11.prod.outlook.com>
References: <2ca8b14adf79c4795d7aa95bbfc79253a6bfed82.1716102112.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <2ca8b14adf79c4795d7aa95bbfc79253a6bfed82.1716102112.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eSTM2lIaHXZDUYYErNFZX2QSnFevPjpWOKrs+s4vYa6FD9yePfS8DFpSBWcU?=
 =?us-ascii?Q?owmFQh+Sr9PxqNR+OZpJFwuK7vEhEgsjakWyhed/setOdX60kA3eKpPtA2z7?=
 =?us-ascii?Q?zcMvjcpWgGs+Q/kHBDtlb3PJAmErc95xiYKSm2cOpRSrMqqMo5sMFHYT7SBC?=
 =?us-ascii?Q?M0jyL2Cne4gx3RX6cmg7DKYxRf5LeMh3XFpjm9eHCnQDr5y/5mACxcrd3Ld1?=
 =?us-ascii?Q?sDw3UTz6aIpJNMO9anp4Vn6nmUsF/lHRpb7OoTkuKdeNz8tEgmoPn7fB73H7?=
 =?us-ascii?Q?A1kFgCKKl3RshcbVyQ3AhLi2pSf+yX09JEBeHEG+SJWLUJgNjO9Tey0nttFj?=
 =?us-ascii?Q?bfAjxPifBrZLXF1XAjezaw/368ng3czsWlqIj6PM8jpPVVwkVou2+5j8NpmR?=
 =?us-ascii?Q?GYJf0YwBjmT335CgeJfwjDsDL3jZC8iRSQRaww3fuBkpPHGGhLwUkGk6dFhR?=
 =?us-ascii?Q?Nkf9o9/T3kNOMa0EekGHrgjWfuzX9XcFcdu4v14OYh0Sw27g0AtPburx6y36?=
 =?us-ascii?Q?TNgyhG0KDSZeQ5wmmqI21Z+a7ekk5c6rX8+UKDSPMmPiVrFzrTXjVm8DId0T?=
 =?us-ascii?Q?cjCv4mb1eBiUTKuNPfkgElRUbzguc4o6OjwLbDg7KbywnP1UDGdqRT7YovT5?=
 =?us-ascii?Q?0NiDXUmMp9Jgt9C6vPxhUm64ZIPXDjXbGIjDK1AWYSEjU5venKT0DRrxNAlW?=
 =?us-ascii?Q?lHwj5AWa2HKrEOPiphwAt68iHPq2QTTqt0WZj6a2PJO9i59EzGO/MGtQSxEi?=
 =?us-ascii?Q?o7cc/Re3XGPcSYK1X5qf7qO9B9S1H/tvyTFljwJJGke3FKyPcSWUFBomP2Xz?=
 =?us-ascii?Q?0JSVOTXMPNr7H5cuEwmuIGfktOGQYchxNVGNWCLUkRvScB32jWEDTWo7XOLt?=
 =?us-ascii?Q?BsMbbMSG4wv5W/eoWAudCA2tob+loR0yyOjm25R0kwzRc4tzPmQ1ihIWzhUw?=
 =?us-ascii?Q?bMpp8Pvknj64ZjdT987j+px0g0k8RwQrIWXglKNxr/zGGomKrBjKCqWQwxL+?=
 =?us-ascii?Q?uDsEAZUsZk+P23MztBtC16fTqOUxrd5dZ7jdZ/cEpT7MnqIGR09agSEVnupi?=
 =?us-ascii?Q?+P9utdaIoIqJcZHHiRO2x1ECYEbBMRV3GjKO8H5OBSbFyQkC+QYkIjmTiHN+?=
 =?us-ascii?Q?2YRT/uQVFa4S/+lO78Y6Q1YYEcYqYmNEnQbcq+PTkDGPJpfUDRTx3BZ1H6++?=
 =?us-ascii?Q?osIae8sJk4SiKip4RQJCLYljQOJuBKiOdm6TqkihcCQTrdKNrCWR4fB3EZ/h?=
 =?us-ascii?Q?el2BDRZECtlzQvW80ZRXDGwXN2V6zcMSx97jVngEpxYReP/zYFNbgJm+3hLa?=
 =?us-ascii?Q?XI4cNuTGzmqwTU6JdIZ85JpN5jM7EP8COrL5TNfyjU2w5Gz+peN99JvCTmRe?=
 =?us-ascii?Q?SqDVLdF1rG++ND3IrxdbHF7JxVp/bU/5UM2GJNEGzWW08iw+IENyvlOkLwoG?=
 =?us-ascii?Q?DzriolK4UaN9E7njQEB610BCnrA8hBoqnQrjZgKkQlTQ6FujohZ1+/SvZJsK?=
 =?us-ascii?Q?R7d/9ASkJO5k2aOULjfXlB4ERZmONDUW2Oti/jxyPx8roJx7oXcy/Msw+F2m?=
 =?us-ascii?Q?cb/5ajvrakUn2KiLFuLHZJdF8dHiwOEHYkEPUV5N?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7317.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d737ab3-2b1a-43b8-bc7e-08dc78ddcdf5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 15:02:01.7694
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w2j9FUpJuuCuUV5SCMOdB8UP1e7g5z7REAmfrUbHAR10NSTHfzt/08OY4PjGu1sLYZz6N6RoQICrwZuxKzOeKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7600
X-OriginatorOrg: intel.com

> Subject: [PATCH] RDMA/irdma: Annotate flexible array with __counted_by() =
in
> struct irdma_qvlist_info
>=20
> 'num_vectors' is used to count the number of elements in the 'qv_info'
> flexible array in "struct irdma_qvlist_info".
>=20
> So annotate it with __counted_by() to make it explicit and enable some
> additional checks.
>=20
> This allocation is done in irdma_save_msix_info().
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/infiniband/hw/irdma/main.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/hw/irdma/main.h
> b/drivers/infiniband/hw/irdma/main.h
> index b65bc2ea542f..9f0ed6e84471 100644
> --- a/drivers/infiniband/hw/irdma/main.h
> +++ b/drivers/infiniband/hw/irdma/main.h
> @@ -239,7 +239,7 @@ struct irdma_qv_info {
>=20
>  struct irdma_qvlist_info {
>  	u32 num_vectors;
> -	struct irdma_qv_info qv_info[];
> +	struct irdma_qv_info qv_info[] __counted_by(num_vectors);
>  };

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>