Received-SPF: pass (google.com: domain of linux-kernel+bounces-183923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 20 May 2024 11:44:28 -0400
From: Frank Li <Frank.li@nxp.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com,
	sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, marex@denx.de,
	linux-clk@vger.kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
	shengjiu.wang@gmail.com
Subject: Re: [PATCH v4 2/5] clk: imx: clk-audiomix: Add reset controller
Message-ID: <Zktv3OcDbV1cggP1@lizhi-Precision-Tower-5810>
References: <1716188963-16175-1-git-send-email-shengjiu.wang@nxp.com>
 <1716188963-16175-3-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1716188963-16175-3-git-send-email-shengjiu.wang@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5GtSpWwmTcnFNlcTaliMC3o/kmPSEzmrdZYcY+9JU/eu9n8ghumUuXdB9/Nf?=
 =?us-ascii?Q?S9KfqCCf3jJdZYUOs35ntmSpLtXNhO+/MUI2xgT1O/jN/cgxKJ5KaCD/vAsp?=
 =?us-ascii?Q?YflPy0Av8SPXWeIDz/U+J+mAfVHqxUaEDLImfEctTV9ygSsNzpaTJdJcc38D?=
 =?us-ascii?Q?MyGN1sSrkk9Q35YpFFs2pGYJq1JiLuChOfiPyRwHqJi/P+DtshaF4w1Pqjbz?=
 =?us-ascii?Q?75EXrSCvPzuHwmn7N3zAQKBhby5wC8VewyJd8TlaZYZAPUbzvDkEpZx5f2bJ?=
 =?us-ascii?Q?7nR90GYFAwp7c9WM8z8X0QyjoDR3zMiQ5/HM6atrTWx/lAbV/oerkVoZ59DE?=
 =?us-ascii?Q?X7KqIttodfhV8ioAopJs5CHrovcDvrv5DbSxqHinCpJCsBCqcbBEBunv3WPO?=
 =?us-ascii?Q?xBquE5SPJryAntq+vWQ3zaGRLPsAZJZUmYhtlrEDRor2u1gxhstt0TnQ6owC?=
 =?us-ascii?Q?Q5QngH9eIIeQktkQ+/lnoThlvBD2ha/NPxj61fyGlob1r1hqIDWP1j4YrMAy?=
 =?us-ascii?Q?opbZjtFKXOi5HXQBAtDrVq6bs6Amb8RHqb8i1pdujXyTCSVZtsVO/0QC9Hjf?=
 =?us-ascii?Q?tsxHUywIovemhRGB32iYkUDf22XfdXkq4ZTRkGvaHTrOyrsH1W9DZMx2xgYC?=
 =?us-ascii?Q?MN+G9zlNrnOd7L7FrlC8qVmWDaPe+Oz7KDq5YEc4ERmodIKQ3VLa/8A3COel?=
 =?us-ascii?Q?JVemwDZpZDh3FXJQ0roGhDCDppY/Sn0ItijGbQ6JuGxQnmHsKaHmEJcqNVlx?=
 =?us-ascii?Q?xONRZQEhDK15o28Z1M65UHsXxObq9NWmM5CSDVSkmEDkkzsd2piPROuxwttN?=
 =?us-ascii?Q?udPTgWsnw+Km80xVEF6ZZLsrkYmb2PM9vF199Wr8c2I6U25GO0IXcAZ9UA1J?=
 =?us-ascii?Q?pEqbNY1d0A3pKimYducJVh0MRQWIhAPn0YNrT9JmMM0WE0BcEGdzLa9powGd?=
 =?us-ascii?Q?CuHMdRHsb5qpLtIklMd79nJkw6KdqQaBIGaDs9jkxAijXMz1c+aYBhmUCkDF?=
 =?us-ascii?Q?xlKD8P2cuQDY/jP78hZgHxr5FuZ+95TBe9ENgczvAvQ/dHIp8e8ugyiW2hoi?=
 =?us-ascii?Q?BOz842q47DhHoEquTQqB+3o68/N6t6ictixNZkoPE+08JWNBGkd+mFZy6pf0?=
 =?us-ascii?Q?sLqRpDY+cNm8hNQlDsZWBt3G0ZA4g1wo9VCugecf0QYxxJVhx1eyVEwp4RBL?=
 =?us-ascii?Q?TGf6ZJG4LVVTOV+pdKLCNNcmC4FId4SatwaXMyyoCxhYayn9TRAczEBzytQC?=
 =?us-ascii?Q?o3BM1Dujlc5JkwFmifJy855FaA6lRKssuDDs/JWwWhghpEnH+FP/f9mEIwYb?=
 =?us-ascii?Q?XN44K5BI+T7lr1v7mmVeSqTDnkAs/o8wCagQlW+6O2Lfovi0tFuqTmJRIsFl?=
 =?us-ascii?Q?WfzdkBxkbjXyoJd1GnJGqRdfIv/VKi5Dv22oXcAhBlezXoqK76dggXbzRB5y?=
 =?us-ascii?Q?f2onCg5U819usUBcigJ3i4HSpJg+TxIr7shgi8v9V7IftGvY9Mf5Yf9ADsff?=
 =?us-ascii?Q?4lCdnH6jwCWMJobD8GrMW/FRwBsgi/C3/K4leHoVD8zXhbkXOF7EkwaZtc9O?=
 =?us-ascii?Q?NvwxxKs6poU+QxslwAt/BWO1kbOud4eYX3qTnezS?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b8e66e2-79f7-402b-5e81-08dc78e3c271
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 15:44:39.6136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k/TNDr1tHyQSn+pINnOAm7QnzKabc4c0k3skFH5rOMwWREtcclzPdFf6WUSiRpIJZe4un2Rl+UwyT3xS+VtoFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9370

On Mon, May 20, 2024 at 03:09:20PM +0800, Shengjiu Wang wrote:
> Audiomix block control can be a reset controller for
> Enhanced Audio Return Channel (EARC), which is one of
> modules in this audiomix subsystem.
> 
> The reset controller is supported by the auxiliary device
> framework.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  drivers/clk/imx/Kconfig               |  1 +
>  drivers/clk/imx/clk-imx8mp-audiomix.c | 61 +++++++++++++++++++++++++++
>  2 files changed, 62 insertions(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index 6da0fba68225..9edfb030bea9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -81,6 +81,7 @@ config CLK_IMX8MP
>  	tristate "IMX8MP CCM Clock Driver"
>  	depends on ARCH_MXC || COMPILE_TEST
>  	select MXC_CLK
> +	select AUXILIARY_BUS
>  	help
>  	    Build the driver for i.MX8MP CCM Clock Driver
>  
> diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
> index b381d6f784c8..d2eaabe431cd 100644
> --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2022 Marek Vasut <marex@denx.de>
>   */
>  
> +#include <linux/auxiliary_bus.h>
>  #include <linux/clk-provider.h>
>  #include <linux/device.h>
>  #include <linux/io.h>
> @@ -217,6 +218,62 @@ struct clk_imx8mp_audiomix_priv {
>  	struct clk_hw_onecell_data clk_data;
>  };
>  
> +#if IS_ENABLED(CONFIG_RESET_CONTROLLER)
> +
> +static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev)
> +{
> +	struct auxiliary_device *adev = _adev;
> +
> +	auxiliary_device_delete(adev);
> +	auxiliary_device_uninit(adev);
> +}
> +
> +static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev)
> +{
> +	struct auxiliary_device *adev = to_auxiliary_dev(dev);
> +
> +	kfree(adev);
> +}
> +
> +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> +							 struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	struct auxiliary_device *adev;
> +	int ret;
> +
> +	adev = kzalloc(sizeof(*adev), GFP_KERNEL);


You may use scoped free

	struct auxiliary_device *adev __free(kfree) = kzalloc(sizeof(*adev), GFP_KERNEL);

> +	if (!adev)
> +		return -ENOMEM;
> +
> +	adev->name = "reset";
> +	adev->dev.parent = dev;
> +	adev->dev.release = clk_imx8mp_audiomix_reset_adev_release;
> +
> +	ret = auxiliary_device_init(adev);
> +	if (ret) {
> +		kfree(adev);
> +		return ret;
> +	}

if use scoped free, 

	if (ret)
		return ret;

> +
> +	ret = auxiliary_device_add(adev);
> +	if (ret) {
> +		auxiliary_device_uninit(adev);
> +		kfree(adev);
> +		return ret;

the same here. 

> +	}
> +
> +	return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister_adev, adev);

if use scope free
	return devm_add_action_or_reset(dev, clk_imx8mp_audiomix_reset_unregister_adev, no_free_ptr(adev));

> +}
> +
> +#else /* !CONFIG_RESET_CONTROLLER */
> +
> +static int clk_imx8mp_audiomix_reset_controller_register(struct clk_imx8mp_audiomix_priv *priv)
> +{
> +	return 0;
> +}
> +
> +#endif /* !CONFIG_RESET_CONTROLLER */
> +
>  static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
>  {
>  	struct clk_imx8mp_audiomix_priv *priv = dev_get_drvdata(dev);
> @@ -337,6 +394,10 @@ static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_clk_register;
>  
> +	ret = clk_imx8mp_audiomix_reset_controller_register(dev, priv);
> +	if (ret)
> +		goto err_clk_register;
> +
>  	pm_runtime_put_sync(dev);
>  	return 0;
>  
> -- 
> 2.34.1
>